Remove assertions on logs

Author: sophio-japharidze-sonarsource

src/test/java/org/sonarsource/sonarlint/ls/mediumtests/AbstractLanguageServerMediumTests.java

@@ -517,7 +517,7 @@ public CompletableFuture<List<Object>> configuration(ConfigurationParams configu
           } else if (item.getScopeUri() != null && !item.getSection().equals(SONARLINT_CONFIGURATION_NAMESPACE)) {
             result
               .add(Optional.ofNullable(folderSettings.get(item.getScopeUri()))
-                .orElse(new HashMap<>()));
+                .orElseThrow(() -> new IllegalStateException("No settings mocked for workspaceFolderPath " + item.getScopeUri())));
             // we don't want to repeat the same setting for one folder 5 times :)
             break;
           }

src/test/java/org/sonarsource/sonarlint/ls/mediumtests/ConnectedModeMediumTests.java

@@ -495,7 +495,6 @@ void analysisConnected_find_tracked_hotspot_after_sq_10_1() {
 
     var uriInFolder = folder1BaseDir.resolve("hotspot.py").toUri().toString();
     addConfigScope(folder1BaseDir.toUri().toString());
-    awaitUntilAsserted(() -> assertThat(client.logs).anyMatch(messageParams -> messageParams.getMessage().contains("Merged 1 hotspots in store. Closed 0.")));
     lsProxy.didLocalBranchNameChange(new SonarLintExtendedLanguageServer.DidLocalBranchNameChangeParams(folder1BaseDir.toUri().toString(), "master"));
 
     didOpen(uriInFolder, "python", "IP_ADDRESS = '12.34.56.78'\n");
@@ -1010,7 +1009,6 @@ void change_hotspot_status_to_resolved() {
 
     var uriInFolder = folder1BaseDir.resolve(analyzedFileName).toUri().toString();
     addConfigScope(folder1BaseDir.toUri().toString());
-    awaitUntilAsserted(() -> assertThat(client.logs).anyMatch(messageParams -> messageParams.getMessage().contains("Merged 1 hotspots in store. Closed 0.")));
     lsProxy.didLocalBranchNameChange(new SonarLintExtendedLanguageServer.DidLocalBranchNameChangeParams(folder1BaseDir.toUri().toString(), "master"));
 
     didOpen(uriInFolder, "python", "IP_ADDRESS = '12.34.56.78'\n");
@@ -1087,7 +1085,6 @@ void should_not_change_hotspot_status_to_resolved() {
 
     var uriInFolder = folder1BaseDir.resolve(analyzedFileName).toUri().toString();
     addConfigScope(folder1BaseDir.toUri().toString());
-    awaitUntilAsserted(() -> assertThat(client.logs).anyMatch(messageParams -> messageParams.getMessage().contains("Merged 1 hotspots in store. Closed 0.")));
     lsProxy.didLocalBranchNameChange(new SonarLintExtendedLanguageServer.DidLocalBranchNameChangeParams(folder1BaseDir.toUri().toString(), "master"));
 
     didOpen(uriInFolder, "python", "IP_ADDRESS = '12.34.56.78'\n");
@@ -1177,7 +1174,6 @@ void change_hotspot_status_permission_check() throws ExecutionException, Interru
 
     var uriInFolder = folder1BaseDir.resolve(analyzedFileName).toUri().toString();
     addConfigScope(folder1BaseDir.toUri().toString());
-    awaitUntilAsserted(() -> assertThat(client.logs).anyMatch(messageParams -> messageParams.getMessage().contains("Merged 1 hotspots in store. Closed 0.")));
 
     didOpen(uriInFolder, "python", "IP_ADDRESS = '12.34.56.78'\n");
 

src/test/java/org/sonarsource/sonarlint/ls/mediumtests/LanguageServerMediumTests.java

@@ -745,7 +745,6 @@ void testListAllRules() {
   }
 
   @Test
-  @Disabled
   void logErrorWhenClientFailedToReturnConfiguration(@TempDir Path tempDir) {
     // No workspaceFolderPath settings registered in the client mock, so it should fail when server will request workspaceFolderPath
     // configuration
@@ -1179,6 +1178,7 @@ void accepted_binding_suggestion() {
   @Override
   protected void setUpFolderSettings(Map<String, Map<String, Object>> folderSettings) {
     addSonarQubeConnection(client.globalSettings, CONNECTION_ID, mockWebServerExtension.url("/"), TOKEN);
+    folderSettings.put(analysisDir.toUri().toString(), new HashMap<>());
   }
 
   private Predicate<? super MessageParams> notFromContextualTSserver() {