Skip to content

Commit c0c8bb5

Browse files
committed
SLLS-23 Use URL encoding method from core instead of local util
1 parent acd287a commit c0c8bb5

File tree

2 files changed

+2
-10
lines changed

2 files changed

+2
-10
lines changed

src/main/java/org/sonarsource/sonarlint/ls/CommandManager.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@
4646
import org.sonarsource.sonarlint.core.client.api.connected.ConnectedSonarLintEngine;
4747
import org.sonarsource.sonarlint.core.client.api.standalone.StandaloneRuleDetails;
4848
import org.sonarsource.sonarlint.core.client.api.standalone.StandaloneRuleParam;
49+
import org.sonarsource.sonarlint.core.util.StringUtils;
4950
import org.sonarsource.sonarlint.ls.SonarLintExtendedLanguageClient.ShowRuleDescriptionParams;
5051
import org.sonarsource.sonarlint.ls.commands.ShowAllLocationsCommand;
5152
import org.sonarsource.sonarlint.ls.connected.ProjectBindingManager;
@@ -120,7 +121,7 @@ public List<Either<Command, CodeAction>> computeCodeActions(CodeActionParams par
120121
}
121122
String title = String.format("Open taint vulnerability '%s' on '%s'", ruleKey, actualBinding.getConnectionId());
122123
String serverUrl = settingsManager.getCurrentSettings().getServerConnections().get(actualBinding.getConnectionId()).getServerUrl();
123-
String projectKey = Utils.encodeUriComponent(actualBinding.getBinding().projectKey());
124+
String projectKey = StringUtils.urlEncode(actualBinding.getBinding().projectKey());
124125
String issueUrl = String.format("%s/project/issues?id=%s&issues=%s&open=%s", serverUrl, projectKey, issue.key(), issue.key());
125126
codeActions.add(newQuickFix(d, title, SONARLINT_BROWSE_TAINT_VULNERABILITY, Collections.singletonList(issueUrl)));
126127
});

src/main/java/org/sonarsource/sonarlint/ls/Utils.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -66,15 +66,6 @@ public static void interrupted(InterruptedException e) {
6666
Thread.currentThread().interrupt();
6767
}
6868

69-
public static String encodeUriComponent(String toEncode) {
70-
try {
71-
return URLEncoder.encode(toEncode, StandardCharsets.UTF_8.name());
72-
} catch (UnsupportedEncodingException e) {
73-
// Should not happen on a standard JVM
74-
throw new IllegalStateException(e);
75-
}
76-
}
77-
7869
public static String pluralize(long nbItems, String itemName) {
7970
return pluralize(nbItems, itemName, itemName + "s");
8071
}

0 commit comments

Comments
 (0)