Skip to content

Make listener contracts more clear and enforceable, OR remove them #5408

Open
@georgii-borovinskikh-sonarsource

Description

We currently have models & interfaces for SLCoreListeners living in the main SLCore assembly, while the implementations live in the SLCore.Listeners assembly.

For example, src/SLCore/Listener/Logger/ILoggerListener.cs vs. src/SLCore.Listeners/Implementation/LoggerListener.cs

The issue is that the ILoggerListener interface is marked as unused, which may confuse people unfamiliar with the project. The initial goal of adding the interfaces was to declare an external contract mainly for self-documentation's sake, but also for possible mock-ing in ITs later.

It needs to be made clear and self-evident what the purpose of those interfaces is, otherwise they need to be removed.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions