experimental: TU-isolation of IDEA-port symbols for mechanism #3 falsification

Move kVolatileTypeThreshold + type_invalidation_counts +
volatile_types + isVolatileType + recordTypeInvalidation out of
inline_cache.cpp's anonymous namespace into new translation unit
ic_volatile_types.cpp + .h.

inline_cache.cpp keeps the 2 invocation points (TypeWatcher::watch
early-return + notifyICsTypeChanged record call) plus the new header
include — net +4 lines vs upstream (was +21 on cluster5-pr).

Branch is experimental; tests whether yield_from + 4 x86-LARGER
regressions are caused by within-TU compiler-inlining shift from the
+21-line code-size addition.

Author: SonicField

cinderx/Jit/ic_volatile_types.cpp

@@ -0,0 +1,31 @@
+// Copyright (c) Meta Platforms, Inc. and affiliates.
+
+#include "cinderx/Jit/ic_volatile_types.h"
+
+#include "cinderx/Jit/containers.h"
+#include "cinderx/Common/ref.h"
+
+namespace jit {
+
+namespace {
+
+constexpr int kVolatileTypeThreshold = 10;
+
+jit::UnorderedMap<BorrowedRef<PyTypeObject>, int> type_invalidation_counts;
+jit::UnorderedSet<BorrowedRef<PyTypeObject>> volatile_types;
+
+}  // namespace
+
+bool isVolatileType(BorrowedRef<PyTypeObject> type) {
+  return volatile_types.count(type) > 0;
+}
+
+void recordTypeInvalidation(BorrowedRef<PyTypeObject> type) {
+  int& count = type_invalidation_counts[type];
+  count++;
+  if (count >= kVolatileTypeThreshold) {
+    volatile_types.emplace(type);
+  }
+}
+
+}  // namespace jit

cinderx/Jit/ic_volatile_types.h

@@ -0,0 +1,11 @@
+// Copyright (c) Meta Platforms, Inc. and affiliates.
+#pragma once
+
+#include "cinderx/Common/ref.h"
+
+namespace jit {
+
+bool isVolatileType(BorrowedRef<PyTypeObject> type);
+void recordTypeInvalidation(BorrowedRef<PyTypeObject> type);
+
+}  // namespace jit

cinderx/Jit/inline_cache.cpp

@@ -11,6 +11,7 @@
 #include "cinderx/Common/type.h"
 #include "cinderx/Common/util.h"
 #include "cinderx/Jit/containers.h"
+#include "cinderx/Jit/ic_volatile_types.h"
 #include "cinderx/StaticPython/strictmoduleobject.h"
 #include "cinderx/UpstreamBorrow/borrowed.h"
 #include "cinderx/module_state.h"
@@ -22,23 +23,6 @@ namespace jit {
 
 namespace {
 
-constexpr int kVolatileTypeThreshold = 10;
-
-jit::UnorderedMap<BorrowedRef<PyTypeObject>, int> type_invalidation_counts;
-jit::UnorderedSet<BorrowedRef<PyTypeObject>> volatile_types;
-
-bool isVolatileType(BorrowedRef<PyTypeObject> type) {
-  return volatile_types.count(type) > 0;
-}
-
-void recordTypeInvalidation(BorrowedRef<PyTypeObject> type) {
-  int& count = type_invalidation_counts[type];
-  count++;
-  if (count >= kVolatileTypeThreshold) {
-    volatile_types.emplace(type);
-  }
-}
-
 template <class T>
 struct TypeWatcher {
   jit::UnorderedMap<BorrowedRef<PyTypeObject>, jit::UnorderedSet<T*>> caches;