Skip to content

Squash commit history before upstream submission #4

Description

@SonicField

Squash commit history before upstream submission

The arm-jit-generators branch has 6 commits where 2 would suffice. The history includes a regression (frame_header init) and its revert, which are noise for upstream reviewers.

Current commits (oldest to newest)

  1. fa3f12e - Phase 5f: Enable generator JIT compilation on aarch64 (core fix)
  2. 504b786 - Add static_assert for sizeof(GenDataFooter) consistency
  3. 5b3cf6b - Phase 5f: Initialise frame_header in GenDataFooter (REGRESSED)
  4. d8a1e05 - Revert of frame_header init

Recommended squash

  • Squash to 1-2 commits: core fix + static_asserts
  • Remove the regression/revert pair from history
  • Do this before creating an upstream PR to facebookincubator/cinderx

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions