Merge pull request #1121 from adeniran19-maker/feature/contract-reentrancy-events-errors-flash-swap

fix(contract): normalize error codes, transient reentrancy guard, event schema, and flash swap bounds

Author: ayomideadeniran

backend-abi-registry/errorCodes.js

@@ -0,0 +1,104 @@
+/**
+ * @fileoverview Canonical SoroTask error codes and human-readable message decoder.
+ * Maps categorized on-chain Soroban contracterror discriminants into human-readable error descriptions.
+ * @module backend-abi-registry/errorCodes
+ */
+
+const ERROR_CODES = {
+  // ── 100..199: Authorization & Role-Based Access ──────────────────────────────
+  100: { name: 'Unauthorized', category: 'Auth', message: 'Caller is not authorized to perform this action' },
+  101: { name: 'UnauthorizedSlasher', category: 'Auth', message: 'Caller is not authorized to slash keeper' },
+  102: { name: 'OperatorAlreadySet', category: 'Auth', message: 'Operator address has already been set' },
+  103: { name: 'NotInitialized', category: 'Auth', message: 'Contract has not been initialized' },
+  104: { name: 'AlreadyInitialized', category: 'Auth', message: 'Contract has already been initialized' },
+  105: { name: 'FeatureDisabled', category: 'Auth', message: 'Requested protocol feature is disabled' },
+  106: { name: 'InsufficientDelegation', category: 'Auth', message: 'Keeper delegation amount is insufficient' },
+  107: { name: 'InvalidCommissionRate', category: 'Auth', message: 'Commission rate exceeds allowable maximum' },
+
+  // ── 200..299: Task Lifecycle & Validation ────────────────────────────────────
+  200: { name: 'InvalidInterval', category: 'TaskValidation', message: 'Task execution interval is invalid' },
+  201: { name: 'TaskPaused', category: 'TaskValidation', message: 'Task execution is currently paused' },
+  202: { name: 'TaskAlreadyPaused', category: 'TaskValidation', message: 'Task is already in a paused state' },
+  203: { name: 'TaskAlreadyActive', category: 'TaskValidation', message: 'Task is already in an active state' },
+  204: { name: 'TaskNotFound', category: 'TaskValidation', message: 'Specified task ID does not exist' },
+  205: { name: 'DuplicateTask', category: 'TaskValidation', message: 'Duplicate task registration detected' },
+  206: { name: 'InvalidPayload', category: 'TaskValidation', message: 'Task payload or arguments are malformed' },
+  207: { name: 'ArgsTooMany', category: 'TaskValidation', message: 'Number of task arguments exceeds limit' },
+  208: { name: 'ArgsTooLarge', category: 'TaskValidation', message: 'Total size of task arguments exceeds limit' },
+  209: { name: 'BountyBelowMinimum', category: 'TaskValidation', message: 'Task execution bounty is below required minimum' },
+  210: { name: 'InvalidBounty', category: 'TaskValidation', message: 'Task execution bounty parameters are invalid' },
+  211: { name: 'InvalidUpgradeVersion', category: 'TaskValidation', message: 'Target WASM upgrade version is invalid' },
+  212: { name: 'InvalidInsurancePolicy', category: 'TaskValidation', message: 'Insurance policy parameters are invalid' },
+
+  // ── 300..399: Execution, Dependency & Reentrancy ─────────────────────────────
+  300: { name: 'ReentrantCall', category: 'Execution', message: 'Reentrancy guard triggered on recursive entry' },
+  301: { name: 'SelfDependency', category: 'Execution', message: 'Task cannot depend on itself' },
+  302: { name: 'DependencyNotFound', category: 'Execution', message: 'Required task dependency not found' },
+  303: { name: 'CircularDependency', category: 'Execution', message: 'Circular dependency cycle detected' },
+  304: { name: 'DependencyBlocked', category: 'Execution', message: 'Task execution blocked by unresolved dependencies' },
+  305: { name: 'DependencyLimitExceeded', category: 'Execution', message: 'Maximum dependency count exceeded' },
+  306: { name: 'DependencyDepthExceeded', category: 'Execution', message: 'Maximum dependency tree depth exceeded' },
+  307: { name: 'KeeperStakeTooLow', category: 'Execution', message: 'Keeper active stake is below minimum threshold' },
+  308: { name: 'EmptyBundle', category: 'Execution', message: 'Task execution bundle contains zero steps' },
+  309: { name: 'BundleTooLarge', category: 'Execution', message: 'Task bundle size exceeds block limit' },
+  310: { name: 'BundleStepFailed', category: 'Execution', message: 'One or more bundle execution steps failed' },
+  311: { name: 'BlockExecutionLimitReached', category: 'Execution', message: 'Per-block task execution cap reached' },
+  312: { name: 'DecryptionFailed', category: 'Execution', message: 'Encrypted task parameter decryption failed' },
+  313: { name: 'OptimisticClaimPending', category: 'Execution', message: 'Optimistic challenge claim is currently pending' },
+  314: { name: 'NoOptimisticClaim', category: 'Execution', message: 'No active optimistic challenge claim found' },
+  315: { name: 'ChallengeWindowClosed', category: 'Execution', message: 'Optimistic challenge window has expired' },
+  316: { name: 'ChallengeWindowActive', category: 'Execution', message: 'Challenge window is still active' },
+  317: { name: 'FraudProofInvalid', category: 'Execution', message: 'Supplied optimistic fraud proof is invalid' },
+
+  // ── 400..499: Oracles, VRF & ZK Verifier ─────────────────────────────────────
+  400: { name: 'OracleNotSet', category: 'Oracle', message: 'Required price or data oracle is not configured' },
+  401: { name: 'OracleRequestFailed', category: 'Oracle', message: 'Oracle data request failed or reverted' },
+  402: { name: 'OracleInvalidResponse', category: 'Oracle', message: 'Oracle returned invalid or unparseable data' },
+  403: { name: 'OracleTimeout', category: 'Oracle', message: 'Oracle response exceeded timeout window' },
+  404: { name: 'OracleUnsupportedProvider', category: 'Oracle', message: 'Specified oracle provider is not supported' },
+  405: { name: 'VrfOracleNotSet', category: 'Oracle', message: 'VRF randomness oracle is not configured' },
+  406: { name: 'InvalidVrfRequest', category: 'Oracle', message: 'VRF randomness request parameters are invalid' },
+  407: { name: 'VrfRequestFailed', category: 'Oracle', message: 'VRF randomness fulfillment request failed' },
+  408: { name: 'VrfAlreadyFulfilled', category: 'Oracle', message: 'VRF request has already been fulfilled' },
+  409: { name: 'InvalidZkProof', category: 'Oracle', message: 'Zero-knowledge verification proof is invalid' },
+  410: { name: 'InvalidVdfProof', category: 'Oracle', message: 'Verifiable delay function proof is invalid' },
+
+  // ── 500..599: Yield, Flash Swaps & Treasury ──────────────────────────────────
+  500: { name: 'InsufficientBalance', category: 'Treasury', message: 'Contract or task escrow balance is insufficient' },
+  501: { name: 'YieldStrategyNotInitialized', category: 'Treasury', message: 'Yield strategy adapter has not been initialized' },
+  502: { name: 'InvalidYieldStrategy', category: 'Treasury', message: 'Yield strategy configuration is invalid' },
+  503: { name: 'YieldHarvestFailed', category: 'Treasury', message: 'Harvesting yield from external protocol failed' },
+  504: { name: 'InsufficientYield', category: 'Treasury', message: 'Yield generated is below expected threshold' },
+  505: { name: 'FlashSwapFailed', category: 'Treasury', message: 'Flash swap callback execution failed' },
+  506: { name: 'InsufficientFlashProfit', category: 'Treasury', message: 'Flash swap did not generate required minimum profit' },
+  507: { name: 'InvalidSlippage', category: 'Treasury', message: 'Slippage parameter exceeds maximum allowed tolerance' },
+
+  // ── 600..699: Volatility & Circuit Breakers ──────────────────────────────────
+  600: { name: 'VolatilityExceeded', category: 'Volatility', message: 'Asset volatility exceeds allowed tolerance limit' },
+  601: { name: 'VolatilityCircuitBreakerTripped', category: 'Volatility', message: 'Volatility circuit breaker tripped; execution paused' },
+  602: { name: 'VolatilityTimelockActive', category: 'Volatility', message: 'Volatility timelock is active; cannot execute until window expires' },
+};
+
+/**
+ * Decodes an on-chain numeric error code into a human-readable error description.
+ *
+ * @param {number} code - On-chain error discriminant.
+ * @returns {{ code: number, name: string, category: string, message: string }} Error metadata.
+ */
+function decodeErrorCode(code) {
+  const info = ERROR_CODES[code];
+  if (info) {
+    return { code, ...info };
+  }
+  return {
+    code,
+    name: 'UnknownError',
+    category: 'Unknown',
+    message: `Unknown contract error code: ${code}`,
+  };
+}
+
+module.exports = {
+  ERROR_CODES,
+  decodeErrorCode,
+};

backend-abi-registry/index.js

@@ -1,6 +1,7 @@
 const parser = require('./parser');
 const registry = require('./registry');
 const errorHandler = require('./errorHandler');
+const errorCodes = require('./errorCodes');
 const Monitor = require('./monitor');
 const { AbiCache } = require('./abiCache');
 
@@ -30,6 +31,14 @@ class ABIRegistryService {
     return errorHandler;
   }
 
+  getErrorCodes() {
+    return errorCodes;
+  }
+
+  decodeErrorCode(code) {
+    return errorCodes.decodeErrorCode(code);
+  }
+
   async getABI(contractId, wasmHash, fetchABI) {
     const cached = await this.cache.getPersistent(contractId, wasmHash);
     if (cached) return cached;

backend-abi-registry/tests/abi-registry.test.js

@@ -240,5 +240,22 @@ describe('ABIRegistryService', () => {
       expect(abiRegistryService.getRegistry()).toBe(registry);
       expect(abiRegistryService.getErrorHandler()).toBe(errorHandler);
     });
+
+    it('should decode canonical error codes correctly', () => {
+      const decoded100 = abiRegistryService.decodeErrorCode(100);
+      expect(decoded100.name).toBe('Unauthorized');
+      expect(decoded100.category).toBe('Auth');
+
+      const decoded300 = abiRegistryService.decodeErrorCode(300);
+      expect(decoded300.name).toBe('ReentrantCall');
+      expect(decoded300.category).toBe('Execution');
+
+      const decoded507 = abiRegistryService.decodeErrorCode(507);
+      expect(decoded507.name).toBe('InvalidSlippage');
+      expect(decoded507.category).toBe('Treasury');
+
+      const decodedUnknown = abiRegistryService.decodeErrorCode(9999);
+      expect(decodedUnknown.name).toBe('UnknownError');
+    });
   });
 });

contract/Cargo.toml

@@ -1,3 +1,5 @@
+[workspace]
+
 [package]
 name = "soro_task_contract"
 version = "0.1.0"

contract/src/events.rs

@@ -168,6 +168,9 @@ pub struct FeeDiscountTierUpdatedEvent {
     pub old_tier: u32,
     pub new_tier: u32,
     pub total_executions: u64,
+    pub timestamp: u64,
+}
+
 /// Event payload for oracle volatility breaches
 #[contracttype]
 #[derive(Clone, Debug)]
@@ -236,8 +239,8 @@ impl EventLogger {
         };
 
         let topics = (
-            Symbol::new(env, "sorotask"),
-            Symbol::new(env, "state_change"),
+            Symbol::new(env, "Task"),
+            Symbol::new(env, "StateChange"),
             task_id,
         );
         env.events().publish(topics, event_data);
@@ -272,8 +275,8 @@ impl EventLogger {
         };
 
         let topics = (
-            Symbol::new(env, "sorotask"),
-            Symbol::new(env, "execution"),
+            Symbol::new(env, "Task"),
+            Symbol::new(env, "Executed"),
             task_id,
         );
         env.events().publish(topics, event_data);
@@ -301,8 +304,8 @@ impl EventLogger {
         };
 
         let topics = (
-            Symbol::new(env, "sorotask"),
-            Symbol::new(env, "exec_step"),
+            Symbol::new(env, "Task"),
+            Symbol::new(env, "StepExecuted"),
             task_id,
         );
         env.events().publish(topics, event_data);
@@ -328,8 +331,8 @@ impl EventLogger {
         };
 
         let topics = (
-            Symbol::new(env, "sorotask"),
-            Symbol::new(env, "access_log"),
+            Symbol::new(env, "Auth"),
+            Symbol::new(env, "Access"),
             actor,
         );
         env.events().publish(topics, event_data);
@@ -352,8 +355,8 @@ impl EventLogger {
         };
 
         let topics = (
-            Symbol::new(env, "sorotask"),
-            Symbol::new(env, "task_invalidated"),
+            Symbol::new(env, "Task"),
+            Symbol::new(env, "Invalidated"),
             task_id,
         );
         env.events().publish(topics, event_data);
@@ -376,8 +379,8 @@ impl EventLogger {
         };
 
         let topics = (
-            Symbol::new(env, "sorotask"),
-            Symbol::new(env, "rate_limit_exceeded"),
+            Symbol::new(env, "Task"),
+            Symbol::new(env, "RateLimited"),
             task_id,
         );
         env.events().publish(topics, event_data);
@@ -399,8 +402,8 @@ impl EventLogger {
         };
 
         let topics = (
-            Symbol::new(env, "sorotask"),
-            Symbol::new(env, "encrypted_params_registered"),
+            Symbol::new(env, "Task"),
+            Symbol::new(env, "EncryptedParams"),
             task_id,
         );
         env.events().publish(topics, event_data);
@@ -418,17 +421,17 @@ impl EventLogger {
         let timestamp = env.ledger().timestamp();
         let event_data = DelegationPoolEvent {
             delegator,
-            keeper,
+            keeper: keeper.clone(),
             amount,
             commission_rate,
             action: action.clone(),
             timestamp,
         };
 
         let topics = (
-            Symbol::new(env, "sorotask"),
-            Symbol::new(env, "delegation_pool"),
+            Symbol::new(env, "Stake"),
             action,
+            keeper,
         );
         env.events().publish(topics, event_data);
     }