review changes

Author: DEATHB4DEFEAT

Robust.Server/ServerStatus/StatusHost.Handlers.cs

@@ -48,7 +48,8 @@ private async Task<bool> HandleStatus(IStatusHandlerContext context)
                 // Content can override these if it wants (e.g. stealthmins).
                 ["name"] = _serverNameCache,
                 ["players"] = _playerManager.PlayerCount,
-                ["engine_type"] = buildInfo.Engine,
+                // MV Launcher can filter based on engine
+                ["engine_type"] = buildInfo.EngineType,
                 ["engine"] = buildInfo.EngineVersion,
             };
 
@@ -137,7 +138,7 @@ private JsonObject GetExternalBuildInfo()
 
             return new JsonObject
             {
-                ["engine"] = buildInfo.Engine,
+                ["engine_type"] = buildInfo.EngineType,
                 ["engine_version"] = buildInfo.EngineVersion,
                 ["fork_id"] = buildInfo.ForkId,
                 ["version"] = buildInfo.Version,
@@ -164,7 +165,7 @@ private JsonObject GetExternalBuildInfo()
             }
             return new JsonObject
             {
-                ["engine"] = _cfg.GetCVar(CVars.BuildEngine),
+                ["engine_type"] = _cfg.GetCVar(CVars.BuildEngineType),
                 ["engine_version"] = _cfg.GetCVar(CVars.BuildEngineVersion),
                 ["fork_id"] = fork,
                 ["version"] = acm.ManifestHash,

Robust.Shared/CVars.cs

@@ -612,8 +612,8 @@ protected CVars()
         /// <summary>
         /// Engine type the launcher needs to connect to this server.
         /// </summary>
-        public static readonly CVarDef<string> BuildEngine =
-            CVarDef.Create("build.engine", "Multiverse");
+        public static readonly CVarDef<string> BuildEngineType =
+            CVarDef.Create("build.engine_type", "Multiverse");
 
         /// <summary>
         /// Engine version that launcher needs to connect to this server.

Robust.Shared/Utility/GameBuildInformation.cs

@@ -7,7 +7,7 @@ internal sealed record GameBuildInformation(
     string? ZipHash,
     string? ZipDownload,
     string ForkId,
-    string Engine,
+    string EngineType,
     string Version,
     string? ManifestHash,
     string? ManifestUrl,
@@ -19,7 +19,7 @@ public static GameBuildInformation GetBuildInfoFromConfig(IConfigurationManager
         var zipHash = cfg.GetCVar(CVars.BuildHash);
         var manifestHash = cfg.GetCVar(CVars.BuildManifestHash);
         var forkId = cfg.GetCVar(CVars.BuildForkId);
-        var engine = cfg.GetCVar(CVars.BuildEngine);
+        var engineType = cfg.GetCVar(CVars.BuildEngineType);
         var forkVersion = cfg.GetCVar(CVars.BuildVersion);
 
         var manifestDownloadUrl = Interpolate(cfg.GetCVar(CVars.BuildManifestDownloadUrl));
@@ -46,7 +46,7 @@ public static GameBuildInformation GetBuildInfoFromConfig(IConfigurationManager
             zipHash,
             zipDownload,
             forkId,
-            engine,
+            engineType,
             forkVersion,
             manifestHash,
             manifestUrl,