Reduce ProgramsAreAvailableOnCobc() calls (#483)

The function `ProgramsAreAvailableOnCobc()` is called unnecessarily
often and should only be called when the EDU is alive.

Author: PatrickKa

Sts1CobcSw/Edu/Edu.cpp

@@ -28,7 +28,6 @@
 #include <etl/vector.h>
 
 #include <algorithm>
-#include <array>
 #include <charconv>
 #include <cstddef>
 #include <cstdint>
@@ -61,8 +60,6 @@ constexpr auto cepData = 0x8b_b;  //! Data packet format is used (not a command
 // 1.5 s just to be sure.
 constexpr auto sendTimeout = 1500 * ms;
 constexpr auto receiveTimeout = 1500 * ms;
-// TODO: Can we choose a smaller value?
-constexpr auto flushReceiveBufferTimeout = 1 * ms;
 
 // TODO: Choose proper values
 // Max. number of send retries after receiving NACK

Sts1CobcSw/Firmware/EduPowerManagementThread.cpp

@@ -86,13 +86,16 @@ class EduPowerManagementThread : public RODOS::StaticThread<stackSize>
             nextEduProgramStartTimeBuffer.get(nextEduProgramStartTime);
             auto timeTillNextEduProgram = ToRodosTime(nextEduProgramStartTime) - CurrentRodosTime();
             auto eduHasUpdate = edu::updateGpioPin.Read() == hal::PinState::set;
-            auto noWorkMustBeDoneInTheNearFuture =
-                not eduHasUpdate and not edu::ProgramsAreAvailableOnCobc()
-                and timeTillNextEduProgram > persistentVariables.Load<"maxEduIdleDuration">();
-            if(eduIsAlive and noWorkMustBeDoneInTheNearFuture)
+            if(eduIsAlive)
             {
-                DEBUG_PRINT("Turning EDU off\n");
-                edu::TurnOff();
+                auto noWorkMustBeDoneInTheNearFuture =
+                    not eduHasUpdate and not edu::ProgramsAreAvailableOnCobc()
+                    and timeTillNextEduProgram > persistentVariables.Load<"maxEduIdleDuration">();
+                if(noWorkMustBeDoneInTheNearFuture)
+                {
+                    DEBUG_PRINT("Turning EDU off\n");
+                    edu::TurnOff();
+                }
             }
             else if(not eduIsAlive and timeTillNextEduProgram < (eduBootTime + eduBootTimeMargin))
             {

Sts1CobcSw/Firmware/EduProgramTransferThread.cpp

@@ -51,7 +51,7 @@ class EduProgramTransferThread : public RODOS::StaticThread<stackSize>
         {
             auto eduIsAlive = false;
             eduIsAliveBufferForProgramTransfer.get(eduIsAlive);
-            if(edu::ProgramsAreAvailableOnCobc() and eduIsAlive)
+            if(eduIsAlive and edu::ProgramsAreAvailableOnCobc())
             {
                 DEBUG_PRINT("Sending programs to EDU\n");
                 SendProgramsToEdu();