Remove TODO and FIXME for confirmed values

flo12356 · flo12356 · commit a10b9f883e72 · 2025-10-15T21:27:14.000Z
diff --git a/Sts1CobcSw/Bootloader/Main.cpp b/Sts1CobcSw/Bootloader/Main.cpp
@@ -17,7 +17,6 @@ using sts1cobcsw::ErrorCode;
 
 namespace
 {
-// FIXME: const value correct?
 constexpr int nResetsSinceRfLimit = 50;
 
 
diff --git a/Sts1CobcSw/Edu/Edu.cpp b/Sts1CobcSw/Edu/Edu.cpp
@@ -61,8 +61,6 @@ constexpr auto cepData = 0x8b_b;  //! Data packet format is used (not a command
 constexpr auto sendTimeout = 1500 * ms;
 constexpr auto receiveTimeout = 1500 * ms;
 
-// FIXME: How many nacks are ok
-// TODO: Choose proper values
 // Max. number of send retries after receiving NACK
 constexpr auto maxNNackRetries = 4;
 // Max. number of data packets for a single command
diff --git a/Sts1CobcSw/FileSystem/LfsFlash.cpp b/Sts1CobcSw/FileSystem/LfsFlash.cpp
@@ -39,8 +39,6 @@ auto Lock(lfs_config const * config) -> int;
 auto Unlock(lfs_config const * config) -> int;
 
 
-// TODO: Test with real HW
-// FIXME: Already tested with real HW?
 // max. 3.5 ms acc. W25Q01JV datasheet
 constexpr auto pageProgramTimeout = 5 * ms;
 // max. 400 ms acc. W25Q01JV datasheet (lfs_config.block_size = flash::sectorSize)
diff --git a/Sts1CobcSw/Firmware/EduListenerThread.cpp b/Sts1CobcSw/Firmware/EduListenerThread.cpp
@@ -27,7 +27,6 @@ namespace
 {
 constexpr auto stackSize = 5000U;
 constexpr auto eduIsAliveCheckInterval = 1 * s;
-// FIXME: const value correct?
 
 
 auto SuspendUntilEduIsAliveAndHasUpdate() -> void;
diff --git a/Sts1CobcSw/Firmware/EduPowerManagementThread.hpp b/Sts1CobcSw/Firmware/EduPowerManagementThread.hpp
@@ -11,7 +11,6 @@
 
 namespace sts1cobcsw
 {
-// FIXME: const value correct?
 inline constexpr auto eduPowerManagementThreadStartDelay = 15 * s;
 
 
diff --git a/Sts1CobcSw/Firmware/EduProgramQueueThread.cpp b/Sts1CobcSw/Firmware/EduProgramQueueThread.cpp
@@ -36,7 +36,6 @@ namespace
 constexpr auto stackSize = 1500U;
 // This thread must start before the EDU power management thread to ensure the correct start time
 // is published
-// FIXME: const value correct?
 constexpr auto eduProgramQueueThreadStartDelay = eduPowerManagementThreadStartDelay - 1 * s;
 static_assert(eduProgramQueueThreadStartDelay > 0 * s);
 constexpr auto eduCommunicationMargin = 2 * s;
diff --git a/Sts1CobcSw/Firmware/EduProgramTransferThread.cpp b/Sts1CobcSw/Firmware/EduProgramTransferThread.cpp
@@ -26,7 +26,6 @@ namespace
 {
 constexpr auto stackSize = 5000U;
 constexpr auto eduProgramTransferThreadInterval = 5 * s;
-// FIXME: const value correct?
 
 
 auto SendProgramsToEdu() -> void;
diff --git a/Sts1CobcSw/Firmware/StartupAndSpiSupervisorThread.cpp b/Sts1CobcSw/Firmware/StartupAndSpiSupervisorThread.cpp
@@ -47,7 +47,6 @@ constexpr auto stackSize = 3500 + EXTRA_SANITIZER_STACK_SIZE;
 
 inline constexpr auto initialSleepTime = 10 * ms;
 // TODO: Think about how often the supervision should run
-// FIXME: Think about how often the supervision should run
 constexpr auto supervisionPeriod = 1 * s;
 
 
diff --git a/Sts1CobcSw/Firmware/TelemetryThread.cpp b/Sts1CobcSw/Firmware/TelemetryThread.cpp
@@ -41,7 +41,6 @@ namespace sts1cobcsw
 {
 namespace
 {
-// FIXME: const value correct?
 constexpr auto stackSize = 1200U;
 constexpr auto telemetryThreadInterval = 30 * s;
 // The delay until the first telemetry record is published and thereby the first beacon is sent.
diff --git a/Sts1CobcSw/Fram/Fram.hpp b/Sts1CobcSw/Fram/Fram.hpp
@@ -35,8 +35,6 @@ using Address = strong::type<std::uint32_t,
                              strong::ordered>;
 
 
-// TODO: Set correct values
-// FIXME: already correct?
 inline constexpr auto memorySize = Size(1024 * 1024);
 inline constexpr auto correctDeviceId =
     DeviceId{0x7F_b, 0x7F_b, 0x7F_b, 0x7F_b, 0x7F_b, 0x7F_b, 0xC2_b, 0x26_b, 0x08_b};
diff --git a/Sts1CobcSw/WatchdogTimers/WatchdogTimers.cpp b/Sts1CobcSw/WatchdogTimers/WatchdogTimers.cpp
@@ -32,7 +32,6 @@ auto Initialize() -> void
 
 auto Feed() -> void
 {
-    // FIXME: const value correct?
     static constexpr auto watchdogFeedPulseDuration = 2 * ms;
     watchdogClearGpioPin.Set();
     SuspendFor(watchdogFeedPulseDuration);
@@ -54,7 +53,6 @@ auto Initialize() -> void
 
 auto Feed() -> void
 {
-    // FIXME: const value correct?
     static constexpr auto resetdogFeedPulseDuration = 2 * ms;
     resetdogClearGpioPin1.Set();
     resetdogClearGpioPin2.Set();

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,6 @@ using sts1cobcsw::ErrorCode;`
`17`	`17`
`18`	`18`	`namespace`
`19`	`19`	`{`
`20`		`-// FIXME: const value correct?`
`21`	`20`	`constexpr int nResetsSinceRfLimit = 50;`
`22`	`21`
`23`	`22`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,6 @@ namespace`
`27`	`27`	`{`
`28`	`28`	`constexpr auto stackSize = 5000U;`
`29`	`29`	`constexpr auto eduIsAliveCheckInterval = 1 * s;`
`30`		`-// FIXME: const value correct?`
`31`	`30`
`32`	`31`
`33`	`32`	`auto SuspendUntilEduIsAliveAndHasUpdate() -> void;`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,6 @@`
`11`	`11`
`12`	`12`	`namespace sts1cobcsw`
`13`	`13`	`{`
`14`		`-// FIXME: const value correct?`
`15`	`14`	`inline constexpr auto eduPowerManagementThreadStartDelay = 15 * s;`
`16`	`15`
`17`	`16`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,6 @@ namespace`
`26`	`26`	`{`
`27`	`27`	`constexpr auto stackSize = 5000U;`
`28`	`28`	`constexpr auto eduProgramTransferThreadInterval = 5 * s;`
`29`		`-// FIXME: const value correct?`
`30`	`29`
`31`	`30`
`32`	`31`	`auto SendProgramsToEdu() -> void;`
Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,6 @@ namespace sts1cobcsw`
`41`	`41`	`{`
`42`	`42`	`namespace`
`43`	`43`	`{`
`44`		`-// FIXME: const value correct?`
`45`	`44`	`constexpr auto stackSize = 1200U;`
`46`	`45`	`constexpr auto telemetryThreadInterval = 30 * s;`
`47`	`46`	`// The delay until the first telemetry record is published and thereby the first beacon is sent.`