Merge pull request #33 from Spacecraft-Software/card-cardholder-field

feat(vault): card-cardholder read selector (+ TUI prefill)

Author: UnbreakableMJ

CHANGELOG.md

@@ -10,6 +10,12 @@ range may break in any release.
 
 ### Added
 
+- **`card-cardholder` field selector.** `vault get <card> --field card-cardholder`
+  now returns the cardholder name, and the TUI detail pane shows a `Holder` line
+  — which also lets the TUI card **edit** form prefill the cardholder (it
+  previously started blank, as there was no read selector). Closes the
+  card edit-prefill gap from the card-write / TUI-card slices.
+
 - **`mlock` the user keys (no swap exposure).** The agent's unwrapped user keys
   (`user_enc`/`user_mac`) are now wrapped in a `SealedKey` newtype that boxes the
   bytes for a stable address and `mlock`s their page(s) so they can't be paged to

README.md

@@ -99,7 +99,7 @@ Card (type 3) and identity (type 4) ciphers are readable from the CLI via
 `--field`:
 
 ```sh
-vault get visa --field card-number     # also: card-brand, card-expiry, card-code
+vault get visa --field card-number     # also: card-cardholder, card-brand, card-expiry, card-code
 vault get me   --field identity-email  # also: identity-name, identity-phone, identity-address
 ```
 

crates/vault-agent/src/state.rs

@@ -772,12 +772,14 @@ impl AgentState {
                 primary_uri: true,
                 ..DecryptOptions::default()
             },
-            Field::CardNumber | Field::CardBrand | Field::CardExpiry | Field::CardCode => {
-                DecryptOptions {
-                    card: true,
-                    ..DecryptOptions::default()
-                }
-            }
+            Field::CardCardholder
+            | Field::CardNumber
+            | Field::CardBrand
+            | Field::CardExpiry
+            | Field::CardCode => DecryptOptions {
+                card: true,
+                ..DecryptOptions::default()
+            },
             Field::IdentityName
             | Field::IdentityEmail
             | Field::IdentityPhone
@@ -803,6 +805,7 @@ impl AgentState {
             },
             Field::Notes => plain.notes.clone(),
             Field::Uri => plain.primary_uri.clone(),
+            Field::CardCardholder => plain.card.as_ref().and_then(|c| c.cardholder_name.clone()),
             Field::CardNumber => plain.card.as_ref().and_then(|c| c.number.clone()),
             Field::CardBrand => plain.card.as_ref().and_then(|c| c.brand.clone()),
             Field::CardCode => plain.card.as_ref().and_then(|c| c.code.clone()),

crates/vault-cli/src/main.rs

@@ -446,6 +446,7 @@ enum FieldArg {
     Totp,
     Notes,
     Uri,
+    CardCardholder,
     CardNumber,
     CardBrand,
     CardExpiry,
@@ -464,6 +465,7 @@ impl From<FieldArg> for Field {
             FieldArg::Totp => Self::Totp,
             FieldArg::Notes => Self::Notes,
             FieldArg::Uri => Self::Uri,
+            FieldArg::CardCardholder => Self::CardCardholder,
             FieldArg::CardNumber => Self::CardNumber,
             FieldArg::CardBrand => Self::CardBrand,
             FieldArg::CardExpiry => Self::CardExpiry,

crates/vault-ipc/src/proto.rs

@@ -533,6 +533,8 @@ pub enum Field {
     Notes,
     /// First `Login.Uris[].Uri`.
     Uri,
+    /// `Card.CardholderName`.
+    CardCardholder,
     /// `Card.Number`.
     CardNumber,
     /// `Card.Brand`.

crates/vault-tui/src/app.rs

@@ -682,9 +682,8 @@ impl FormState {
 
     /// An edit form for `entry`, prefilled with the metadata the list already
     /// carries (name / username / folder). For a card, `detail` (the pane's
-    /// on-select fetch) prefills `Brand`/`Expiry`. Secrets stay blank — blank
-    /// means "leave unchanged" on submit (so does the un-prefilled cardholder,
-    /// which has no fetch selector yet).
+    /// on-select fetch) prefills `Holder`/`Brand`/`Expiry`. Secrets stay blank —
+    /// blank means "leave unchanged" on submit.
     #[must_use]
     pub fn new_edit(entry: &ListEntry, detail: Option<&DetailView>) -> Self {
         let mut fields = Self::blank_fields();
@@ -705,6 +704,7 @@ impl FormState {
                 // pane's `Person`/`Address` are composites that can't be split
                 // back, so those rows start blank = leave-unchanged.
                 match (entry.cipher_type, label.as_str()) {
+                    (3, "Holder") => prefill(F_CARDHOLDER, value),
                     (3, "Brand") => prefill(F_BRAND, value),
                     (3, "Exp") => prefill(F_EXPIRY, value),
                     (4, "Email") => prefill(F_EMAIL, value),
@@ -2526,6 +2526,7 @@ mod tests {
         app.detail = Some(DetailView {
             id: "id-visa".to_owned(),
             lines: vec![
+                ("Holder".to_owned(), "A. Cardholder".to_owned()),
                 ("Brand".to_owned(), "Visa".to_owned()),
                 ("Exp".to_owned(), "04/2030".to_owned()),
             ],
@@ -2540,6 +2541,7 @@ mod tests {
                 .map(|r| r.value.to_owned())
                 .expect("row exists")
         };
+        assert_eq!(value_of("Holder"), "A. Cardholder");
         assert_eq!(value_of("Brand"), "Visa");
         assert_eq!(value_of("Expiry"), "04/2030");
         assert_eq!(value_of("Number"), "", "secrets are never prefilled");

crates/vault-tui/src/main.rs

@@ -762,7 +762,11 @@ async fn ensure_detail(state: &mut App, socket: &Path) {
         return; // already cached for this item
     }
     let specs: &[(&str, Field)] = match sel.cipher_type {
-        3 => &[("Brand", Field::CardBrand), ("Exp", Field::CardExpiry)],
+        3 => &[
+            ("Holder", Field::CardCardholder),
+            ("Brand", Field::CardBrand),
+            ("Exp", Field::CardExpiry),
+        ],
         4 => &[
             ("Person", Field::IdentityName),
             ("Email", Field::IdentityEmail),