feat(agent,core): organization-key support; tui: Space reveals from any pane (#47)

Two fixes from daily-driving Vault against a Bitwarden-cloud account whose
vault is almost entirely organization/Collection-owned.

Organization-key support (the bulk of the change):
- Vault decrypted only personal ciphers (and per-cipher keys under the user
  key); organization items — ~99% of a Collections-heavy vault — were skipped,
  their fields being encrypted under an org key Vault didn't hold. At unlock the
  agent now recovers the account RSA private key from `profile.privateKey`,
  RSA-OAEP-SHA1-unwraps each `profile.organizations[].key` into that org's
  symmetric key, and routes every cipher's decryption by `organization_id`
  (org key vs user key). Works online and from the offline cache. New
  `vault_core::org_key` module + `rsa` dependency (`ring` has no RSA
  decryption); justified RUSTSEC-2023-0071 ignore in deny.toml / CI. Items whose
  org key can't be unwrapped are still skipped; editing org items is refused for
  now (the write path would re-encrypt under the wrong key).

TUI Space-to-reveal:
- `Space` revealed a login's password from the item list but did nothing in the
  detail pane (logins have no per-field rows) or the folder pane. Target
  resolution moved into a testable `App::reveal_target`, so `Space` reveals from
  all three panes; cards/identities still reveal the cursor-selected masked
  field in the detail pane.

Tests: RSA round-trip, org-cipher decrypt + edit-refusal, reveal_target across
panes/types. Full `just ci` green; verified live (2274 items decrypt).

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: UnbreakableMJ

.github/workflows/ci.yml

@@ -111,7 +111,11 @@ jobs:
           # ratatui); revisit when ratatui's tree updates.
           #   RUSTSEC-2024-0436 — paste (unmaintained, build-time proc-macro)
           #   RUSTSEC-2026-0002 — lru 0.12.5 (unsound IterMut; transitive via ratatui)
-          ignore: RUSTSEC-2024-0436,RUSTSEC-2026-0002
+          # RUSTSEC-2023-0071 — rsa (Marvin timing sidechannel, no upstream fix).
+          # rsa unwraps organization keys (RSA-OAEP) once, locally, at unlock;
+          # the attack needs a network-observable decryption oracle, which Vault
+          # never exposes. Revisit if rsa ships a constant-time fix.
+          ignore: RUSTSEC-2024-0436,RUSTSEC-2026-0002,RUSTSEC-2023-0071
 
   deny:
     name: cargo-deny

CHANGELOG.md

@@ -33,6 +33,15 @@ range may break in any release.
 
 ### Fixed
 
+- **TUI `Space` reveals the password from every pane.** `Space` revealed a
+  login's password from the item list, but did nothing while the **detail** pane
+  was focused (logins have no per-field detail rows, so there was nothing to
+  reveal) and was inert in the **folder** pane. Reveal target resolution now
+  lives in a testable `App::reveal_target`: the detail pane reveals the
+  cursor-selected masked field for cards/identities and falls back to the item's
+  primary secret for logins/notes, and the list and folder panes both reveal the
+  selected item's primary secret — so `Space` works from all three panes.
+
 - **Login against current Bitwarden / Vaultwarden servers.** Once the master
   password was accepted, the server rejected the token request with
   `400 version_header_missing` — *"No client version header found, required to
@@ -67,6 +76,19 @@ range may break in any release.
 
 ### Added
 
+- **Organization / Collection items now decrypt (org-key support).** Vault
+  previously skipped every organization-owned cipher — the bulk of a vault that
+  uses Collections — because it held no key for them. At unlock the agent now
+  unwraps each organization's symmetric key from `/sync`
+  (`profile.organizations[].key`, an RSA-OAEP-SHA1 envelope opened with the
+  account key recovered from `profile.privateKey`) and routes each cipher's
+  decryption by `organization_id` (org key vs user key). Works online and from
+  the offline cache. New dependency `rsa` (RSA decryption — `ring` has none);
+  see the justified `RUSTSEC-2023-0071` ignore in `deny.toml` / CI. Items whose
+  org key can't be unwrapped are still skipped, and **editing** org items is
+  refused for now (the write path would re-encrypt under the wrong key) —
+  reads/copy work.
+
 - **`vault sync` progress spinner.** On a TTY, `vault sync` now animates a
   spinner while the agent pulls and decrypts `/sync`, then prints `✓ synced N
   items`. Suppressed under `--json` and when stderr is not a terminal, so

Cargo.lock

@@ -63,6 +63,12 @@ cipher = { version = "0.4", features = ["block-padding"] }
 hmac = "0.12"
 sha1 = "0.10"
 sha2 = "0.10"
+# RSA-2048-OAEP-SHA1 — unwraps organization keys (Bitwarden type-4 EncStrings).
+# `ring` has no RSA decryption, so this is the one non-ring asymmetric path.
+# Carries RUSTSEC-2023-0071 (Marvin timing sidechannel, no upstream fix); see the
+# justified `cargo audit` ignore in `justfile` / CI. Not reachable as a network
+# oracle here — org keys are unwrapped once, locally, at unlock.
+rsa = "0.9"
 pbkdf2 = { version = "0.12", default-features = false, features = ["hmac", "sha2"] }
 argon2 = { version = "0.5", default-features = false, features = ["alloc"] }
 hkdf = "0.12"