Skip to content

[BUG/FEATURE] Feature toggle to disable label sync #206

Open
@tehho

Description

@tehho

Note: Make sure to check out known issues (https://akv2k8s.io/troubleshooting/known-issues/) before submitting

Components and versions
Select which component(s) the bug relates to with [X].

[X] Controller, version: 1.2.3 (docker image tag)
[ ] Env-Injector (webhook), version: x.x.x (docker image tag)
[ ] Other

Describe the bug
A clear and concise description of what the bug is:
Would like to disable the autosync of labels since it overrides our labels we set.

To Reproduce
Steps to reproduce the behavior:
Have 2 azurekeyvaultsecrets pointing to the same secret but with different metadata.labels.name.
We noticed this when we got to add an annotation and added the secret to our repo and the annotations gets overriden by the azurekeyvaultsecret.

Expected behavior
A clear and concise description of what you expected to happen:
Not override existing labels, only append.
Maybe a feature flag in the controller to enable/disable this option.

Logs
If applicable, add logs to help explain your problem.
N/A

Additional context
Using ArgoCD so we autosync the change but the controller keep overriding.
Our use case is to have autoreload with stakater/Reloader and have this annotated on the secret object.
Great plugin to use together with azure keyvault, 10/10 would use again

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingenhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions