[FEATURE] Copying multiple secrets at once

[Frankkkkk]

Hi,
First of all thank you for this nice controller!

I wanted to use it to copy some kv secrets into k8s. In my case there are many secrets to copy (~30), so naturally it's a bit cumbersome to write 30 definitions.

I thought that we could maybe have a nicer way of representing many "syncs" from the same vault into the same secret.

Of course, as the semantics change, we'd need a new CRD.

For example, I'm thinking of something like this:

apiVersion: spv.no/v2beta1
kind: AzureKeyVaultMultipleSecrets
metadata:
  name: my-secrets
spec:
  vault:
    name: my-az-kv-vault
  output:
    secret:
      name: my-k8ssecret
  secrets:
  - secret1
  - secret2
  - secretn

What do you think ? If that looks somewhat okay for you, I'd be happy to make a PR !

Cheers,

[eyescreamxd]

Is it possible to enhance this feature and add possibility to extract all the keys from keyvault at once?

[tspearconquest]

Question: How would the multiple secrets/keys be stored in the environment in this use-case? It seems like you would have a single env var and then you would have to parse the one var in your app configuration to sort the secrets; that would require code changes in the app which might be fine for you but for a lot of folks/teams/orgs, it's not worth the effort.

I don't agree that it's cumbersome to create many AKVS resources tbh, unless you're deploying flat kubernetes manifests.

Assuming that you're not doing that and using helm templating instead; you can easily iterate a list in your values.yaml to create them all from a single template. If you're working with separate projects, then you can create a chart which only has the AKVS resources and define it as a subchart within each project's chart, so that each project only creates the AKVS resources it needs.