Obsidian Registration Entry: Additional Waitlist Issues

[bezalelBU]

Description

This issue is related to this existing issue: https://github.com/SparkDevNetwork/Rock/issues/6462

However, there are additional issues and behaviors that we would like to see addressed (and which are still present as of v17.4), so I am submitting it separately instead of appending it to the original.

There are several behavior variants that I see with regard to this issue. The first is that, in addition to allowing registrants to be waitlisted when waitlisting is not enabled, I believe that the the Obsidian block does not correctly calculate the remaining spots available until a registration instance hits its registrant maximum when determining whether or not a registrant should be waitlisted.

Conversely, while some scenarios allow two registrants to be waitlisted even when a registrant spot remains, the Obsidian Registration Entry block will always fail to prevent a registration from being submitted when a required fee is not present. In this case, both registrants are fully registered (not waitlisted) and the last one simply silently fails to receive it's selected fee.

Finally, it will also display a fee selection as empty (0) if there is still a single fee slot remaining.

Actual Behavior

Actual Behavior:

Scenario 1 - A Registration instance has one available fee and two registrant spaces left before hitting the maximum amount of registrants. When registering, multiple registration sessions are able to select the same fee. Each registration is then completed as a waitlist with no fee, even though the maximum registrant limit had not been hit and there is still a fee available, and even though waitlisting is not enabled.

Registrant 1 Result:

Registrant 2 Result:

Two Registrants Waitlisted With Two Spots Remaining And 1 Fee Available:

Scenario 2 - (Behavioral Variant?) There are multiple (>1) available registration spaces, but no fees remaining. The registrar is still able to access and complete the registration, even though the fee is required.
Normal Registrant with their Fee:

New Registrant is Allowed to register without a required fee (Additional Options field is just empty):

New Registrant Silently Added Without the Required Fee:

Additional (related?) Issues - If only one fee space is left, it is displayed to the registrar as (0) or empty. This is confusing/inaccurate and may dissuade the registrar from continuing.
Registration with 1 available fee:

Expected Behavior

Expected Behavior:

Scenario 1 - I would expect that the registration would allow one registrar to complete the registration normally with their applied fee while blocking the second from starting a session due to the lack of an available required fee.

Scenario 2 - I would expect the same behavior here: Allow one registrant to complete their registration and block the other from even starting theirs.

Additional Issue - I expect the registration entry form to accurately calculate the remaining fees.

Steps to Reproduce

SET UP

• Create a Registration Template with one Fee. Waitlist should be disabled.
• Add a field for email and phone number, if desired.
• Create a Registration Instance with a maximum allowed registrant field of 2.
• Add a test linkage

SCENARIO 1

• Go to a page with the Obsidian Registration Entry block and use the page route and linkage slug to pull up a registration form.
• Go through the form but stop just before submitting
• Use the same linkage in the URL to pull up the same page in incognito mode so that you have two open registrations at the same time
• Register a different person in incognito mode and go all the way through the registration
• see the Waitlist message
• Go back to the original registration and complete that as well.
• see the Waitlist message

SCENARIO 2

• Add one to the maximum allowed registrant field (3 total now)
• Add a registrant as normal, going all the way through the registration. This will use the single available fee.
• Add another registrant and observe the empty 'Additional Options' section
• View the Registrant list to confirm both registrations are added, and that the second has no fee.
• ADDITIONAL ISSUE
• In either previous scenario, observe the incorrectly calculating fees.

Issue Confirmation

• Perform a search on the Github Issues to see if your bug is already reported.
• Reproduced the problem on a fresh install or on the demo site.

Rock Version

v16.13, v17.4

Client Culture Setting

en-US