Skip to content

Commit d396981

Browse files
authored
UX-789 Replace Lerna with Changesets & NPM Workspaces (#1088)
* chore: uninstall lerna, temporarily remove all eslint deps * chore: Add workspaces to package * fix: CSS build * fix: builds * fix: resolve icons src types not dist * chore: update libby to latest * chore: update gh workflows * fix: downgrade to react 17 for enzyme * fix: temporary react-18 bridge * chore: Add linting, Revert react-18 bridge * chore: Remove unused packages * chore: Update libby * chore: remove stylelint, add changesets * docs: update readme * docs: update readme * chore: revert react 18 in next template * docs: update readme & pr template * build: add turbo * chore: hide vscode directories * docs: add changeset * build: update linting rules * chore: package-lock update * chore(deps): update libby with hmr fix
1 parent b5990ec commit d396981

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

58 files changed

+29663
-67098
lines changed

.changeset/README.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
# Changesets
2+
3+
Hello and welcome! This folder has been automatically generated by `@changesets/cli`, a build tool that works
4+
with multi-package repos, or single-package repos to help you version and publish your code. You can
5+
find the full documentation for it [in our repository](https://github.com/changesets/changesets)
6+
7+
We have a quick list of common questions to get you started engaging with this project in
8+
[our documentation](https://github.com/changesets/changesets/blob/main/docs/common-questions.md)

.changeset/config.json

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
{
2+
"$schema": "https://unpkg.com/@changesets/[email protected]/schema.json",
3+
"changelog": "@changesets/cli/changelog",
4+
"commit": false,
5+
"fixed": [],
6+
"linked": [],
7+
"access": "restricted",
8+
"baseBranch": "main",
9+
"updateInternalDependencies": "patch",
10+
"ignore": []
11+
}
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
'@sparkpost/matchbox': patch
3+
'@sparkpost/matchbox-icons': patch
4+
---
5+
6+
- Adds support for React 18
7+
- Updates a few util function types

.eslintignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,6 @@ packages/matchbox-icons/*
55
!packages/matchbox-icons/src
66

77
packages/next-template-matchbox/*
8+
9+
**/*.test.js
10+
**/dist/**

.eslintrc

Lines changed: 0 additions & 44 deletions
This file was deleted.

.eslintrc.json

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
{
2+
"env": {
3+
"browser": true,
4+
"es2021": true
5+
},
6+
"settings": {
7+
"react": {
8+
"version": "detect"
9+
}
10+
},
11+
"extends": [
12+
"plugin:@typescript-eslint/recommended",
13+
"plugin:react/recommended",
14+
"plugin:prettier/recommended"
15+
],
16+
"parser": "@typescript-eslint/parser",
17+
"parserOptions": {
18+
"ecmaFeatures": {
19+
"jsx": true
20+
},
21+
"ecmaVersion": "latest",
22+
"sourceType": "module"
23+
},
24+
"plugins": ["react", "@typescript-eslint", "prettier"],
25+
"rules": {
26+
"react/prop-types": 0,
27+
"@typescript-eslint/no-explicit-any": 0,
28+
"@typescript-eslint/no-unused-vars": ["error", { "ignoreRestSiblings": true }],
29+
"@typescript-eslint/ban-ts-comment": 0
30+
},
31+
"ignorePatterns": ["**/scripts/*", "**/design-tokens/*.js"]
32+
}

.github/pull_request_template.md

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,16 @@
1-
<!-- Give your PR a recognizable title. For example: "FE-123: Add new prop to component" or "Resolve Issue #123: Fix bug in component" -->
2-
<!-- Your PR title will be visible in changelogs -->
3-
41
### What Changed
52

6-
<!--
7-
What changes does this PR propose?
8-
Provide screenshots or [screen recordings](https://getkap.co/) for any visual changes.
9-
-->
3+
<!-- What changes does this PR propose? -->
104

11-
### How To Test or Verify
5+
### How To Verify
126

137
<!--
148
Describe any steps that may help reviewers verify changes.
159
Anything beyond basic unit testing, such as assistive tech usage, or special interactions.
1610
-->
1711

18-
### PR Checklist
12+
#### If your PR contains package changes:
1913

20-
- [ ] Add the correct `type` label
21-
- [ ] Pull request approval from #uxfe or #design-guild
14+
1. Create a changeset with `npx changeset`
15+
1. Ensure the changeset in the `.changeset` directory includes a descriptive summary
16+
1. Commit the changeset to your pull request

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313

1414
strategy:
1515
matrix:
16-
node-version: [14.x]
16+
node-version: [16.x]
1717

1818
steps:
1919
- uses: actions/checkout@v2

.github/workflows/e2e.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,16 +13,16 @@ jobs:
1313

1414
strategy:
1515
matrix:
16-
node-version: [14.x]
16+
node-version: [16.x]
1717

1818
steps:
1919
- uses: actions/checkout@v2
2020
- name: Use Node.js ${{ matrix.node-version }}
2121
uses: actions/setup-node@v1
2222
with:
2323
node-version: ${{ matrix.node-version }}
24-
- name: Install dependencies
25-
uses: bahmutov/npm-install@v1
24+
- name: Install
25+
run: npm ci
2626
- name: Prepare tests
2727
run: npm run pretest:ci
2828
- name: E2E tests

.github/workflows/libby.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313

1414
strategy:
1515
matrix:
16-
node-version: [14.x]
16+
node-version: [16.x]
1717

1818
steps:
1919
- uses: actions/checkout@v2

0 commit comments

Comments
 (0)