TASK-6411 IPv6 improvements, draft 5.1 changelog #794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for support-docs failed.
|
dkoerichbird
approved these changes
Jun 9, 2025
approved
deepakpn
approved these changes
Jun 9, 2025
deepakpn
reviewed
Jun 9, 2025
| --- | ||
|
|
||
| * [Momentum 5.0 Changelogs](/momentum/changelog/5/5-0) | ||
| * [Momentum 5.1 Changelogs](/momentum/changelog/5/5-1) |
Contributor
There was a problem hiding this comment.
could you please point me to where 5-1 changelog is?
juliebin
reviewed
Jun 9, 2025
| # Configure the RADIUS client | ||
| auth_radius { | ||
| NAS-IP-Address = 10.0.0.1 # the IP address of this SMTP server | ||
| NAS-IP-Address = fd01:345::1 # the IP address of this SMTP server |
Contributor
There was a problem hiding this comment.
Did we test with IPv6 address? If not, we shall keep the example in IPv4.
Contributor
Author
There was a problem hiding this comment.
I was asked to add IPv6 examples.
| server "two" { | ||
| host = "radius-2.example.com" | ||
| server "ipv6wport" { | ||
| host = "[2001:fd3::1]:2812" |
Contributor
There was a problem hiding this comment.
We can keep the example in IPv4.
| <dd> | ||
|
|
||
| The hostname or IP address of the RADIUS server. If a colon is present in the string then the left side of the string will be used as the hostname/IP address and the right hand side will be used as the port number on the server. If left unspecified, the RADIUS standard port number of 1812 will be used. | ||
| The hostname or IP address of the RADIUS server. The hostname/IP address can be followed by a colon and the port number on the server. If left unspecified, the RADIUS standard port number of 1812 will be used. An IPv6 address must be enclosed in brackets if a port was added. |
Contributor
There was a problem hiding this comment.
We can mention that since 5.1, IPv6 address can be used but must be enclosed in bracket if a port is specified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
How To Test or Verify
PR Checklist
Below are some checklists to follow for the correct procedure in different circumstance. The first list ("All PRs Checklist") should be followed for ALL PRs. The next 2 are additive to this list depending on what type of PR you are using.
For example: If you are submitting a content change to one of the support documents, your checklist would include the:
If you are submitting a feature addition, enhancement, or bug fix, your checklist would include the:
All PRs Checklist
team-FEorteam-SAZ)Content Changes Checklist
examples/article.mdin the root of the project directory and on the momentum doc's preface articleDevelopment Changes Checklist (some checks are automatic github actions and will not be listed here. ie. "all tests pass")
cypress/directory in the root of the project