TASK-10510: Fix deploy by netlify plugin #799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Doug Koerich <[email protected]>
✅ Deploy Preview for support-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Doug Koerich <[email protected]>
dkoerichbird
changed the title
Signed-off-by: Doug Koerich <[email protected]>
Signed-off-by: Doug Koerich <[email protected]>
dkoerichbird
changed the title
Signed-off-by: Doug Koerich <[email protected]>
Signed-off-by: Doug Koerich <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes the Node.js version across the project, bumps the package version, and removes a hardcoded API key from the docs.
- Bump package version to 0.2.0 and relax Node engine requirement to
^16 - Update Node version references in README and GitHub Actions
- Redact the hardcoded
auth_keyin the push HTTP request example
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Bumped version and updated "engines.node" to ^16 |
| content/momentum/3/3-push/push-http-request-eval.md | Replaced hardcoded auth_key with "REDACTED" |
| README.md | Changed documented Node version from 16.12.0 to 16.x |
| .github/workflows/index.yml | Updated actions/setup-node to use Node 16.x |
Comments suppressed due to low confidence (1)
README.md:156
- Add a space after the list hyphen for proper markdown syntax (e.g.
- 16.x) to match the project’s formatting style.
16.x
| local request = "{ \"registration_ids\": [ \"" .. reg_id .. "\" ], \"dry_run\": true, » | ||
| \"data\": { \"message\": \"Push message to send over GCM\" } }" | ||
| local auth_key = "AIzaSyA09R1jflwVV4T79OIuLtTxQyXKFlOVQfs" | ||
| local auth_key = "REDACTED" |
There was a problem hiding this comment.
Avoid hardcoding sensitive keys in examples; consider loading auth_key from an environment variable and documenting that approach to keep secrets out of source files.
Suggested change
| local auth_key = "REDACTED" | |
| local auth_key = os.getenv("AUTH_KEY") | |
| if not auth_key then | |
| error("Environment variable AUTH_KEY is not set. Please set it to your authorization key.") | |
| end |
deepakpn
approved these changes
Jul 10, 2025
approved
juliebin
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.