From 09b2c537d48b8c950a32dcb011a47a681b7ae252 Mon Sep 17 00:00:00 2001 From: Doug Koerich Date: Thu, 10 Jul 2025 09:55:32 -0300 Subject: [PATCH 1/6] TASK-10510: Bump of NodeJS version to 22.x Signed-off-by: Doug Koerich --- .github/workflows/cypress.yml | 6 +++--- .github/workflows/index.yml | 6 +++--- .github/workflows/labeller.yml | 4 ++-- .github/workflows/lighthouse.yml | 12 ++++++------ README.md | 2 +- package-lock.json | 6 +++--- package.json | 4 ++-- 7 files changed, 20 insertions(+), 20 deletions(-) diff --git a/.github/workflows/cypress.yml b/.github/workflows/cypress.yml index 7c9052c9d..17a4b9c32 100644 --- a/.github/workflows/cypress.yml +++ b/.github/workflows/cypress.yml @@ -14,13 +14,13 @@ jobs: strategy: matrix: - node-version: [16.x] + node-version: [22.x] steps: - name: Checkout repository - uses: actions/checkout@v2 + uses: actions/checkout@v4 - name: Cypress run - uses: cypress-io/github-action@v2 + uses: cypress-io/github-action@v6.8.0 with: build: npm run build start: npm start diff --git a/.github/workflows/index.yml b/.github/workflows/index.yml index 283fb0b59..a85714553 100644 --- a/.github/workflows/index.yml +++ b/.github/workflows/index.yml @@ -21,12 +21,12 @@ jobs: # Steps represent a sequence of tasks that will be executed as part of the job steps: # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 - name: Setup Node.js - uses: actions/setup-node@v2 + uses: actions/setup-node@v4 with: - node-version: '14' + node-version: '22' - name: Cache dependencies uses: actions/cache@v4 diff --git a/.github/workflows/labeller.yml b/.github/workflows/labeller.yml index b9d2f784d..a7c4c731c 100644 --- a/.github/workflows/labeller.yml +++ b/.github/workflows/labeller.yml @@ -9,7 +9,7 @@ jobs: steps: - uses: actions/setup-node@v4 with: - node-version: '16.x' - - uses: actions/labeler@v2 + node-version: '22.x' + - uses: actions/labeler@v5 with: repo-token: '${{ secrets.GITHUB_TOKEN }}' diff --git a/.github/workflows/lighthouse.yml b/.github/workflows/lighthouse.yml index 7d7de0488..2a8cb1ce8 100644 --- a/.github/workflows/lighthouse.yml +++ b/.github/workflows/lighthouse.yml @@ -12,10 +12,10 @@ jobs: strategy: matrix: - node-version: [16.x] + node-version: [22.x] steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 - uses: actions/cache@v4 with: path: ~/.npm @@ -23,25 +23,25 @@ jobs: restore-keys: | ${{ runner.os }}-node- - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v2 + uses: actions/setup-node@v4 with: node-version: ${{ matrix.node-version }} - name: Install dependencies - uses: bahmutov/npm-install@v1 + uses: bahmutov/npm-install@v1.10.0 - name: Run build env: CANCEL_SENTRY_CLI: true CYPRESS_SAMPLE_SIZE: 10 run: npm run build - name: Wait for the Netlify Preview - uses: jakepartusch/wait-for-netlify-action@v1 + uses: jakepartusch/wait-for-netlify-action@v1.4 id: netlify with: site_name: 'support-docs' # Unfortunately our build time is ~20min, so I'm setting the timeout to 22min. max_timeout: 1320 - name: Audit URLs using Lighthouse - uses: treosh/lighthouse-ci-action@v8 + uses: treosh/lighthouse-ci-action@v12 with: urls: | ${{ steps.netlify.outputs.url }} diff --git a/README.md b/README.md index b933ab996..0ee5b2d85 100644 --- a/README.md +++ b/README.md @@ -153,7 +153,7 @@ _**This is not a required step in contributing to the documentation**_ ### Node Version -16.12.0 +22.16.x ### Installation diff --git a/package-lock.json b/package-lock.json index 0a16abbd2..a8cafccfe 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,7 +1,7 @@ { "name": "support-docs", - "version": "0.1.0", - "lockfileVersion": 2, + "version": "0.2.0", + "lockfileVersion": 3, "requires": true, "packages": { "": { @@ -75,7 +75,7 @@ "yaml-loader": "^0.6.0" }, "engines": { - "node": "=16.12.0" + "node": "^22.16.0" } }, "node_modules/@algolia/cache-browser-local-storage": { diff --git a/package.json b/package.json index 6e90d3495..7b911d0b7 100644 --- a/package.json +++ b/package.json @@ -1,9 +1,9 @@ { "name": "support-docs", - "version": "0.1.0", + "version": "0.2.0", "private": true, "engines": { - "node": "=16.12.0" + "node": "^22.16.0" }, "scripts": { "predev": "npm run build:images", From 344ed0fcdf2d24f45286346ae29fe9b1655fdfb6 Mon Sep 17 00:00:00 2001 From: Doug Koerich Date: Thu, 10 Jul 2025 10:10:21 -0300 Subject: [PATCH 2/6] TASK-10510: Setting NodeJS version Signed-off-by: Doug Koerich --- .github/labeler.yml | 6 ++++-- .github/workflows/cypress.yml | 2 +- .github/workflows/index.yml | 2 +- .github/workflows/labeller.yml | 2 +- .github/workflows/lighthouse.yml | 2 +- README.md | 2 +- package-lock.json | 2 +- package.json | 2 +- 8 files changed, 11 insertions(+), 9 deletions(-) diff --git a/.github/labeler.yml b/.github/labeler.yml index 68fa97a25..1aa570876 100644 --- a/.github/labeler.yml +++ b/.github/labeler.yml @@ -1,5 +1,7 @@ ':eyes: needs review': - - '**/*' + - changed-files: + - '**/*' 'type: content change': - - 'content/**/*' + - changed-files: + - 'content/**/*' diff --git a/.github/workflows/cypress.yml b/.github/workflows/cypress.yml index 17a4b9c32..ad3836aed 100644 --- a/.github/workflows/cypress.yml +++ b/.github/workflows/cypress.yml @@ -14,7 +14,7 @@ jobs: strategy: matrix: - node-version: [22.x] + node-version: [18.14.x] steps: - name: Checkout repository diff --git a/.github/workflows/index.yml b/.github/workflows/index.yml index a85714553..5f53d9fe2 100644 --- a/.github/workflows/index.yml +++ b/.github/workflows/index.yml @@ -26,7 +26,7 @@ jobs: - name: Setup Node.js uses: actions/setup-node@v4 with: - node-version: '22' + node-version: '18.14.x' - name: Cache dependencies uses: actions/cache@v4 diff --git a/.github/workflows/labeller.yml b/.github/workflows/labeller.yml index a7c4c731c..1027222f0 100644 --- a/.github/workflows/labeller.yml +++ b/.github/workflows/labeller.yml @@ -9,7 +9,7 @@ jobs: steps: - uses: actions/setup-node@v4 with: - node-version: '22.x' + node-version: '18.14.x' - uses: actions/labeler@v5 with: repo-token: '${{ secrets.GITHUB_TOKEN }}' diff --git a/.github/workflows/lighthouse.yml b/.github/workflows/lighthouse.yml index 2a8cb1ce8..9866d0f28 100644 --- a/.github/workflows/lighthouse.yml +++ b/.github/workflows/lighthouse.yml @@ -12,7 +12,7 @@ jobs: strategy: matrix: - node-version: [22.x] + node-version: [18.14.x] steps: - uses: actions/checkout@v4 diff --git a/README.md b/README.md index 0ee5b2d85..90ed85767 100644 --- a/README.md +++ b/README.md @@ -153,7 +153,7 @@ _**This is not a required step in contributing to the documentation**_ ### Node Version -22.16.x +18.14.x ### Installation diff --git a/package-lock.json b/package-lock.json index a8cafccfe..b0e1667a1 100644 --- a/package-lock.json +++ b/package-lock.json @@ -75,7 +75,7 @@ "yaml-loader": "^0.6.0" }, "engines": { - "node": "^22.16.0" + "node": "=18.14" } }, "node_modules/@algolia/cache-browser-local-storage": { diff --git a/package.json b/package.json index 7b911d0b7..5cea112e8 100644 --- a/package.json +++ b/package.json @@ -3,7 +3,7 @@ "version": "0.2.0", "private": true, "engines": { - "node": "^22.16.0" + "node": "=18.14" }, "scripts": { "predev": "npm run build:images", From e75d52754518af0e69213dd540da5de28a97a340 Mon Sep 17 00:00:00 2001 From: Doug Koerich Date: Thu, 10 Jul 2025 10:30:02 -0300 Subject: [PATCH 3/6] TASK-10510: Trying to set:x NodeJS version to minimum Signed-off-by: Doug Koerich --- .github/workflows/cypress.yml | 2 +- .github/workflows/index.yml | 2 +- .github/workflows/labeller.yml | 2 +- .github/workflows/lighthouse.yml | 2 +- README.md | 2 +- package-lock.json | 2 +- package.json | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/cypress.yml b/.github/workflows/cypress.yml index ad3836aed..9cf67a005 100644 --- a/.github/workflows/cypress.yml +++ b/.github/workflows/cypress.yml @@ -14,7 +14,7 @@ jobs: strategy: matrix: - node-version: [18.14.x] + node-version: [16.x] steps: - name: Checkout repository diff --git a/.github/workflows/index.yml b/.github/workflows/index.yml index 5f53d9fe2..77378f226 100644 --- a/.github/workflows/index.yml +++ b/.github/workflows/index.yml @@ -26,7 +26,7 @@ jobs: - name: Setup Node.js uses: actions/setup-node@v4 with: - node-version: '18.14.x' + node-version: '16.x' - name: Cache dependencies uses: actions/cache@v4 diff --git a/.github/workflows/labeller.yml b/.github/workflows/labeller.yml index 1027222f0..7e5b5d7ea 100644 --- a/.github/workflows/labeller.yml +++ b/.github/workflows/labeller.yml @@ -9,7 +9,7 @@ jobs: steps: - uses: actions/setup-node@v4 with: - node-version: '18.14.x' + node-version: '16.x' - uses: actions/labeler@v5 with: repo-token: '${{ secrets.GITHUB_TOKEN }}' diff --git a/.github/workflows/lighthouse.yml b/.github/workflows/lighthouse.yml index 9866d0f28..44ef3a041 100644 --- a/.github/workflows/lighthouse.yml +++ b/.github/workflows/lighthouse.yml @@ -12,7 +12,7 @@ jobs: strategy: matrix: - node-version: [18.14.x] + node-version: [16.x] steps: - uses: actions/checkout@v4 diff --git a/README.md b/README.md index 90ed85767..b091d6707 100644 --- a/README.md +++ b/README.md @@ -153,7 +153,7 @@ _**This is not a required step in contributing to the documentation**_ ### Node Version -18.14.x +>=16 ### Installation diff --git a/package-lock.json b/package-lock.json index b0e1667a1..f5565b486 100644 --- a/package-lock.json +++ b/package-lock.json @@ -75,7 +75,7 @@ "yaml-loader": "^0.6.0" }, "engines": { - "node": "=18.14" + "node": "^16" } }, "node_modules/@algolia/cache-browser-local-storage": { diff --git a/package.json b/package.json index 5cea112e8..02dedc3e2 100644 --- a/package.json +++ b/package.json @@ -3,7 +3,7 @@ "version": "0.2.0", "private": true, "engines": { - "node": "=18.14" + "node": "^16" }, "scripts": { "predev": "npm run build:images", From 6f58a9fb7e9d3b3eb5f938f1df93e7544a7a5bb2 Mon Sep 17 00:00:00 2001 From: Doug Koerich Date: Thu, 10 Jul 2025 10:37:34 -0300 Subject: [PATCH 4/6] TASK-10510: Removing a key value from documentation Signed-off-by: Doug Koerich --- content/momentum/3/3-push/push-http-request-eval.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/content/momentum/3/3-push/push-http-request-eval.md b/content/momentum/3/3-push/push-http-request-eval.md index 53783b18f..d921cd53c 100644 --- a/content/momentum/3/3-push/push-http-request-eval.md +++ b/content/momentum/3/3-push/push-http-request-eval.md @@ -32,7 +32,7 @@ function mod:http_request_eval(sess) DzyjAI8maYIogujSPtq-jSUG0WybCQ0mT1eGOZsgy0" local request = "{ \"registration_ids\": [ \"" .. reg_id .. "\" ], \"dry_run\": true, » \"data\": { \"message\": \"Push message to send over GCM\" } }" - local auth_key = "AIzaSyA09R1jflwVV4T79OIuLtTxQyXKFlOVQfs" + local auth_key = "REDACTED" -- print new json request to paniclog.ec for ref print ("new json request = ", request) @@ -69,4 +69,4 @@ You must use require `("msys.httpclnt")` to enable this hook point and to access After changing HTTP session data, be sure to use the `sess:request_finalize` function. -The [ob_get_current_message](/momentum/3/3-reference/3-reference-lua-ref-msys-delivery-ob-get-current-message) function uses this parameter to return a message. See also [Lua Functions](/momentum/3/3-reference/3-reference-lua-summary-table) for more information about the functions used in [“http_response_eval example”](/momentum/3/3-push/push-http-response-eval#push.http_response_eval.example). \ No newline at end of file +The [ob_get_current_message](/momentum/3/3-reference/3-reference-lua-ref-msys-delivery-ob-get-current-message) function uses this parameter to return a message. See also [Lua Functions](/momentum/3/3-reference/3-reference-lua-summary-table) for more information about the functions used in [“http_response_eval example”](/momentum/3/3-push/push-http-response-eval#push.http_response_eval.example). From 3a5e6859461e0aaeec4ca8cd4749f1a1f7ea04bb Mon Sep 17 00:00:00 2001 From: Doug Koerich Date: Thu, 10 Jul 2025 10:54:53 -0300 Subject: [PATCH 5/6] TASK-10510: Fixing labeler.yml workflow Signed-off-by: Doug Koerich --- .github/labeler.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/labeler.yml b/.github/labeler.yml index 1aa570876..fc999ab58 100644 --- a/.github/labeler.yml +++ b/.github/labeler.yml @@ -1,7 +1,7 @@ ':eyes: needs review': - changed-files: - - '**/*' + - needs-review: '**/*' 'type: content change': - changed-files: - - 'content/**/*' + - content-change: 'content/**/*' From 5b1a065c898495fadc055eba35dd6e3d6c4fab55 Mon Sep 17 00:00:00 2001 From: Doug Koerich Date: Thu, 10 Jul 2025 10:58:40 -0300 Subject: [PATCH 6/6] TASK-10510: Limited to the actual fix Signed-off-by: Doug Koerich --- .github/labeler.yml | 6 ++---- .github/workflows/cypress.yml | 4 ++-- .github/workflows/index.yml | 4 ++-- .github/workflows/labeller.yml | 2 +- .github/workflows/lighthouse.yml | 10 +++++----- README.md | 2 +- 6 files changed, 13 insertions(+), 15 deletions(-) diff --git a/.github/labeler.yml b/.github/labeler.yml index fc999ab58..68fa97a25 100644 --- a/.github/labeler.yml +++ b/.github/labeler.yml @@ -1,7 +1,5 @@ ':eyes: needs review': - - changed-files: - - needs-review: '**/*' + - '**/*' 'type: content change': - - changed-files: - - content-change: 'content/**/*' + - 'content/**/*' diff --git a/.github/workflows/cypress.yml b/.github/workflows/cypress.yml index 9cf67a005..7c9052c9d 100644 --- a/.github/workflows/cypress.yml +++ b/.github/workflows/cypress.yml @@ -18,9 +18,9 @@ jobs: steps: - name: Checkout repository - uses: actions/checkout@v4 + uses: actions/checkout@v2 - name: Cypress run - uses: cypress-io/github-action@v6.8.0 + uses: cypress-io/github-action@v2 with: build: npm run build start: npm start diff --git a/.github/workflows/index.yml b/.github/workflows/index.yml index 77378f226..6f59a9e60 100644 --- a/.github/workflows/index.yml +++ b/.github/workflows/index.yml @@ -21,10 +21,10 @@ jobs: # Steps represent a sequence of tasks that will be executed as part of the job steps: # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it - - uses: actions/checkout@v4 + - uses: actions/checkout@v2 - name: Setup Node.js - uses: actions/setup-node@v4 + uses: actions/setup-node@v2 with: node-version: '16.x' diff --git a/.github/workflows/labeller.yml b/.github/workflows/labeller.yml index 7e5b5d7ea..b9d2f784d 100644 --- a/.github/workflows/labeller.yml +++ b/.github/workflows/labeller.yml @@ -10,6 +10,6 @@ jobs: - uses: actions/setup-node@v4 with: node-version: '16.x' - - uses: actions/labeler@v5 + - uses: actions/labeler@v2 with: repo-token: '${{ secrets.GITHUB_TOKEN }}' diff --git a/.github/workflows/lighthouse.yml b/.github/workflows/lighthouse.yml index 44ef3a041..7d7de0488 100644 --- a/.github/workflows/lighthouse.yml +++ b/.github/workflows/lighthouse.yml @@ -15,7 +15,7 @@ jobs: node-version: [16.x] steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v2 - uses: actions/cache@v4 with: path: ~/.npm @@ -23,25 +23,25 @@ jobs: restore-keys: | ${{ runner.os }}-node- - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v4 + uses: actions/setup-node@v2 with: node-version: ${{ matrix.node-version }} - name: Install dependencies - uses: bahmutov/npm-install@v1.10.0 + uses: bahmutov/npm-install@v1 - name: Run build env: CANCEL_SENTRY_CLI: true CYPRESS_SAMPLE_SIZE: 10 run: npm run build - name: Wait for the Netlify Preview - uses: jakepartusch/wait-for-netlify-action@v1.4 + uses: jakepartusch/wait-for-netlify-action@v1 id: netlify with: site_name: 'support-docs' # Unfortunately our build time is ~20min, so I'm setting the timeout to 22min. max_timeout: 1320 - name: Audit URLs using Lighthouse - uses: treosh/lighthouse-ci-action@v12 + uses: treosh/lighthouse-ci-action@v8 with: urls: | ${{ steps.netlify.outputs.url }} diff --git a/README.md b/README.md index b091d6707..db91074ee 100644 --- a/README.md +++ b/README.md @@ -153,7 +153,7 @@ _**This is not a required step in contributing to the documentation**_ ### Node Version ->=16 +16.x ### Installation