Skip to content

TASK-10510: Fix deploy by netlify plugin #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dkoerichbird merged 6 commits into from
Jul 10, 2025
Merged

TASK-10510: Fix deploy by netlify plugin #799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
09b2c53
TASK-10510: Bump of NodeJS version to 22.x
dkoerichbird Jul 10, 2025
344ed0f
TASK-10510: Setting NodeJS version
dkoerichbird Jul 10, 2025
e75d527
TASK-10510: Trying to set:x NodeJS version to minimum
dkoerichbird Jul 10, 2025
6f58a9f
TASK-10510: Removing a key value from documentation
dkoerichbird Jul 10, 2025
3a5e685
TASK-10510: Fixing labeler.yml workflow
dkoerichbird Jul 10, 2025
5b1a065
TASK-10510: Limited to the actual fix
dkoerichbird Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/index.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v2
with:
node-version: '14'
node-version: '16.x'

- name: Cache dependencies
uses: actions/cache@v4
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ _**This is not a required step in contributing to the documentation**_

### Node Version

16.12.0
16.x

### Installation

Expand Down
4 changes: 2 additions & 2 deletions content/momentum/3/3-push/push-http-request-eval.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ function mod:http_request_eval(sess)
DzyjAI8maYIogujSPtq-jSUG0WybCQ0mT1eGOZsgy0"
local request = "{ \"registration_ids\": [ \"" .. reg_id .. "\" ], \"dry_run\": true, »
\"data\": { \"message\": \"Push message to send over GCM\" } }"
local auth_key = "AIzaSyA09R1jflwVV4T79OIuLtTxQyXKFlOVQfs"
local auth_key = "REDACTED"
Copy link

Copilot AI Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid hardcoding sensitive keys in examples; consider loading auth_key from an environment variable and documenting that approach to keep secrets out of source files.

Suggested change
local auth_key = "REDACTED"
local auth_key = os.getenv("AUTH_KEY")
if not auth_key then
error("Environment variable AUTH_KEY is not set. Please set it to your authorization key.")
end

Copilot uses AI. Check for mistakes.

-- print new json request to paniclog.ec for ref
print ("new json request = ", request)
Expand Down Expand Up @@ -69,4 +69,4 @@ You must use require `("msys.httpclnt")` to enable this hook point and to access

After changing HTTP session data, be sure to use the `sess:request_finalize` function.

The [ob_get_current_message](/momentum/3/3-reference/3-reference-lua-ref-msys-delivery-ob-get-current-message) function uses this parameter to return a message. See also [Lua Functions](/momentum/3/3-reference/3-reference-lua-summary-table) for more information about the functions used in [“http_response_eval example”](/momentum/3/3-push/push-http-response-eval#push.http_response_eval.example).
The [ob_get_current_message](/momentum/3/3-reference/3-reference-lua-ref-msys-delivery-ob-get-current-message) function uses this parameter to return a message. See also [Lua Functions](/momentum/3/3-reference/3-reference-lua-summary-table) for more information about the functions used in [“http_response_eval example”](/momentum/3/3-push/push-http-response-eval#push.http_response_eval.example).
6 changes: 3 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{
"name": "support-docs",
"version": "0.1.0",
"version": "0.2.0",
"private": true,
"engines": {
"node": "=16.12.0"
"node": "^16"
},
"scripts": {
"predev": "npm run build:images",
Expand Down
Loading