Pro:
- The drive might "compress" the pattern that is written to it. So combining with cryptsetup ensures that the drive actually stored every single bit correctly and did not just compress it.
- As preparation to encrypt the drive, it is recommended to overwrite with cryptographically secure random numbers before which will be done while testing the drive. Win-win.
Contra:
- A bit higher CPU usage. But with AES-NI, this should be acceptable.
I have been doing this for years without issues btw, ref: https://github.com/ypid/scripts/blob/master/badblocks_and_secure_erase and https://github.com/ypid/scripts/blob/master/full_disk_test
Pro:
Contra:
I have been doing this for years without issues btw, ref: https://github.com/ypid/scripts/blob/master/badblocks_and_secure_erase and https://github.com/ypid/scripts/blob/master/full_disk_test