Always check for deprecated config keys

Author: Nustat0

src/parameter.cpp

@@ -29,6 +29,8 @@ SK_LazyGlobal <sk::ParameterFactory> g_ParameterFactory;
 bool
 sk::iParameter::load (void)
 {
+  bool bRet = false;
+
   const iSK_INISection* section =
     ( ini == nullptr ) ? nullptr
                        : ini->contains_section (ini_section);
@@ -43,12 +45,15 @@ sk::iParameter::load (void)
     {
       set_value_str (*key);
 
-      return true;
+      bRet = true;
     }
 
     static const std::unordered_map <std::wstring, std::unordered_map <std::wstring, std::wstring>> ini_keys_old =
     {
-      { L"Render.FrameRate", { { L"BufferCount", L"BackBufferCount" } } }
+      { L"Render.FrameRate", {
+          { L"BufferCount", L"BackBufferCount" }
+        }
+      }
     };
 
     if (ini_keys_old.contains (ini_section) && ini_keys_old.at (ini_section).contains (ini_key))
@@ -61,16 +66,17 @@ sk::iParameter::load (void)
       if (   key_old != nullptr &&
           (! key_old->empty ()) )
       {
-        set_value_str (*key_old);
+        if (! std::exchange (bRet, true))
+        {
+          set_value_str (*key_old);
+        }
 
         ini->get_section (ini_section).remove_key (ini_key_old);
-
-        return true;
       }
     }
   }
 
-  return false;
+  return bRet;
 }
 
 bool