chore: CmdImpl only open panicChan if its going to get used

Author: benwaples

cmd/list-container-registries.go

@@ -45,7 +45,7 @@ var listContainerRegistriesCmd = &cobra.Command{
 
 func listContainerRegistriesCmdImpl(cmd *cobra.Command, args []string) {
 	ctx, stop := signal.NotifyContext(cmd.Context(), os.Interrupt, os.Kill)
-	panicChan := panicChan()
+
 	defer gracefulShutdown(stop)
 
 	log.V(1).Info("testing connections")
@@ -56,13 +56,14 @@ func listContainerRegistriesCmdImpl(cmd *cobra.Command, args []string) {
 	} else {
 		log.Info("collecting azure container registries...")
 		start := time.Now()
+		panicChan := panicChan()
 		stream := listContainerRegistries(ctx, azClient, panicChan, listSubscriptions(ctx, azClient, panicChan))
+		handleBubbledPanic(ctx, panicChan, stop)
 		outputStream(ctx, stream)
 		duration := time.Since(start)
 		log.Info("collection completed", "duration", duration.String())
 	}
 
-	handleBubbledPanic(ctx, panicChan, stop)
 }
 
 func listContainerRegistries(ctx context.Context, client client.AzureClient, panicChan chan error, subscriptions <-chan interface{}) <-chan interface{} {

cmd/list-logic-apps.go

@@ -45,7 +45,7 @@ var listLogicAppsCmd = &cobra.Command{
 
 func listLogicAppsCmdImpl(cmd *cobra.Command, args []string) {
 	ctx, stop := signal.NotifyContext(cmd.Context(), os.Interrupt, os.Kill)
-	panicChan := panicChan()
+
 	defer gracefulShutdown(stop)
 
 	log.V(1).Info("testing connections")
@@ -56,13 +56,14 @@ func listLogicAppsCmdImpl(cmd *cobra.Command, args []string) {
 	} else {
 		log.Info("collecting azure logic apps...")
 		start := time.Now()
+		panicChan := panicChan()
 		stream := listLogicApps(ctx, azClient, panicChan, listSubscriptions(ctx, azClient, panicChan))
+		handleBubbledPanic(ctx, panicChan, stop)
 		outputStream(ctx, stream)
 		duration := time.Since(start)
 		log.Info("collection completed", "duration", duration.String())
 	}
 
-	handleBubbledPanic(ctx, panicChan, stop)
 }
 
 func listLogicApps(ctx context.Context, client client.AzureClient, panicChan chan error, subscriptions <-chan interface{}) <-chan interface{} {

cmd/list-managed-clusters.go

@@ -45,7 +45,6 @@ var listManagedClustersCmd = &cobra.Command{
 
 func listManagedClustersCmdImpl(cmd *cobra.Command, args []string) {
 	ctx, stop := signal.NotifyContext(cmd.Context(), os.Interrupt, os.Kill)
-	panicChan := panicChan()
 	defer gracefulShutdown(stop)
 
 	log.V(1).Info("testing connections")
@@ -56,13 +55,14 @@ func listManagedClustersCmdImpl(cmd *cobra.Command, args []string) {
 	} else {
 		log.Info("collecting azure managed clusters...")
 		start := time.Now()
+		panicChan := panicChan()
 		stream := listManagedClusters(ctx, azClient, panicChan, listSubscriptions(ctx, azClient, panicChan))
+		handleBubbledPanic(ctx, panicChan, stop)
 		outputStream(ctx, stream)
 		duration := time.Since(start)
 		log.Info("collection completed", "duration", duration.String())
 	}
 
-	handleBubbledPanic(ctx, panicChan, stop)
 }
 
 func listManagedClusters(ctx context.Context, client client.AzureClient, panicChan chan error, subscriptions <-chan interface{}) <-chan interface{} {

cmd/list-vm-scale-sets.go

@@ -45,7 +45,6 @@ var listVMScaleSetsCmd = &cobra.Command{
 
 func listVMScaleSetsCmdImpl(cmd *cobra.Command, args []string) {
 	ctx, stop := signal.NotifyContext(cmd.Context(), os.Interrupt, os.Kill)
-	panicChan := panicChan()
 	defer gracefulShutdown(stop)
 
 	log.V(1).Info("testing connections")
@@ -56,13 +55,14 @@ func listVMScaleSetsCmdImpl(cmd *cobra.Command, args []string) {
 	} else {
 		log.Info("collecting azure virtual machine scale sets...")
 		start := time.Now()
+		panicChan := panicChan()
 		stream := listVMScaleSets(ctx, azClient, panicChan, listSubscriptions(ctx, azClient, panicChan))
+		handleBubbledPanic(ctx, panicChan, stop)
 		outputStream(ctx, stream)
 		duration := time.Since(start)
 		log.Info("collection completed", "duration", duration.String())
 	}
 
-	handleBubbledPanic(ctx, panicChan, stop)
 }
 
 func listVMScaleSets(ctx context.Context, client client.AzureClient, panicChan chan error, subscriptions <-chan interface{}) <-chan interface{} {