Skip to content

Commit 1428636

Browse files
authored
Use ubuntu-latest in GitHub Actions (#73)
Prior to this commit we had harcoded the Ubuntu version in our GitHub Actions to 20.04, with a GitHub Issue being automatically generated every year to update to the latest version. GitHub Actions only updates every 2 years, it turns out, not ever year, as they only upgrade to LTS versions. GitHub Actions don't support a Cron scheduler in the format that's needed for every 2 years, so have decided to be pragmatic and just use ubuntu-latest.
1 parent 41cc90a commit 1428636

9 files changed

+18
-49
lines changed

.github/DEPENDENCIES.md

-5
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,3 @@ We have [pinned the linux dependencies in the devcontainer Dockerfile](https://g
5757
2. Execute the Dockerfile (e.g. if it's a remote container Dockerfile build the remote container)
5858
3. Run `apt-cache policy <package>` for each package, to see the version installed
5959
4. Pin all the versions, replacing any old versions with new ones
60-
61-
62-
## Ubuntu version
63-
64-
[Ubuntu releases annually in April](https://wiki.ubuntu.com/Releases). In 2020 the GitHub Actions team [supported the new version by mid June](https://github.com/actions/virtual-environments/issues/228#issuecomment-644065532), so we have [an issue automatically created on for 15th July each year](https://github.com/agilepathway/hoverfly-github-action/pull/55) to prompt us to update.

.github/workflows/check-commit-message.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515
check-commit-message-style:
1616
if: (github.actor!= 'dependabot[bot]') && (contains(github.head_ref, 'dependabot/github_actions/') == false)
1717
name: Check commit message style
18-
runs-on: ubuntu-20.04
18+
runs-on: ubuntu-latest
1919
steps:
2020
- name: Check
2121
uses: mristin/[email protected]

.github/workflows/check_semver_labels.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313

1414
check_semver_label:
1515
name: Check for semantic version label
16-
runs-on: ubuntu-20.04
16+
runs-on: ubuntu-latest
1717
steps:
1818
- uses: docker://agilepathway/pull-request-label-checker:v1.0.9
1919
with:

.github/workflows/dependabot_hack.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010

1111
dependabot_hack:
1212
name: Ensure dependabot version checks
13-
runs-on: ubuntu-20.04
13+
runs-on: ubuntu-latest
1414
steps:
1515

1616
# update the version manually in these places, too:

.github/workflows/github_tag_and_release.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010

1111
tag:
1212
name: Tag semantic version
13-
runs-on: ubuntu-20.04
13+
runs-on: ubuntu-latest
1414
steps:
1515
- name: Tag
1616
uses: K-Phoen/[email protected]
@@ -23,7 +23,7 @@ jobs:
2323
release:
2424
needs: tag
2525
name: Create GitHub Release
26-
runs-on: ubuntu-20.04
26+
runs-on: ubuntu-latest
2727
steps:
2828
-
2929
name: Checkout

.github/workflows/reviewdog.yml

+5-5
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ jobs:
77

88
hadolint:
99
name: runner / hadolint
10-
runs-on: ubuntu-20.04
10+
runs-on: ubuntu-latest
1111
steps:
1212
- name: Check out code
1313
uses: actions/[email protected]
@@ -19,7 +19,7 @@ jobs:
1919

2020
yamllint:
2121
name: runner / yamllint
22-
runs-on: ubuntu-20.04
22+
runs-on: ubuntu-latest
2323
steps:
2424
- uses: actions/[email protected]
2525
- name: yamllint
@@ -30,7 +30,7 @@ jobs:
3030

3131
shellcheck:
3232
name: runner / shellcheck
33-
runs-on: ubuntu-20.04
33+
runs-on: ubuntu-latest
3434
steps:
3535
- uses: actions/[email protected]
3636
- name: shellcheck
@@ -44,7 +44,7 @@ jobs:
4444

4545
misspell:
4646
name: runner / misspell
47-
runs-on: ubuntu-20.04
47+
runs-on: ubuntu-latest
4848
steps:
4949
- uses: actions/[email protected]
5050
- uses: reviewdog/[email protected]
@@ -54,7 +54,7 @@ jobs:
5454

5555
languagetool:
5656
name: runner / languagetool
57-
runs-on: ubuntu-20.04
57+
runs-on: ubuntu-latest
5858
steps:
5959
- uses: actions/[email protected]
6060
- uses: reviewdog/[email protected]

.github/workflows/schedule_dockerfile_dependency_updates_issue.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ on: # yamllint disable-line rule:truthy
88
jobs:
99
create_issue:
1010
name: Create issue to update Dockerfile dependencies
11-
runs-on: ubuntu-20.04
11+
runs-on: ubuntu-latest
1212
steps:
1313

1414
# Repo code checkout required if `template` is used

.github/workflows/schedule_ubuntu_annual_update_issue.yml

-26
This file was deleted.

.github/workflows/test.yml

+7-7
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717

1818
install_latest_version_by_default:
1919
name: Install latest version by default
20-
runs-on: ubuntu-20.04
20+
runs-on: ubuntu-latest
2121
steps:
2222
- uses: actions/[email protected]
2323
- name: Install Hoverfly
@@ -34,7 +34,7 @@ jobs:
3434
3535
install_specific_version:
3636
name: Install specific version
37-
runs-on: ubuntu-20.04
37+
runs-on: ubuntu-latest
3838
env:
3939
HOVERFLY_VERSION: v1.2.0
4040
steps:
@@ -52,7 +52,7 @@ jobs:
5252
5353
install_fails_if_version_does_not_begin_with_v:
5454
name: Install fails if version does not begin with v
55-
runs-on: ubuntu-20.04
55+
runs-on: ubuntu-latest
5656
env:
5757
HOVERFLY_VERSION: "1.2.0"
5858
steps:
@@ -70,7 +70,7 @@ jobs:
7070
7171
install_fails_if_no_runner_github_workspace_path:
7272
name: Install fails when no runner GitHub workspace path provided
73-
runs-on: ubuntu-20.04
73+
runs-on: ubuntu-latest
7474
steps:
7575
- uses: actions/[email protected]
7676
- name: Install Hoverfly
@@ -83,7 +83,7 @@ jobs:
8383
8484
install_fails_if_incorrect_runner_github_workspace_path:
8585
name: Install fails when incorrect runner GitHub workspace path provided
86-
runs-on: ubuntu-20.04
86+
runs-on: ubuntu-latest
8787
steps:
8888
- uses: actions/[email protected]
8989
- name: Install Hoverfly
@@ -98,7 +98,7 @@ jobs:
9898
9999
use_script_to_enable_https_simulations:
100100
name: Enable https simulations
101-
runs-on: ubuntu-20.04
101+
runs-on: ubuntu-latest
102102
steps:
103103
- uses: actions/[email protected]
104104
- name: Install Hoverfly
@@ -119,7 +119,7 @@ jobs:
119119
120120
https_simulations_do_not_work_without_https_script:
121121
name: Verify https simulations will not work without script
122-
runs-on: ubuntu-20.04
122+
runs-on: ubuntu-latest
123123
steps:
124124
- uses: actions/[email protected]
125125
- name: Install Hoverfly

0 commit comments

Comments
 (0)