Skip to content

Commit f57dcc8

Browse files
authored
Enable required status checks on forked PRs (#93)
Prior to this commit the [status checks][1] that we need to run on pull requests were only set to run on pushes. This meant that they were not being run when a contributor submitted a PR from a fork. To fix this we now run the required status check workflows explicitly on pull requests as well as pushes. [1]: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/about-status-checks
1 parent 4667eb8 commit f57dcc8

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

.github/workflows/reviewdog.yml

+6
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
11
---
22
name: reviewdog
33
on: # yamllint disable-line rule:truthy
4+
pull_request:
5+
types:
6+
- opened
7+
- edited
8+
- reopened
9+
- synchronize
410
push:
511

612
jobs:

.github/workflows/test.yml

+7-1
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,14 @@
11
---
22
name: Test
33
on: # yamllint disable-line rule:truthy
4-
# Run the tests on every push, and also at 3am every night
4+
pull_request:
5+
types:
6+
- opened
7+
- edited
8+
- reopened
9+
- synchronize
510
push:
11+
# Run the tests at 3am every night
612
schedule:
713
- cron: '0 3 * * *' # * is a special character in YAML so you have to quote this string
814
env:

0 commit comments

Comments
 (0)