Skip to content

When group chat messages are displayed as private #393

@ars3niy

Description

@ars3niy

If a protocol plugin calls purple_conv_chat_write with who="" (leading into conv_write_im) while the user hasn't entered corresponding conference room, then this code path:

LOG4CXX_WARN(logger, "handleConvMessagePayload: No conversation with name " << payload.buddyname());

will not be entered because nickname is empty, and the message will end up being displayed as private, as will all subsequent messages in this group chat even with who non-empty.

However, calling purple_conv_chat_write with who="" and PURPLE_MESSAGE_SYSTEM seems to be common practice, so perhaps there needs to be a way to handle such messages without accidentally handling them as private?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions