Skip to content

Commit dd60a35

Browse files
nviebigmilankl
andauthored
Shortwave Absorption Bug Fix & Stability Investigation (#978)
* Fix order of operations in one-band shortwave radiative transfer calculation * update changelog --------- Co-authored-by: Milan Kloewer <milankloewer@gmx.de>
1 parent 83631c8 commit dd60a35

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
# Changelog
22

33
## Unreleased
4+
5+
- Bug fix: Cloud reflectivity on half level above not below [#978](https://github.dev/SpeedyWeather/SpeedyWeather.jl/pull/978)
46
- Fix absorptivity_water_vapor and absorptivity_cloud_base default values [#974](https://github.com/SpeedyWeather/SpeedyWeather.jl/pull/974)
57
- Particle advection GPU ready [#897](https://github.com/SpeedyWeather/SpeedyWeather.jl/pull/897)
68
- Enzyme compat relaxed as Enzyme bug was fixed and uv_from_vordiv! kernel version used on CPU as well [#971](https://github.com/SpeedyWeather/SpeedyWeather.jl/pull/971)

SpeedyWeather/src/physics/radiation/shortwave_radiation.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,8 +225,8 @@ One-band shortwave radiative transfer with cloud reflection and ozone absorption
225225
U = U_surface_albedo + U_stratocumulus
226226
for k in nlayers:-1:1
227227
U_out = U * t[ij, k]
228-
U_out += k == cloud_top ? U_reflected : zero(U)
229228
dTdt[ij, k] += flux_to_tendency((U - U_out) / cₚ, pₛ, k, model)
229+
U_out += k == cloud_top ? U_reflected : zero(U)
230230
U = U_out
231231
end
232232

0 commit comments

Comments
 (0)