closed issue #421 (#425)

* closed issue #421
added UserSegmentId to Article
added PermissionGroupId to Article
* fixed test speed
* fix task Delay
* set lang version

Author: mozts2005

src/ZendeskApi_v2.Example/Program.cs

@@ -12,7 +12,7 @@ async static Task Main(string[] args)
         {
             var userEmailToSearchFor = "eneif123@yahoo.com";
 
-            var userName = "csharpzendeskapi1234@gmail.com"; // the user that will be logging in the API aka the call center staff 
+            var userName = "csharpzendeskapi1234@gmail.com"; // the user that will be logging in the API aka the call center staff
             var userPassword = "&H3n!0q^3OjDLdm";
             var companySubDomain = "csharpapi"; // sub-domain for the account with Zendesk
             var api = new ZendeskApi(companySubDomain, userName, userPassword);

src/ZendeskApi_v2/Core.cs

@@ -361,7 +361,8 @@ public async Task<T> GetByPageUrlAsync<T>(string pageUrl, int perPage = 100)
             {
                 return JsonConvert.DeserializeObject<T>("");
             }
-            var test = Regex.Split(pageUrl, "api/v2/");
+
+            _ = Regex.Split(pageUrl, "api/v2/");
 
             var resource = Regex.Split(pageUrl, "api/v2/").Last() + (perPage != 0 ? $"&per_page={perPage}" : "");
             return await RunRequestAsync<T>(resource, RequestMethod.Get);

src/ZendeskApi_v2/Models/Articles/Article.cs

@@ -70,5 +70,11 @@ public class Article
 
         [JsonProperty("translations")]
         public IList<Translation> Translations { get; set; }
+
+        [JsonProperty("user_segment_id")]
+        public long? UserSegmentId { get; set; }
+
+        [JsonProperty("permission_group_id")]
+        public long PermissionGroupId { get; set; }
     }
 }

src/ZendeskApi_v2/Models/HelpCenter/Subscriptions/ArticleSubscription.cs

@@ -11,15 +11,15 @@ public class ArticleSubscription : Subscription
         [JsonConstructor]
         private ArticleSubscription() { }
 
-        public ArticleSubscription(string local)
+        public ArticleSubscription(string locale)
         {
-            SourceLocal = local ?? throw new ArgumentNullException(nameof(local));
+            SourceLocale = locale ?? throw new ArgumentNullException(nameof(locale));
         }
 
         /// <summary>
         /// only used when create a new article subscription
         /// </summary>
         [JsonProperty("source_locale")]
-        public string SourceLocal { get; }
+        public string SourceLocale { get; }
     }
 }

src/ZendeskApi_v2/Models/Sections/Section.cs

@@ -51,6 +51,7 @@ public class Section
         [JsonProperty("translations")]
         public IList<Translation> Translations { get; set; }
 
+        [Obsolete("Deprecated please use options on articles \r\n See: https://develop.zendesk.com/hc/en-us/articles/360001954227 ", true)]
         [JsonProperty("user_segment_id")]
         public long? UserSegmentId { get; set; }
     }

src/ZendeskApi_v2/Models/UserSegments/GroupUserSegmentResponse.cs

@@ -1,7 +1,4 @@
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
+using System.Collections.Generic;
 using Newtonsoft.Json;
 using ZendeskApi_v2.Models.HelpCenter.Topics;
 
@@ -10,8 +7,8 @@ namespace ZendeskApi_v2.Models.UserSegments
     public class GroupUserSegmentResponse : GroupResponseBase
     {
         [JsonProperty("user_segments")]
-        public IList<UserSegment> UserSegments{ get; set; }
-       
+        public IList<UserSegment> UserSegments { get; set; }
+
         [JsonProperty("sections")]
         public IList<Sections.Section> Sections { get; set; }
 

src/ZendeskApi_v2/Models/UserSegments/UserSegment.cs

@@ -1,5 +1,4 @@
 using System.Collections.Generic;
-using System.Runtime.Serialization;
 using Newtonsoft.Json;
 using Newtonsoft.Json.Converters;
 
@@ -19,7 +18,7 @@ public class UserSegment
         [JsonProperty("name")]
         public string Name { get; set; }
 
-        [JsonConverter(typeof(StringEnumConverter))] 
+        [JsonConverter(typeof(StringEnumConverter))]
         [JsonProperty("user_type", DefaultValueHandling = DefaultValueHandling.Include)]
         public UserType UserType { get; set; }
 
@@ -31,5 +30,17 @@ public class UserSegment
 
         [JsonProperty("tags")]
         public IList<string> Tags { get; set; }
+
+        [JsonProperty("created_at")]
+        public string CreatedAt { get; set; }
+
+        [JsonProperty("updated_at")]
+        public string UpdatedAt { get; set; }
+
+        /// <summary>
+        /// Whether the user segment is built-in. Built-in user segments cannot be modified
+        /// </summary>
+        [JsonProperty("built_in")]
+        public bool BuiltIn { get; set; }
     }
 }

src/ZendeskApi_v2/Requests/HelpCenter/Topics.cs

@@ -92,7 +92,7 @@ public bool DeleteSubscription(long topicId, long SubscriptionId)
         }
 #endif
 #if ASYNC
-        public async Task<GroupTopicResponse> GetTopicsAsync(int? perPage = default(int?), int? page = default(int?))
+        public async Task<GroupTopicResponse> GetTopicsAsync(int? perPage = default, int? page = default)
         {
             return await GenericPagedGetAsync<GroupTopicResponse>("community/topics.json", perPage, page);
         }

src/ZendeskApi_v2/ZendeskApi_v2.csproj

@@ -23,6 +23,7 @@
     <IncludeSource>false</IncludeSource>
     <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
     <OutputType>Library</OutputType>
+    <LangVersion>latest</LangVersion>
   </PropertyGroup>
 
   <PropertyGroup>

test/ZendeskApi_v2.Test/AccountsAndActivityTests.cs

@@ -14,17 +14,5 @@ public void CanGetSettings()
             var res = api.AccountsAndActivity.GetSettings();
             Assert.IsNotEmpty(res.Settings.Branding.HeaderColor);
         }
-
-        [Test]
-        public void CanGetActivities()
-        {
-            //the api returns empty objects and I'm not sure how to get it to populate
-            var res = api.AccountsAndActivity.GetActivities();
-
-            //var res1 = api.AccountsAndActivity.GetActivityById()
-            
-        }
     }
-
-    
 }