code cleanup (#367)

mozts2005 · web-flow · commit cbe079293574 · 2018-08-15T15:26:17.000-06:00
* code cleanup
Release Notes for 3.9

* removed blank lines
diff --git a/GitVersionConfig.yaml b/GitVersionConfig.yaml
@@ -1,4 +1,4 @@
-next-version: 3.7.3
+next-version: 3.10.0
 assembly-versioning-scheme: MajorMinorPatch
 mode: ContinuousDeployment
 build-metadata-padding: 0
diff --git a/ReleaseNotes.md b/ReleaseNotes.md
@@ -1,5 +1,48 @@
-# 3.8.0 (12 March 2018)
-
+# 3.9.0 (15 August 2018)
+
+ - [#366](https://github.com/mozts2005/ZendeskApi_v2/issues/366) - Do you support the new announced DDoS protection system? +Question
+ - [#364](https://github.com/mozts2005/ZendeskApi_v2/pull/364) - Bump NUnit3TestAdapter from 3.9.0 to 3.10.0 in /src contributed by ([dependabot[bot]](https://github.com/apps/dependabot)) +dependencies
+ - [#363](https://github.com/mozts2005/ZendeskApi_v2/pull/363) - Bump Microsoft.NET.Test.Sdk from 15.5.0 to 15.8.0 in /src contributed by ([dependabot[bot]](https://github.com/apps/dependabot)) +dependencies
+ - [#362](https://github.com/mozts2005/ZendeskApi_v2/pull/362) - Bump MSBuild.Sdk.Extras from 1.0.9 to 1.6.46 in /src contributed by ([dependabot[bot]](https://github.com/apps/dependabot)) +dependencies
+ - [#361](https://github.com/mozts2005/ZendeskApi_v2/pull/361) - Bump Newtonsoft.Json from 11.0.1 to 11.0.2 in /src contributed by ([dependabot[bot]](https://github.com/apps/dependabot)) +dependencies
+ - [#359](https://github.com/mozts2005/ZendeskApi_v2/pull/359) - Bump NUnit from 3.9.0 to 3.10.1 in /src contributed by ([dependabot[bot]](https://github.com/apps/dependabot)) +dependencies
+ - [#360](https://github.com/mozts2005/ZendeskApi_v2/pull/360) - Bump Microsoft.NETCore.UniversalWindowsPlatform from 5.4.1 to 6.1.7 in /src contributed by ([dependabot[bot]](https://github.com/apps/dependabot)) +dependencies
+ - [#357](https://github.com/mozts2005/ZendeskApi_v2/issues/357) - Tickets.GetTicketsByViewID - int required, but must be long +More-Info-Needed
+ - [#356](https://github.com/mozts2005/ZendeskApi_v2/pull/356) - Support incremental organization export contributed by Ben Emmett ([bcemmett](https://github.com/bcemmett)) +Enhancement
+ - [#353](https://github.com/mozts2005/ZendeskApi_v2/issues/353) - Suddently my app stop work +Question
+ - [#352](https://github.com/mozts2005/ZendeskApi_v2/issues/352) - Removal-of-support-for-TLS-protocol-versions-1-0-and-1-1 +Question
+ - [#350](https://github.com/mozts2005/ZendeskApi_v2/issues/350) - TLS/1.0 Error +Question
+ - [#349](https://github.com/mozts2005/ZendeskApi_v2/pull/349) - Fix Issue #345 + #337 + Fix UserTests that failed/was incorrectly implemented contributed by Rasmus Wulff Jensen ([rwjdk](https://github.com/rwjdk))
+ - [#347](https://github.com/mozts2005/ZendeskApi_v2/pull/347) - Implementation of "Users.GetIncrementalUserExport" and "Users.GetIncrementalUserExportNextPage" (+Async versions) contributed by Rasmus Wulff Jensen ([rwjdk](https://github.com/rwjdk))
+ - [#345](https://github.com/mozts2005/ZendeskApi_v2/issues/345) - Tickets.GetInrementalTicketExportAsync is spelled wrong and do not use the side-load options provided +fix
+ - [#344](https://github.com/mozts2005/ZendeskApi_v2/pull/344) - Issue #330 + CRUD operations for Comments contributed by Rasmus Wulff Jensen ([rwjdk](https://github.com/rwjdk))
+ - [#343](https://github.com/mozts2005/ZendeskApi_v2/pull/343) - Test "CanCreateTicketWithDueDate" can't run on PCs that use dd/MM/yyyy format contributed by Rasmus Wulff Jensen ([rwjdk](https://github.com/rwjdk))
+ - [#342](https://github.com/mozts2005/ZendeskApi_v2/issues/342) - Can't sign Contributes Agreement
+ - [#341](https://github.com/mozts2005/ZendeskApi_v2/issues/341) - Error Socket to connect zendesk
+ - [#340](https://github.com/mozts2005/ZendeskApi_v2/issues/340) - Authentication Error +Question
+ - [#338](https://github.com/mozts2005/ZendeskApi_v2/pull/338) - Bulk user delete support contributed by Devin Wall ([dm430](https://github.com/dm430))
+ - [#337](https://github.com/mozts2005/ZendeskApi_v2/issues/337) - Missing field in ZendeskApi_v2.Models.Satisfaction.SatisfactionRating +Enhancement +help-wanted
+ - [#336](https://github.com/mozts2005/ZendeskApi_v2/pull/336) - Add locale to categories contributed by Denis P. ([Lsdenis](https://github.com/Lsdenis))
+ - [#335](https://github.com/mozts2005/ZendeskApi_v2/issues/335) - Issue with Tickets.GetAuditsAsync() +fix +More-Info-Needed
+ - [#334](https://github.com/mozts2005/ZendeskApi_v2/pull/334) - Add netstandard2.0 as target framework contributed by Morten Brix Pedersen ([mbp](https://github.com/mbp)) +Enhancement
+ - [#333](https://github.com/mozts2005/ZendeskApi_v2/issues/333) - Cannot set value for CustomField defined as drop-down type +Question
+ - [#332](https://github.com/mozts2005/ZendeskApi_v2/issues/332) - Request: Get draft article/category/section
+ - [#330](https://github.com/mozts2005/ZendeskApi_v2/issues/330) - Can you add ability to get the post comments ? +Enhancement
+ - [#329](https://github.com/mozts2005/ZendeskApi_v2/issues/329) - Remove Microsoft.Bcl dependency for .net45 +Under-Review
+ - [#328](https://github.com/mozts2005/ZendeskApi_v2/pull/328) - remove Microsoft.Net.Http dependency for .net4.5 contributed by Vlad Kurdzesau ([vlad-kurdesov](https://github.com/vlad-kurdesov))
+ - [#315](https://github.com/mozts2005/ZendeskApi_v2/issues/315) - Dedicated method for user incremental export +Enhancement +help-wanted
+ - [#235](https://github.com/mozts2005/ZendeskApi_v2/issues/235) - .net core support? +Enhancement +In-progress
+
+Commits: 3094b3d604...e6fae0a245
+
+
+# v3.8.0 (12 March 2018)
+
+ - [#327](https://github.com/mozts2005/ZendeskApi_v2/pull/327) - Release v3.8 contributed by Elizabeth Schneider ([mozts2005](https://github.com/mozts2005))
+ - [#326](https://github.com/mozts2005/ZendeskApi_v2/pull/326) - updated unit test contributed by Elizabeth Schneider ([mozts2005](https://github.com/mozts2005))
+ - [#325](https://github.com/mozts2005/ZendeskApi_v2/pull/325) - Adding support for pagination in GetUsersInOrganization in the Users … contributed by Jean-Michel Provencher ([jmprovencher](https://github.com/jmprovencher)) +Enhancement
+ - [#322](https://github.com/mozts2005/ZendeskApi_v2/issues/322) - PlatfromNotSupportedException in UWP Windows 10 app in .NET Native compilation mode +Enhancement
+ - [#317](https://github.com/mozts2005/ZendeskApi_v2/issues/317) - Request Class is missing Type +fix +In-progress
  - [#325](https://github.com/mozts2005/ZendeskApi_v2/pull/325) - Adding support for pagination in GetUsersInOrganization in the Users … contributed by Jean-Michel Provencher ([jmprovencher](https://github.com/jmprovencher)) +Enhancement
  - [#324](https://github.com/mozts2005/ZendeskApi_v2/pull/324) - added UWP Support contributed by Elizabeth Schneider ([mozts2005](https://github.com/mozts2005))
  - [#323](https://github.com/mozts2005/ZendeskApi_v2/pull/323) - added UWP Support contributed by Elizabeth Schneider ([mozts2005](https://github.com/mozts2005))
@@ -11,7 +54,7 @@
  - [#302](https://github.com/mozts2005/ZendeskApi_v2/issues/302) - Help Center Access Policies will be deprecated +fix
  - [#299](https://github.com/mozts2005/ZendeskApi_v2/issues/299) - GetArticlesBySectionId returns 0 results
 
-Commits: a2af9c43c3...424470954e
+Commits: a2af9c43c3...8ecd5e1d8d
 
 
 # 3.7.2 (27 November 2017)
diff --git a/src/ZendeskApi_v2/Core.cs b/src/ZendeskApi_v2/Core.cs
@@ -49,7 +49,7 @@ public class Core : ICore
         protected string Password;
         protected string ZendeskUrl;
         protected string ApiToken;
-        JsonSerializerSettings jsonSettings = new JsonSerializerSettings
+        private readonly JsonSerializerSettings jsonSettings = new JsonSerializerSettings
         {
             NullValueHandling = NullValueHandling.Ignore,
             DateParseHandling = DateParseHandling.DateTimeOffset,
@@ -421,7 +421,7 @@ public async Task<RequestResult> RunRequestAsync(string resource, string request
                     var content = string.Empty;
                     using (var responseStream = response.GetResponseStream())
                     {
-                        
+
                         using (var sr = new StreamReader(responseStream))
                         {
                             content = await sr.ReadToEndAsync();
@@ -608,8 +608,7 @@ private WebException GetWebException(string resource, object body, WebException
 
             if (body != null)
             {
-                var zenFile = body as ZenFile;
-                if (zenFile == null)
+                if (!(body is ZenFile zenFile))
                 {
                     bodyMessage = $" Body: {JsonConvert.SerializeObject(body, Formatting.Indented, jsonSettings)}";
                 }
diff --git a/src/ZendeskApi_v2/Requests/Users.cs b/src/ZendeskApi_v2/Requests/Users.cs
@@ -332,13 +332,13 @@ public GroupUserResponse GetUsersInOrganization(long id, int? perPage = null, in
 
         public IndividualUserResponse CreateUser(User user)
         {
-            var body = new { user = user };
+            var body = new { user };
             return GenericPost<IndividualUserResponse>("users.json", body);
         }
 
         public JobStatusResponse BulkCreateUsers(IEnumerable<User> users)
         {
-            var body = new { users = users };
+            var body = new { users };
             return GenericPost<JobStatusResponse>("users/create_many.json", body);
         }
 
@@ -350,7 +350,7 @@ public IndividualUserResponse SuspendUser(long id)
 
         public IndividualUserResponse UpdateUser(User user)
         {
-            var body = new { user = user };
+            var body = new { user };
             return GenericPut<IndividualUserResponse>($"users/{user.Id}.json", body);
         }
 
@@ -569,13 +569,13 @@ public async Task<GroupUserResponse> GetUsersInOrganizationAsync(long id, int? p
 
         public async Task<IndividualUserResponse> CreateUserAsync(User user)
         {
-            var body = new { user = user };
+            var body = new { user };
             return await GenericPostAsync<IndividualUserResponse>("users.json", body);
         }
 
         public async Task<JobStatusResponse> BulkCreateUsersAsync(IEnumerable<User> users)
         {
-            var body = new { users = users };
+            var body = new { users };
             return await GenericPostAsync<JobStatusResponse>("users/create_many.json", body);
         }
 
@@ -587,7 +587,7 @@ public async Task<IndividualUserResponse> SuspendUserAsync(long id)
 
         public async Task<IndividualUserResponse> UpdateUserAsync(User user)
         {
-            var body = new { user = user };
+            var body = new { user };
             return await GenericPutAsync<IndividualUserResponse>($"users/{user.Id}.json", body);
         }
 
diff --git a/test/ZendeskApi_v2.Test/HelpCenter/CommentTests.cs b/test/ZendeskApi_v2.Test/HelpCenter/CommentTests.cs
@@ -11,7 +11,7 @@ namespace Tests
     public class CommentTests
     {
         private ZendeskApi api = new ZendeskApi(Settings.Site, Settings.AdminEmail, Settings.AdminPassword);
-        private long _testSectionIdForCommentsTest = 360000205286; //https://csharpapi.zendesk.com/hc/en-us/sections/360000205286-Test-Section-For-Comment-Tests
+        private readonly long _testSectionIdForCommentsTest = 360000205286; //https://csharpapi.zendesk.com/hc/en-us/sections/360000205286-Test-Section-For-Comment-Tests
         private long _testTopicIdForCommentsTest = 360000016546; //https://csharpapi.zendesk.com/hc/en-us/community/topics/360000016546-Test-Topic-For-Comment-Tests
 
         [OneTimeSetUp]
diff --git a/test/ZendeskApi_v2.Test/HelpCenter/TranslationTests.cs b/test/ZendeskApi_v2.Test/HelpCenter/TranslationTests.cs
@@ -189,8 +189,7 @@ public void CanListAllEnabledLocales()
         {
             //the only two locales enabled on the test site are us-en and fr. us-en is the default.
             //note: FR was already enabled in the Zendesk settings, however it had to be enabled again in the help center preferences.
-            string default_locale;
-            var res = api.HelpCenter.Translations.ListAllEnabledLocalesAndDefaultLocale(out default_locale);
+            var res = api.HelpCenter.Translations.ListAllEnabledLocalesAndDefaultLocale(out var default_locale);
 
             Assert.AreEqual(default_locale, "en-us");
             Assert.IsTrue(res.Contains("en-us"));
diff --git a/test/ZendeskApi_v2.Test/HelpCenter/VoteTests.cs b/test/ZendeskApi_v2.Test/HelpCenter/VoteTests.cs
@@ -10,7 +10,7 @@ namespace Tests.HelpCenter
     public class VoteTests
     {
         private ZendeskApi api = new ZendeskApi(Settings.Site, Settings.AdminEmail, Settings.AdminPassword);
-        private long _articleIdWithVotes = 204838115; //https://csharpapi.zendesk.com/hc/en-us/articles/204838115-Thing-4?page=1#comment_200486479
+        private readonly long _articleIdWithVotes = 204838115; //https://csharpapi.zendesk.com/hc/en-us/articles/204838115-Thing-4?page=1#comment_200486479
 
         [Test]
         public void CanGetArticleVotes()
diff --git a/test/ZendeskApi_v2.Test/OrganizationTests.cs b/test/ZendeskApi_v2.Test/OrganizationTests.cs
@@ -167,9 +167,11 @@ public void CanCreateManyAndDeleteOrganizationMemberships()
 
             Assert.Greater(res.User.Id, 0);
 
-            var memberships = new List<OrganizationMembership>();
-            memberships.Add(new OrganizationMembership() { UserId = res.User.Id, OrganizationId = org.Organization.Id });
-            memberships.Add(new OrganizationMembership() { UserId = res.User.Id, OrganizationId = org2.Organization.Id });
+            var memberships = new List<OrganizationMembership>
+            {
+                new OrganizationMembership() { UserId = res.User.Id, OrganizationId = org.Organization.Id },
+                new OrganizationMembership() { UserId = res.User.Id, OrganizationId = org2.Organization.Id }
+            };
 
             var job = api.Organizations.CreateManyOrganizationMemberships(memberships).JobStatus;
 
diff --git a/test/ZendeskApi_v2.Test/TicketTests.cs b/test/ZendeskApi_v2.Test/TicketTests.cs
@@ -9,11 +9,11 @@
 using NUnit.Framework;
 using ZendeskApi_v2;
 using ZendeskApi_v2.Extensions;
+using ZendeskApi_v2.Models.Brands;
 using ZendeskApi_v2.Models.Constants;
 using ZendeskApi_v2.Models.Shared;
 using ZendeskApi_v2.Models.Tickets;
 using ZendeskApi_v2.Requests;
-using ZendeskApi_v2.Models.Brands;
 
 namespace Tests
 {
@@ -22,7 +22,7 @@ namespace Tests
     public class TicketTests
     {
         private ZendeskApi api = new ZendeskApi(Settings.Site, Settings.AdminEmail, Settings.AdminPassword);
-        private TicketSideLoadOptionsEnum ticketSideLoadOptions = TicketSideLoadOptionsEnum.Users | TicketSideLoadOptionsEnum.Organizations | TicketSideLoadOptionsEnum.Groups;
+        private readonly TicketSideLoadOptionsEnum ticketSideLoadOptions = TicketSideLoadOptionsEnum.Users | TicketSideLoadOptionsEnum.Organizations | TicketSideLoadOptionsEnum.Groups;
 
         [OneTimeTearDown]
         public async Task TestCleanUp()
@@ -734,6 +734,7 @@ public void CanGetIncrementalTicketExportPaged()
         [Test]
         public void CanGetIncrementalTicketExportWithUsersSideLoadPaged()
         {
+            Thread.Sleep(60000);
             const int maxTicketsPerPage = 1000;
 
             var res = api.Tickets.GetIncrementalTicketExport(DateTime.Now.AddDays(-365), TicketSideLoadOptionsEnum.Users);
@@ -742,7 +743,7 @@ public void CanGetIncrementalTicketExportWithUsersSideLoadPaged()
             Assert.IsTrue(res.Users.Count > 0);
             Assert.That(res.NextPage, Is.Not.Null.Or.Empty);
 
-            res = this.api.Tickets.GetIncrementalTicketExportNextPage(res.NextPage);
+            res = api.Tickets.GetIncrementalTicketExportNextPage(res.NextPage);
 
             Assert.IsTrue(res.Tickets.Count > 0);
             Assert.IsTrue(res.Users.Count > 0);
@@ -751,6 +752,8 @@ public void CanGetIncrementalTicketExportWithUsersSideLoadPaged()
         [Test]
         public void CanGetIncrementalTicketExportWithGroupsSideLoadPaged()
         {
+            Thread.Sleep(60000);
+
             const int maxTicketsPerPage = 1000;
 
             var res = api.Tickets.GetIncrementalTicketExport(DateTime.Now.AddDays(-700), TicketSideLoadOptionsEnum.Groups);
@@ -759,7 +762,7 @@ public void CanGetIncrementalTicketExportWithGroupsSideLoadPaged()
             Assert.IsTrue(res.Groups.Count > 0);
             Assert.That(res.NextPage, Is.Not.Null.Or.Empty);
 
-            res = this.api.Tickets.GetIncrementalTicketExportNextPage(res.NextPage);
+            res = api.Tickets.GetIncrementalTicketExportNextPage(res.NextPage);
 
             Assert.IsTrue(res.Tickets.Count > 0);
             Assert.IsTrue(res.Groups.Count > 0);
diff --git a/test/ZendeskApi_v2.Test/UserTests.cs b/test/ZendeskApi_v2.Test/UserTests.cs
@@ -515,6 +515,8 @@ public void CanGetIncrementalUserExport()
         [Test]
         public void CanGetIncrementalUserExportWithSideLoadOptions()
         {
+            Thread.Sleep(60000);
+
             var incrementalUserExport = api.Users.GetIncrementalUserExport(DateTimeOffset.MinValue, UserSideLoadOptions.Organizations | UserSideLoadOptions.Groups | UserSideLoadOptions.Identities);
             Assert.That(incrementalUserExport.Users.Count, Is.GreaterThan(0));
             Assert.That(incrementalUserExport.Organizations, Is.Not.Null);
diff --git a/tools/GitReleaseNotes.exe b/tools/GitReleaseNotes.exe
diff --git a/tools/NativeBinaries/amd64/git2-785d8c4.dll b/tools/NativeBinaries/amd64/git2-785d8c4.dll
diff --git a/tools/NativeBinaries/linux/amd64/libgit2-785d8c4.so b/tools/NativeBinaries/linux/amd64/libgit2-785d8c4.so
diff --git a/tools/NativeBinaries/osx/libgit2-785d8c4.dylib b/tools/NativeBinaries/osx/libgit2-785d8c4.dylib
diff --git a/tools/ReleaseNotes.ps1 b/tools/ReleaseNotes.ps1
@@ -1,9 +1,9 @@
 Param(
-  [string]$Version = "3.8.0",
+  [string]$Version = "3.9.0",
   [string]$gitHubToken = "$env:GitHubToken"
 )
 
 $gitReleaseNotesPath = "$PSScriptRoot\GitReleaseNotes.exe"
 Push-Location  "$PSScriptRoot\.."
-& $gitReleaseNotesPath . /O ReleaseNotes.md /Vers $Version /RepoUrl https://github.com/mozts2005/ZendeskApi_v2 /RepoUsername mozts2005 /RepoT $gitHubToken /IssueTrackerUsername mozts /IssueTrackerToken $gitHubToken
+& $gitReleaseNotesPath . /O ReleaseNotes.md /Vers $Version /RepoUrl https://github.com/mozts2005/ZendeskApi_v2 /RepoUsername mozts2005 /RepoT $gitHubToken /IssueTrackerUsername mozts2005 /IssueTrackerToken $gitHubToken /AllT /AllL
 Pop-Location

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-next-version: 3.7.3`
	`1`	`+next-version: 3.10.0`
`2`	`2`	`assembly-versioning-scheme: MajorMinorPatch`
`3`	`3`	`mode: ContinuousDeployment`
`4`	`4`	`build-metadata-padding: 0`
Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ public class Core : ICore`
`49`	`49`	`protected string Password;`
`50`	`50`	`protected string ZendeskUrl;`
`51`	`51`	`protected string ApiToken;`
`52`		`- JsonSerializerSettings jsonSettings = new JsonSerializerSettings`
	`52`	`+ private readonly JsonSerializerSettings jsonSettings = new JsonSerializerSettings`
`53`	`53`	`{`
`54`	`54`	`NullValueHandling = NullValueHandling.Ignore,`
`55`	`55`	`DateParseHandling = DateParseHandling.DateTimeOffset,`
`@@ -421,7 +421,7 @@ public async Task<RequestResult> RunRequestAsync(string resource, string request`
`421`	`421`	`var content = string.Empty;`
`422`	`422`	`using (var responseStream = response.GetResponseStream())`
`423`	`423`	`{`
`424`		`-`
	`424`	`+`
`425`	`425`	`using (var sr = new StreamReader(responseStream))`
`426`	`426`	`{`
`427`	`427`	`content = await sr.ReadToEndAsync();`
`@@ -608,8 +608,7 @@ private WebException GetWebException(string resource, object body, WebException`
`608`	`608`
`609`	`609`	`if (body != null)`
`610`	`610`	`{`
`611`		`- var zenFile = body as ZenFile;`
`612`		`- if (zenFile == null)`
	`611`	`+ if (!(body is ZenFile zenFile))`
`613`	`612`	`{`
`614`	`613`	`bodyMessage = $" Body: {JsonConvert.SerializeObject(body, Formatting.Indented, jsonSettings)}";`
`615`	`614`	`}`
Original file line number	Diff line number	Diff line change
`@@ -332,13 +332,13 @@ public GroupUserResponse GetUsersInOrganization(long id, int? perPage = null, in`
`332`	`332`
`333`	`333`	`public IndividualUserResponse CreateUser(User user)`
`334`	`334`	`{`
`335`		`- var body = new { user = user };`
	`335`	`+ var body = new { user };`
`336`	`336`	`return GenericPost<IndividualUserResponse>("users.json", body);`
`337`	`337`	`}`
`338`	`338`
`339`	`339`	`public JobStatusResponse BulkCreateUsers(IEnumerable<User> users)`
`340`	`340`	`{`
`341`		`- var body = new { users = users };`
	`341`	`+ var body = new { users };`
`342`	`342`	`return GenericPost<JobStatusResponse>("users/create_many.json", body);`
`343`	`343`	`}`
`344`	`344`
`@@ -350,7 +350,7 @@ public IndividualUserResponse SuspendUser(long id)`
`350`	`350`
`351`	`351`	`public IndividualUserResponse UpdateUser(User user)`
`352`	`352`	`{`
`353`		`- var body = new { user = user };`
	`353`	`+ var body = new { user };`
`354`	`354`	`return GenericPut<IndividualUserResponse>($"users/{user.Id}.json", body);`
`355`	`355`	`}`
`356`	`356`
`@@ -569,13 +569,13 @@ public async Task<GroupUserResponse> GetUsersInOrganizationAsync(long id, int? p`
`569`	`569`
`570`	`570`	`public async Task<IndividualUserResponse> CreateUserAsync(User user)`
`571`	`571`	`{`
`572`		`- var body = new { user = user };`
	`572`	`+ var body = new { user };`
`573`	`573`	`return await GenericPostAsync<IndividualUserResponse>("users.json", body);`
`574`	`574`	`}`
`575`	`575`
`576`	`576`	`public async Task<JobStatusResponse> BulkCreateUsersAsync(IEnumerable<User> users)`
`577`	`577`	`{`
`578`		`- var body = new { users = users };`
	`578`	`+ var body = new { users };`
`579`	`579`	`return await GenericPostAsync<JobStatusResponse>("users/create_many.json", body);`
`580`	`580`	`}`
`581`	`581`
`@@ -587,7 +587,7 @@ public async Task<IndividualUserResponse> SuspendUserAsync(long id)`
`587`	`587`
`588`	`588`	`public async Task<IndividualUserResponse> UpdateUserAsync(User user)`
`589`	`589`	`{`
`590`		`- var body = new { user = user };`
	`590`	`+ var body = new { user };`
`591`	`591`	`return await GenericPutAsync<IndividualUserResponse>($"users/{user.Id}.json", body);`
`592`	`592`	`}`
`593`	`593`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ namespace Tests`
`11`	`11`	`public class CommentTests`
`12`	`12`	`{`
`13`	`13`	`private ZendeskApi api = new ZendeskApi(Settings.Site, Settings.AdminEmail, Settings.AdminPassword);`
`14`		`- private long _testSectionIdForCommentsTest = 360000205286; //https://csharpapi.zendesk.com/hc/en-us/sections/360000205286-Test-Section-For-Comment-Tests`
	`14`	`+ private readonly long _testSectionIdForCommentsTest = 360000205286; //https://csharpapi.zendesk.com/hc/en-us/sections/360000205286-Test-Section-For-Comment-Tests`
`15`	`15`	`private long _testTopicIdForCommentsTest = 360000016546; //https://csharpapi.zendesk.com/hc/en-us/community/topics/360000016546-Test-Topic-For-Comment-Tests`
`16`	`16`
`17`	`17`	`[OneTimeSetUp]`
Original file line number	Diff line number	Diff line change
`@@ -189,8 +189,7 @@ public void CanListAllEnabledLocales()`
`189`	`189`	`{`
`190`	`190`	`//the only two locales enabled on the test site are us-en and fr. us-en is the default.`
`191`	`191`	`//note: FR was already enabled in the Zendesk settings, however it had to be enabled again in the help center preferences.`
`192`		`- string default_locale;`
`193`		`- var res = api.HelpCenter.Translations.ListAllEnabledLocalesAndDefaultLocale(out default_locale);`
	`192`	`+ var res = api.HelpCenter.Translations.ListAllEnabledLocalesAndDefaultLocale(out var default_locale);`
`194`	`193`
`195`	`194`	`Assert.AreEqual(default_locale, "en-us");`
`196`	`195`	`Assert.IsTrue(res.Contains("en-us"));`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ namespace Tests.HelpCenter`
`10`	`10`	`public class VoteTests`
`11`	`11`	`{`
`12`	`12`	`private ZendeskApi api = new ZendeskApi(Settings.Site, Settings.AdminEmail, Settings.AdminPassword);`
`13`		`- private long _articleIdWithVotes = 204838115; //https://csharpapi.zendesk.com/hc/en-us/articles/204838115-Thing-4?page=1#comment_200486479`
	`13`	`+ private readonly long _articleIdWithVotes = 204838115; //https://csharpapi.zendesk.com/hc/en-us/articles/204838115-Thing-4?page=1#comment_200486479`
`14`	`14`
`15`	`15`	`[Test]`
`16`	`16`	`public void CanGetArticleVotes()`
Original file line number	Diff line number	Diff line change
`@@ -515,6 +515,8 @@ public void CanGetIncrementalUserExport()`
`515`	`515`	`[Test]`
`516`	`516`	`public void CanGetIncrementalUserExportWithSideLoadOptions()`
`517`	`517`	`{`
	`518`	`+ Thread.Sleep(60000);`
	`519`	`+`
`518`	`520`	`var incrementalUserExport = api.Users.GetIncrementalUserExport(DateTimeOffset.MinValue, UserSideLoadOptions.Organizations \| UserSideLoadOptions.Groups \| UserSideLoadOptions.Identities);`
`519`	`521`	`Assert.That(incrementalUserExport.Users.Count, Is.GreaterThan(0));`
`520`	`522`	`Assert.That(incrementalUserExport.Organizations, Is.Not.Null);`