updated unit test (#326)

* updated unit test
updated release notes for 3.8

* update the build for TLS 1.2 for Github

* disabled dotnet core testing

* updated CLA system

Author: mozts2005

README.md

@@ -1,7 +1,8 @@
 ## Zendesk Api V2
 
 [![Donate](https://img.shields.io/badge/Donate-PayPal-green.svg)](https://www.paypal.com/cgi-bin/webscr?cmd=_donations&business=LRHN43F4DFLU6&lc=US&item_name=Elizabeth%20Schneider&item_number=ZendeskAPI%20support&currency_code=USD&bn=PP%2dDonationsBF%3abtn_donateCC_LG%2egif%3aNonHosted)
-[![Join the chat at https://gitter.im/mozts2005/ZendeskApi_v2](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/mozts2005/ZendeskApi_v2?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)  
+[![Join the chat at https://gitter.im/mozts2005/ZendeskApi_v2](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/mozts2005/ZendeskApi_v2?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge) 
+[![CLA assistant](https://cla-assistant.io/readme/badge/mozts2005/ZendeskApi_v2)](https://cla-assistant.io/mozts2005/ZendeskApi_v2)
 [![Build status](https://ci.appveyor.com/api/projects/status/6ve1ey4x7ctd5029?svg=true)](https://ci.appveyor.com/project/mozts2005/zendeskapi-v2)
 [![NuGet Version](https://img.shields.io/nuget/v/ZendeskApi_v2.svg)](https://www.nuget.org/packages/ZendeskApi_v2/)  
 [![MyGet Prerelease](https://img.shields.io/myget/zendeskapi_v2_prerelease/vpre/ZendeskApi_v2.svg?label=MyGet_Prerelease)](https://www.myget.org/feed/zendeskapi_v2_prerelease/package/nuget/ZendeskApi_v2)

ReleaseNotes.md

@@ -1,3 +1,19 @@
+# 3.8.0 (12 March 2018)
+
+ - [#325](https://github.com/mozts2005/ZendeskApi_v2/pull/325) - Adding support for pagination in GetUsersInOrganization in the Users … contributed by Jean-Michel Provencher ([jmprovencher](https://github.com/jmprovencher)) +Enhancement
+ - [#324](https://github.com/mozts2005/ZendeskApi_v2/pull/324) - added UWP Support contributed by Elizabeth Schneider ([mozts2005](https://github.com/mozts2005))
+ - [#323](https://github.com/mozts2005/ZendeskApi_v2/pull/323) - added UWP Support contributed by Elizabeth Schneider ([mozts2005](https://github.com/mozts2005))
+ - [#320](https://github.com/mozts2005/ZendeskApi_v2/pull/320) - changed user segment to be a long. contributed by Elizabeth Schneider ([mozts2005](https://github.com/mozts2005))
+ - [#319](https://github.com/mozts2005/ZendeskApi_v2/issues/319) - User Segment Id type should be extended +fix
+ - [#318](https://github.com/mozts2005/ZendeskApi_v2/issues/318) - cannot send inline image
+ - [#316](https://github.com/mozts2005/ZendeskApi_v2/pull/316) - Zendesk Voice amendments contributed by ([WinDrop](https://github.com/WinDrop))
+ - [#314](https://github.com/mozts2005/ZendeskApi_v2/pull/314) - Download attachment contributed by Elizabeth Schneider ([mozts2005](https://github.com/mozts2005))
+ - [#302](https://github.com/mozts2005/ZendeskApi_v2/issues/302) - Help Center Access Policies will be deprecated +fix
+ - [#299](https://github.com/mozts2005/ZendeskApi_v2/issues/299) - GetArticlesBySectionId returns 0 results
+
+Commits: a2af9c43c3...424470954e
+
+
 # 3.7.2 (27 November 2017)
 
  - [#313](https://github.com/mozts2005/ZendeskApi_v2/pull/313) - added option for download attchment contributed by Elizabeth Schneider ([mozts2005](https://github.com/mozts2005))
@@ -96,15 +112,6 @@ Commits: 4a6afa4034...406281ed5e
  - [#267](https://github.com/mozts2005/ZendeskApi_v2/issues/267) - Nuget dependencies are incorrect +fix
  - [#266](https://github.com/mozts2005/ZendeskApi_v2/pull/266) - Creating a Release for v3.6.0 contributed by Elizabeth Schneider ([mozts2005](https://github.com/mozts2005))
  - [#232](https://github.com/mozts2005/ZendeskApi_v2/issues/232) - Bulk/Batch endpoint support +Enhancement +hacktoberfest
- - [#273](https://github.com/mozts2005/ZendeskApi_v2/pull/273) - adding icon for the project (#272) contributed by Elizabeth Schneider ([mozts2005](https://github.com/mozts2005))
- - [#272](https://github.com/mozts2005/ZendeskApi_v2/pull/272) - Project Clean up contributed by Elizabeth Schneider ([mozts2005](https://github.com/mozts2005))
- - [#271](https://github.com/mozts2005/ZendeskApi_v2/pull/271) - Issue-270 contributed by Elizabeth Schneider ([mozts2005](https://github.com/mozts2005))
- - [#270](https://github.com/mozts2005/ZendeskApi_v2/issues/270) - API.HelpCenter.Articles.GetByPageUrl incorrectly formats the request Uri
- - [#269](https://github.com/mozts2005/ZendeskApi_v2/pull/269) - Fixed typo in var name in example project contributed by Keir Kettle ([keirk](https://github.com/keirk))
- - [#268](https://github.com/mozts2005/ZendeskApi_v2/pull/268) - Updated Nusepc File contributed by Elizabeth Schneider ([mozts2005](https://github.com/mozts2005))
- - [#267](https://github.com/mozts2005/ZendeskApi_v2/issues/267) - Nuget dependencies are incorrect +fix
- - [#266](https://github.com/mozts2005/ZendeskApi_v2/pull/266) - Creating a Release for v3.6.0 contributed by Elizabeth Schneider ([mozts2005](https://github.com/mozts2005))
- - [#232](https://github.com/mozts2005/ZendeskApi_v2/issues/232) - Bulk/Batch endpoint support +Enhancement +hacktoberfest
 
 Commits: 18286eb3df...acac84a4e8
 
@@ -116,11 +123,6 @@ Commits: 18286eb3df...acac84a4e8
  - [#263](https://github.com/mozts2005/ZendeskApi_v2/issues/263) - CreatePost() Exception +fix
  - [#262](https://github.com/mozts2005/ZendeskApi_v2/issues/262) - Need to change sectionid from int to long in article results +fix
  - [#261](https://github.com/mozts2005/ZendeskApi_v2/issues/261) - System.Net.WebException using version net45
- - [#265](https://github.com/mozts2005/ZendeskApi_v2/pull/265) - fixing build numbers contributed by Elizabeth Schneider ([mozts2005](https://github.com/mozts2005))
- - [#264](https://github.com/mozts2005/ZendeskApi_v2/pull/264) - Int to long contributed by Elizabeth Schneider ([mozts2005](https://github.com/mozts2005))
- - [#263](https://github.com/mozts2005/ZendeskApi_v2/issues/263) - CreatePost() Exception +fix
- - [#262](https://github.com/mozts2005/ZendeskApi_v2/issues/262) - Need to change sectionid from int to long in article results +fix
- - [#261](https://github.com/mozts2005/ZendeskApi_v2/issues/261) - System.Net.WebException using version net45
 
 Commits: 620e3740bd...0824eef954
 
@@ -138,17 +140,6 @@ Commits: 620e3740bd...0824eef954
  - [#251](https://github.com/mozts2005/ZendeskApi_v2/pull/251) - added Test Case for #246 contributed by Elizabeth Schneider ([mozts2005](https://github.com/mozts2005))
  - [#247](https://github.com/mozts2005/ZendeskApi_v2/issues/247) - Core.cs, WebException from RunRequest hides Response
  - [#246](https://github.com/mozts2005/ZendeskApi_v2/issues/246) - Ticket Group null +Test-case-needed
- - [#260](https://github.com/mozts2005/ZendeskApi_v2/pull/260) - updated Release Notes for v3.5.3 contributed by Elizabeth Schneider ([mozts2005](https://github.com/mozts2005))
- - [#259](https://github.com/mozts2005/ZendeskApi_v2/pull/259) - updated CONTRIBUTING.md contributed by Elizabeth Schneider ([mozts2005](https://github.com/mozts2005))
- - [#258](https://github.com/mozts2005/ZendeskApi_v2/pull/258) - update version number contributed by Elizabeth Schneider ([mozts2005](https://github.com/mozts2005))
- - [#257](https://github.com/mozts2005/ZendeskApi_v2/pull/257) - Fix #256 contributed by Elizabeth Schneider ([mozts2005](https://github.com/mozts2005))
- - [#256](https://github.com/mozts2005/ZendeskApi_v2/issues/256) - Problem updating custom Ticket Fields Async +fix
- - [#255](https://github.com/mozts2005/ZendeskApi_v2/pull/255) - Added Test for issue #254 contributed by Elizabeth Schneider ([mozts2005](https://github.com/mozts2005))
- - [#254](https://github.com/mozts2005/ZendeskApi_v2/issues/254) - Comment channel changed from "api" to "web" when pusing to zendesk +More-Info-Needed
- - [#253](https://github.com/mozts2005/ZendeskApi_v2/issues/253) - Search Tickets by Tag
- - [#251](https://github.com/mozts2005/ZendeskApi_v2/pull/251) - added Test Case for #246 contributed by Elizabeth Schneider ([mozts2005](https://github.com/mozts2005))
- - [#247](https://github.com/mozts2005/ZendeskApi_v2/issues/247) - Core.cs, WebException from RunRequest hides Response
- - [#246](https://github.com/mozts2005/ZendeskApi_v2/issues/246) - Ticket Group null +Test-case-needed
 
 Commits: 0716779368...cf3296eec6
 
@@ -164,15 +155,6 @@ Commits: 0716779368...cf3296eec6
  - [#242](https://github.com/mozts2005/ZendeskApi_v2/pull/242) - Release notes for v3.5.1 contributed by Elizabeth Schneider ([mozts2005](https://github.com/mozts2005))
  - [#227](https://github.com/mozts2005/ZendeskApi_v2/issues/227) - get User related info +Enhancement +hacktoberfest
  - [#226](https://github.com/mozts2005/ZendeskApi_v2/issues/226) - Inconsistant 422 Errors Unprocessable Entity - Updating Trigger +fix +Test-case-needed
- - [#250](https://github.com/mozts2005/ZendeskApi_v2/pull/250) - update MSbuild task contributed by Elizabeth Schneider ([mozts2005](https://github.com/mozts2005))
- - [#249](https://github.com/mozts2005/ZendeskApi_v2/pull/249) - Included original Response in new WebException contributed by Nick Coad ([nickcoad](https://github.com/nickcoad))
- - [#248](https://github.com/mozts2005/ZendeskApi_v2/pull/248) - Included original Response in new WebException contributed by Nick Coad ([nickcoad](https://github.com/nickcoad))
- - [#245](https://github.com/mozts2005/ZendeskApi_v2/pull/245) - Added Example Console Application contributed by Elizabeth Schneider ([mozts2005](https://github.com/mozts2005))
- - [#244](https://github.com/mozts2005/ZendeskApi_v2/pull/244) - get User related info #227 contributed by ([M3LiNdRu](https://github.com/M3LiNdRu))
- - [#243](https://github.com/mozts2005/ZendeskApi_v2/pull/243) - Support for Brands contributed by Jeremy Smith ([jerbri](https://github.com/jerbri))
- - [#242](https://github.com/mozts2005/ZendeskApi_v2/pull/242) - Release notes for v3.5.1 contributed by Elizabeth Schneider ([mozts2005](https://github.com/mozts2005))
- - [#227](https://github.com/mozts2005/ZendeskApi_v2/issues/227) - get User related info +Enhancement +hacktoberfest
- - [#226](https://github.com/mozts2005/ZendeskApi_v2/issues/226) - Inconsistant 422 Errors Unprocessable Entity - Updating Trigger +fix +Test-case-needed
 
 Commits: 847d222181...75e8f6a04e
 
@@ -189,16 +171,6 @@ Commits: 847d222181...75e8f6a04e
  - [#233](https://github.com/mozts2005/ZendeskApi_v2/issues/233) - Comments.Public = false creates comment as public +fix
  - [#231](https://github.com/mozts2005/ZendeskApi_v2/pull/231) - New Zendesk voice methods contributed by ([WinDrop](https://github.com/WinDrop))
  - [#230](https://github.com/mozts2005/ZendeskApi_v2/issues/230) - Would it be possible to compile ZendeskApi_v2 against .NET Framework 4.0?
- - [#241](https://github.com/mozts2005/ZendeskApi_v2/pull/241) - Release Note clean up contributed by Elizabeth Schneider ([mozts2005](https://github.com/mozts2005))
- - [#240](https://github.com/mozts2005/ZendeskApi_v2/issues/240) - Article property on IndividualArticleResponse is misspelled
- - [#239](https://github.com/mozts2005/ZendeskApi_v2/issues/239) - Update Ticket disregards public flag for comments
- - [#238](https://github.com/mozts2005/ZendeskApi_v2/issues/238) - SortOrder is ignored for search results +fix
- - [#237](https://github.com/mozts2005/ZendeskApi_v2/issues/237) - SearchForOrganizationsAsync() returns no results
- - [#236](https://github.com/mozts2005/ZendeskApi_v2/pull/236) - updated SearchForOrganizations to better reflect its purpose contributed by Mat Warger ([mwarger](https://github.com/mwarger))
- - [#234](https://github.com/mozts2005/ZendeskApi_v2/pull/234) - Fix an issue with bool serialization (#233) contributed by ([Tyf0x](https://github.com/Tyf0x))
- - [#233](https://github.com/mozts2005/ZendeskApi_v2/issues/233) - Comments.Public = false creates comment as public +fix
- - [#231](https://github.com/mozts2005/ZendeskApi_v2/pull/231) - New Zendesk voice methods contributed by ([WinDrop](https://github.com/WinDrop))
- - [#230](https://github.com/mozts2005/ZendeskApi_v2/issues/230) - Would it be possible to compile ZendeskApi_v2 against .NET Framework 4.0?
 
 Commits: cab28417d6...30fb69ed97
 
@@ -240,41 +212,6 @@ Commits: cab28417d6...30fb69ed97
  - [#190](https://github.com/mozts2005/ZendeskApi_v2/pull/190) - Added a Settings file instead of using a class to hold settings contributed by SPorter ([StephenMP](https://github.com/StephenMP))
  - [#140](https://github.com/mozts2005/ZendeskApi_v2/issues/140) - User Custom Field of DateTime type +More-Info-Needed
  - [#125](https://github.com/mozts2005/ZendeskApi_v2/issues/125) - Ticket Creation error +More-Info-Needed
- - [#229](https://github.com/mozts2005/ZendeskApi_v2/pull/229) - New class for voice data and method allowing to request more than 100 audits per ticket contributed by ([WinDrop](https://github.com/WinDrop))
- - [#228](https://github.com/mozts2005/ZendeskApi_v2/issues/228) - GrooveApi +Question
- - [#225](https://github.com/mozts2005/ZendeskApi_v2/issues/225) - invalid token +Question
- - [#224](https://github.com/mozts2005/ZendeskApi_v2/pull/224) - updated HelpCenterApi to properly format URL like Core does contributed by Mat Warger ([mwarger](https://github.com/mwarger))
- - [#223](https://github.com/mozts2005/ZendeskApi_v2/issues/223) - Issue with NuGet package +Question
- - [#222](https://github.com/mozts2005/ZendeskApi_v2/issues/222) - It can't be used by signed assembly
- - [#221](https://github.com/mozts2005/ZendeskApi_v2/issues/221) - Forum topics +Enhancement
- - [#220](https://github.com/mozts2005/ZendeskApi_v2/issues/220) - GetArticles blocked by section with tag assigned +Enhancement +In-progress
- - [#219](https://github.com/mozts2005/ZendeskApi_v2/issues/219) - Method not found +More-Info-Needed
- - [#218](https://github.com/mozts2005/ZendeskApi_v2/pull/218) - Adding support for translations contributed by Mark ([Marcus10110](https://github.com/Marcus10110))
- - [#217](https://github.com/mozts2005/ZendeskApi_v2/pull/217) - Follow up to Help Center Section Fix contributed by Mark ([Marcus10110](https://github.com/Marcus10110))
- - [#216](https://github.com/mozts2005/ZendeskApi_v2/pull/216) - [WIP] Unit test and fix for #195, "Help Center CreateSection API endpoint not correct, cannot create new sections." contributed by Mark ([Marcus10110](https://github.com/Marcus10110))
- - [#215](https://github.com/mozts2005/ZendeskApi_v2/issues/215) - Zendesk API change - help center update article endpoint no longer allows changes to body, title or draft +fix
- - [#214](https://github.com/mozts2005/ZendeskApi_v2/issues/214) - (401) Unauthorized "error":"invalid_token"
- - [#213](https://github.com/mozts2005/ZendeskApi_v2/pull/213) - Add support to get tickets by assigned contributed by Nate ([tympaniplayer](https://github.com/tympaniplayer))
- - [#212](https://github.com/mozts2005/ZendeskApi_v2/pull/212) - Support for compiling on UNC location contributed by ([fuhye](https://github.com/fuhye))
- - [#211](https://github.com/mozts2005/ZendeskApi_v2/pull/211) - Support for compiling on UNC location contributed by ([fuhye](https://github.com/fuhye))
- - [#210](https://github.com/mozts2005/ZendeskApi_v2/pull/210) - Support for compiling on UNC location contributed by ([fuhye](https://github.com/fuhye))
- - [#209](https://github.com/mozts2005/ZendeskApi_v2/issues/209) - TicketExportResponse - EndDate property not serialized correctly +Test-case-needed
- - [#208](https://github.com/mozts2005/ZendeskApi_v2/issues/208) - Ticket comment needs to have HTML body added +Enhancement +Up-for-Grabs
- - [#207](https://github.com/mozts2005/ZendeskApi_v2/pull/207) - Merging Pull Request 204 to Master contributed by Elizabeth Schneider ([mozts2005](https://github.com/mozts2005))
- - [#206](https://github.com/mozts2005/ZendeskApi_v2/pull/206) - Updates to support date changes in the Holiday API contributed by ([CKCobra](https://github.com/CKCobra))
- - [#205](https://github.com/mozts2005/ZendeskApi_v2/issues/205) - GetUserIdentities serialization error ( JSON integer is too large or small for an Int32) +fix
- - [#204](https://github.com/mozts2005/ZendeskApi_v2/pull/204) - Refactor incremental ticket export contributed by ([brightwavepartners](https://github.com/brightwavepartners))
- - [#203](https://github.com/mozts2005/ZendeskApi_v2/issues/203) - Article search serialization error (when Author Id exceeds max int). +fix
- - [#202](https://github.com/mozts2005/ZendeskApi_v2/pull/202) - Make GroupTagResult Pageable contributed by Tyler Sanborn ([Tybearius](https://github.com/Tybearius)) +Test-case-needed
- - [#201](https://github.com/mozts2005/ZendeskApi_v2/pull/201) - Test Unit to HtmlBody contributed by Andre Mesquita ([avmesquita](https://github.com/avmesquita))
- - [#199](https://github.com/mozts2005/ZendeskApi_v2/pull/199) - Needed to send HTML content contributed by Andre Mesquita ([avmesquita](https://github.com/avmesquita)) +Test-case-needed
- - [#198](https://github.com/mozts2005/ZendeskApi_v2/pull/198) - To send HTML content, need change HtmlBody contributed by Andre Mesquita ([avmesquita](https://github.com/avmesquita)) +Test-case-needed
- - [#197](https://github.com/mozts2005/ZendeskApi_v2/pull/197) - HtmlBody was as private set contributed by Andre Mesquita ([avmesquita](https://github.com/avmesquita)) +Test-case-needed
- - [#195](https://github.com/mozts2005/ZendeskApi_v2/issues/195) - Help Center CreateSection API endpoint not correct, cannot create new sections. +fix +Test-case-needed
- - [#194](https://github.com/mozts2005/ZendeskApi_v2/issues/194) - Can't add user photo +Enhancement +In-progress
- - [#190](https://github.com/mozts2005/ZendeskApi_v2/pull/190) - Added a Settings file instead of using a class to hold settings contributed by SPorter ([StephenMP](https://github.com/StephenMP))
- - [#140](https://github.com/mozts2005/ZendeskApi_v2/issues/140) - User Custom Field of DateTime type +More-Info-Needed
- - [#125](https://github.com/mozts2005/ZendeskApi_v2/issues/125) - Ticket Creation error +More-Info-Needed
 
 Commits: c386381743...0ab4b3f06e
 

appveyor.yml

@@ -7,6 +7,8 @@ image: Previous Visual Studio 2017
 pull_requests:
   do_not_increment_build_number: true
 configuration: Release
+environment:
+  APPVEYOR_BLOCK_DOTNETCORE_TESTS_AUTORUN: true
 nuget:
   disable_publish_on_pr: true
 # scripts that are called at very beginning, before repo cloning
@@ -42,6 +44,13 @@ notifications:
 install:
 - ps: >-
 
+    # set strong cryptography on 64 bit .Net Framework (version 4 and above)
+    Set-ItemProperty -Path 'HKLM:\SOFTWARE\Wow6432Node\Microsoft\.NetFramework\v4.0.30319' -Name 'SchUseStrongCrypto' -Value '1' -Type DWord
+
+
+    # set strong cryptography on 32 bit .Net Framework (version 4 and above)
+    Set-ItemProperty -Path 'HKLM:\SOFTWARE\Microsoft\.NetFramework\v4.0.30319' -Name 'SchUseStrongCrypto' -Value '1' -Type DWord 
+
     choco install gitversion.portable --pre --no-progress -y
     
     $output = gitversion
@@ -71,4 +80,4 @@ install:
     {
       $env:Is_Prerelease  = 'false'
     }
-    Write-Host "Is the build Prerelease: " $env:Is_Prerelease
+    Write-Host "Is the build Prerelease: " $env:Is_Prerelease

test/ZendeskApi_v2.Test/UserTests.cs

@@ -96,8 +96,27 @@ public void CanGetUsersInOrg()
         [Test]
         public void CanGetUsersInOrgPaginated()
         {
-            var res = api.Users.GetUsersInOrganization(Settings.OrganizationId, 100, 0);
-            Assert.True(res.Count > 0);
+            // create users
+            var users = new List<User>();
+            for (int i = 0; i < 5; i++)
+            {
+                var user = new User()
+                {
+                    Name = Guid.NewGuid().ToString("N") + " " + Guid.NewGuid().ToString("N"),
+                    Email = Guid.NewGuid().ToString("N") + "@" + Guid.NewGuid().ToString("N") + ".com",
+                    OrganizationId = Settings.OrganizationId
+                };
+
+                var res1 = api.Users.CreateUser(user);
+
+                users.Add(res1.User);
+            }
+
+            var res = api.Users.GetUsersInOrganization(Settings.OrganizationId, 3, 0);
+            Assert.That(res.Users.Count, Is.EqualTo(3));
+            Assert.That(res.NextPage, Is.Not.Null);
+
+            users.ForEach(u => api.Users.DeleteUser(u.Id.Value));
         }
 
         [Test]