Skip to content

Move binaries directory under binaries #71

@Christian-B

Description

@Christian-B

The binaries are currently stored in a directory that not inside (a child directory of) the main spinn_pdp2 directory.

This result in the code only working if installed in developer/ edittable mode.

In developer / editable mode the spinn_pdp2 directory is only referenced not copied into site_packages
Therefor the code
path to binary files
binaries_path = os.path.join(os.path.dirname(file), "..", "binaries")
works.

In a normal install the spinn_pdp2 directory is copied into site_packages.
However the "binaries" directory is not.
It could be but with a generic name like "binaries" this is not recommended.
Also the build would fail it you need sudo access to site_packages.

The PyPA recommends that any data files you wish to be accessible at run time be included inside the package.
ref: https://setuptools.pypa.io/en/latest/userguide/datafiles.html

The fix is to move binaries under spinn_pdp2 and change the code that references it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions