Skip to content

Commit 33635d6

Browse files
Merge pull request #66 from SpillwaveSolutions/fix/sample-okf-noun-mentions
fix: strip domain-noun names from sample-okf
2 parents 81493c0 + 7da92d3 commit 33635d6

4 files changed

Lines changed: 5 additions & 6 deletions

File tree

sample-okf/knowledge/okf-conventions.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,7 @@ This engine owns `Catalog` and `ContextPack` only. `validate --strict` rejects
2020
unknown types (fail-closed). BaseConcept fallback is read-only envelope
2121
parsing — it does not authorize writing an unregistered type.
2222

23-
Domain types (`AgentNode`, `TicketLink`, `DecisionRecord`, `Dataset`, `System`,
24-
…) are authored by AGER, PKC, DEKC, and SAC.
23+
Domain types are authored by AGER, PKC, DEKC, and SAC — not this plugin.
2524

2625
## Links
2726

sample-okf/knowledge/tool-okf-graph-py.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ python3 scripts/okf-graph.py orphans <bundle>
3131
other subcommands, while `mermaid` (default) and `html` print the artifact
3232
itself. The `html` view is self-contained — no CDN, no network fetches.
3333

34-
Related: `scripts/okf-ticket-link.py` is a stub. TicketLink emission lives in PKC.
34+
Related: `scripts/okf-ticket-link.py` is a stub. Work-item emission lives in PKC.
3535

3636
## Used by
3737

tests/test_okf_graph.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -427,7 +427,7 @@ def test_strict_rejects_unknown_types():
427427
"---\ntitle: Root\nokf_version: 0.2\ntype: Catalog\n---\n[n](/noun.md)\n"
428428
)
429429
(bundle / "noun.md").write_text(
430-
"---\ntitle: Agent\ntype: AgentNode\ndescription: leaked\n"
430+
"---\ntitle: Agent\ntype: NotARegisteredType\ndescription: leaked\n"
431431
"timestamp: 2026-01-01T00:00:00Z\n---\n"
432432
)
433433
code, out = run_script("validate", str(bundle))

tests/test_okf_schema.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -170,10 +170,10 @@ def test_strict_promotes_recommended_to_error():
170170
def test_strict_unknown_type_is_error_not_write_authorization():
171171
"""Fallback parses the envelope; --strict must not treat that as a valid write."""
172172
reg = load_default_registry()
173-
soft = reg.validate_frontmatter({"type": "AgentNode", "title": "x"})
173+
soft = reg.validate_frontmatter({"type": "NotARegisteredType", "title": "x"})
174174
assert any(i.severity == "info" and "unknown type" in i.message for i in soft)
175175
assert not any(i.severity == "error" and "unknown type" in i.message for i in soft)
176-
hard = reg.validate_frontmatter({"type": "AgentNode", "title": "x"}, strict=True)
176+
hard = reg.validate_frontmatter({"type": "NotARegisteredType", "title": "x"}, strict=True)
177177
assert any(i.severity == "error" and "unknown type" in i.message for i in hard)
178178
assert any("read-only" in i.message for i in hard)
179179

0 commit comments

Comments
 (0)