Replace unnecessary map by array

Author: Splines

lib/dummy_replacements_map.js

@@ -1,25 +1,24 @@
 /**
- * Map that tracks the replacements that have been made in the processed text
- * alongside their unique id. This id is just a counter that is incremented
- * for each replacement, see preprocess.js.
+ * Array that tracks the replacements that have been made in the processed text,
+ * so that we can reverse them later.
  */
 class DummyReplacementsMap {
   constructor() {
-    this.map = new Map();
+    this.replacements = [];
   }
 
-  addMapping(id, originalText, dummyText) {
-    this.map.set(id, [originalText, dummyText]);
+  addMapping(originalText, dummyText) {
+    this.replacements.push([originalText, dummyText]);
   }
 
   /**
-   * Applies the replacements from the map to the given text.
+   * Tries to apply all stored replacements to the given text.
    * @param {string} text - The text to apply the replacements to.
    * @returns {string} - The text with the replacements applied.
    */
   apply(text) {
     let lintableText = text;
-    for (const [_id, [originalText, dummyText]] of this.map) {
+    for (const [originalText, dummyText] of this.replacements) {
       lintableText = lintableText.replace(dummyText, originalText);
     }
     return lintableText;

lib/preprocess.js

@@ -20,7 +20,9 @@ const HASH = "566513c5d83ac26e15414f2754"; // to avoid collisions with user code
  * @param {string} text text of the file
  * @param {string} filename filename of the file
  * @param {(id) => string} dummyString dummy string to replace ERB tags with
- *                                     (this is language-specific)
+ *                                     (this is language-specific). Should be
+ *                                     a function that takes an id and returns
+ *                                     a UNIQUE dummy string.
  * @returns {Array<{ filename: string, text: string }>} source code blocks to lint
  */
 function preprocess(text, filename, dummyString) {
@@ -54,7 +56,7 @@ function preprocess(text, filename, dummyString) {
     replaceTextWithDummy(lintableTextArr, startIndex, matchLength - 1, dummy);
 
     const textWithErbSyntax = text.slice(startIndex, endIndex);
-    dummyReplacementsMap.addMapping(matchedId, textWithErbSyntax, dummy);
+    dummyReplacementsMap.addMapping(textWithErbSyntax, dummy);
 
     // Store in map
     const lineAfter = coordEndIndex.line - numAddLines;