delete unsafe stringmanip funcs

Author: Sploder12

src/include/sndx/utility/stringmanip.hpp

@@ -36,6 +36,9 @@ namespace sndx::utility {
 		return strip(sv<CharT>(str), strips);
 	}
 
+	template <class CharT = char>
+	constexpr sv<CharT> strip(Str<CharT>&&, sv<CharT> = defaultStrip<CharT>) = delete;
+
 	constexpr sv<char> strip(std::nullptr_t, sv<char> = defaultStrip<char>) = delete;
 
 	[[nodiscard]]
@@ -66,6 +69,9 @@ namespace sndx::utility {
 		return splitFirst(sv<CharT>(str), delim, strips);
 	}
 
+	template <class CharT = char>
+	constexpr std::pair<sv<char>, sv<char>> splitFirst(Str<CharT>&&, CharT, sv<CharT> = defaultStrip<char>) = delete;
+
 	constexpr std::pair<sv<char>, sv<char>> splitFirst(std::nullptr_t, char, sv<char> = defaultStrip<char>) = delete;
 
 	[[nodiscard]]
@@ -99,10 +105,13 @@ namespace sndx::utility {
 	}
 
 	template <class Chr = char> [[nodiscard]]
-	inline auto splitStrip(Str<Chr> str, Chr delim, sv<Chr> strips = sv<Chr>{ " \t\r" }) {
+	inline auto splitStrip(const Str<Chr>& str, Chr delim, sv<Chr> strips = sv<Chr>{ " \t\r" }) {
 		return splitStrip(sv<Chr>{str}, delim, strips);
 	}
 
+	template <class Chr = char>
+	inline auto splitStrip(Str<Chr>&&, Chr, sv<Chr> = sv<Chr>{ " \t\r" }) = delete;
+
 	inline std::vector<sv<char>> splitStrip(std::nullptr_t, char, sv<char> = defaultStrip<char>) = delete;
 
 	[[nodiscard]]

src/tests/utility/stringmanip.cpp

@@ -9,11 +9,13 @@ using str = sv<char>;
 TEST(StringManip, Strip) {
 	EXPECT_EQ(strip(""), "");
 	EXPECT_EQ(strip(" "), "");
-	EXPECT_EQ(strip(std::string("  ")), "");
+	EXPECT_EQ(strip("  "), "");
 	EXPECT_EQ(strip(" \t "), "");
 	EXPECT_EQ(strip(" \r\t\r \t  \r"), "");
 
-	EXPECT_EQ(strip("apple"), "apple");
+	std::string apple = "apple";
+
+	EXPECT_EQ(strip(apple), "apple");
 	EXPECT_EQ(strip(" apple\r"), "apple");
 	EXPECT_EQ(strip("app le\r"), "app le");
 	EXPECT_EQ(strip("\t a p\r ple\t "), "a p\r ple");
@@ -33,7 +35,9 @@ TEST(StringManip, SplitFirst) {
 	EXPECT_EQ(splitFirst("a a = b b ", '='), pair("a a", "b b"));
 	EXPECT_EQ(splitFirst("a a = b b = c c\r", '='), pair("a a", "b b = c c"));
 
-	EXPECT_EQ(splitFirst(" apple ", 'w'), pair("apple", ""));
+	std::string apple = " apple ";
+
+	EXPECT_EQ(splitFirst(apple, 'w'), pair("apple", ""));
 }
 
 TEST(StringManip, SplitStrip) {
@@ -56,7 +60,8 @@ TEST(StringManip, SplitStrip) {
 
 	EXPECT_TRUE(t.empty());
 
-	t = splitStrip("apple", ',');
+	std::string apple = "apple";
+	t = splitStrip(apple, ',');
 
 	EXPECT_EQ(t.size(), 1);
 	EXPECT_EQ(t[0], "apple");