ToulligQC version 2.9.1#1718
Merged
Merged
Conversation
… version 2.9.1 added for the versions dropdown entry for ToulligQC. The program specific README.md remains the same; no major syntax changes were seen in the release logs for Toulligqc.
Contributor
|
@staphb-dockerbuilds-diff toulligqc 2.8.4 2.9.1 |
Dockerfile Diff: toulligqcComparing: 2.8.4 -> 2.9.1 --- build-files/toulligqc/2.8.4/Dockerfile 2026-06-26 18:44:13.571581416 +0000
+++ build-files/toulligqc/2.9.1/Dockerfile 2026-06-26 18:44:13.571697112 +0000
@@ -1,12 +1,12 @@
FROM python:3.11.11-slim AS app
-ARG TOULIGQC_VER="2.8.4"
+ARG TOULLIGQC_VER="2.9.1"
# 'LABEL' instructions tag the image with metadata that might be important to the user
LABEL base.image="python:3.11.11-slim"
LABEL dockerfile.version="1"
LABEL software="ToulligQC"
-LABEL software.version="${TOULIGQC_VER}"
+LABEL software.version="${TOULLIGQC_VER}"
LABEL description="QC analyses of Oxford Nanopore runs"
LABEL website="https://github.com/GenomiqueENS/toulligQC"
LABEL license="https://github.com/GenomiqueENS/toulligQC/blob/master/LICENSE.txt"
@@ -22,9 +22,9 @@
bzip2 && \
apt-get autoclean && rm -rf /var/lib/apt/lists/*
-RUN wget -q https://github.com/GenomiqueENS/toulligQC/archive/refs/tags/v${TOULIGQC_VER}.tar.gz && \
- pip install --no-cache-dir v${TOULIGQC_VER}.tar.gz && \
- rm -rf v${TOULIGQC_VER}.tar.gz
+RUN wget -q https://github.com/GenomiqueENS/toulligQC/archive/refs/tags/v${TOULLIGQC_VER}.tar.gz && \
+ pip install --no-cache-dir v${TOULLIGQC_VER}.tar.gz && \
+ rm -rf v${TOULLIGQC_VER}.tar.gz
# 'ENV' instructions set environment variables that persist from the build into the resulting image
# Use for e.g. $PATH and locale settings for compatibility with Singularity
@@ -46,7 +46,7 @@
# A second FROM insruction creates a new stage
FROM app AS test
-ARG TOULIGQC_VER
+ARG TOULLIGQC_VER
# set working directory so that all test inputs & outputs are kept in /test
WORKDIR /test |
Contributor
|
Tests worked |
erinyoung
approved these changes
Jun 26, 2026
erinyoung
left a comment
erinyoung
left a comment
Contributor
There was a problem hiding this comment.
I have no changes to recommend. Let's get this merged and deployed!
| @@ -0,0 +1,65 @@ | |||
| FROM python:3.11.11-slim AS app | |||
|
|
|||
| ARG TOULLIGQC_VER="2.9.1" | |||
Contributor
There was a problem hiding this comment.
The "TOULLIGQC_VER" ARG now has two L's. I think it looks better.
Contributor
|
Thank you for putting this together! You can check the status of the deployment here : https://github.com/StaPH-B/docker-builds/actions/runs/28258993217 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) checklist:
docker build --tag samtools:1.15test --target test docker-builds/build-files/samtools/1.15)docker-builds/build-files/spades/3.12.0/Dockerfile)build-files/shigatyper/2.0.1/test.sh)docker-builds/build-files/spades/3.12.0/README.md)PR description:
Updated Dockerfile to use TOULLIGQC_VER=2.9.1. The main README.md has version 2.9.1 added for the versions dropdown entry for ToulligQC. The program specific README.md remains the same; no major syntax changes were seen in the release logs for Toulligqc. The program license remains GNU GPLv3.