Multiqc 1.35#1722
Merged
Merged
Conversation
…in the test stage. Added python packages installed by pip in the program-specific README.md. Added version 1.35 in the versions dropdown entry for multiqc.
Contributor
|
@staphb-dockerbuilds-diff multiqc 1.34 1.35 |
Dockerfile Diff: multiqcComparing: 1.34 -> 1.35 --- build-files/multiqc/1.34/Dockerfile 2026-06-26 18:48:06.283024933 +0000
+++ build-files/multiqc/1.35/Dockerfile 2026-06-26 18:48:06.283121944 +0000
@@ -1,6 +1,6 @@
FROM ubuntu:noble AS app
-ARG MULTIQC_VER="1.34"
+ARG MULTIQC_VER="1.35"
# metadata
LABEL base.image="ubuntu:noble"
@@ -35,7 +35,7 @@
RUN apt-get update && apt-get install -y git
# to ensure multiqc is in PATH
-RUN multiqc --help
+RUN multiqc --version && multiqc --help
# set working directory so that all test inputs & outputs are kept in /test
RUN mkdir /test |
Contributor
|
Looks like this works. There's something wrong with bclconvert, but I think that's a multiqc thing and not something we could fix in the image. |
erinyoung
approved these changes
Jun 26, 2026
erinyoung
left a comment
Contributor
There was a problem hiding this comment.
I have no changes to recommend. Let's get this merged and deployed!
Contributor
|
The status of the deploy can be found here : https://github.com/StaPH-B/docker-builds/actions/runs/28259612917 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) checklist:
docker build --tag samtools:1.15test --target test docker-builds/build-files/samtools/1.15)docker-builds/build-files/spades/3.12.0/Dockerfile)build-files/shigatyper/2.0.1/test.sh)docker-builds/build-files/spades/3.12.0/README.md)PR Description:
Updated Dockerfile to use MULTIQC_VER=1.35 and added version command in the test stage. Added python packages installed by pip in the program-specific README.md. Added version 1.35 in the versions dropdown entry for multiqc. No changes in the program license were found.