Fix GET detail route when id is array (single vs multi-id)

Use /endpoint/{id}/ only for scalar or one-element id; keep list
endpoint and pass id as query params for multiple ids. Fixes 404
with stackstorm-netbox v3.4.x.

Author: johanek

actions/run.py

@@ -15,15 +15,37 @@ def run(self, endpoint_uri, http_verb, get_detail_route_eligible, fail_non_2xx,
         StackStorm action entry point.
         """
         if http_verb == "get":
-            if kwargs.get("id", False) and get_detail_route_eligible:
-                # modify the `endpoint_uri` to use the detail route
-                endpoint_uri = "{}{}/".format(endpoint_uri, str(kwargs.pop("id")))
-                self.logger.debug(
-                    "endpoint_uri transformed to {} because id was passed".format(endpoint_uri)
-                )
+            if get_detail_route_eligible and "id" in kwargs:
+                id_param = kwargs["id"]
+                # Scalar or 1-elem list -> detail route; multi-elem list -> list filter
+                if isinstance(id_param, (list, tuple)):
+                    if len(id_param) == 1:
+                        detail_id = id_param[0]
+                        kwargs.pop("id")
+                        endpoint_uri = "{}{}/".format(endpoint_uri, str(detail_id))
+                        self.logger.debug(
+                            "endpoint_uri transformed to {} (single id from list)".format(
+                                endpoint_uri
+                            )
+                        )
+                    # else: len > 1 -> keep id in kwargs for list filter, no endpoint change
+                else:
+                    # scalar id -> detail route
+                    detail_id = kwargs.pop("id")
+                    endpoint_uri = "{}{}/".format(endpoint_uri, str(detail_id))
+                    self.logger.debug(
+                        "endpoint_uri transformed to {} because id was passed".format(
+                            endpoint_uri
+                        )
+                    )
 
-            if kwargs.get("save_in_key_store") and not kwargs.get("save_in_key_store_key_name"):
-                return (False, "save_in_key_store_key_name MUST be used with save_in_key_store!")
+            if kwargs.get("save_in_key_store") and not kwargs.get(
+                "save_in_key_store_key_name"
+            ):
+                return (
+                    False,
+                    "save_in_key_store_key_name MUST be used with save_in_key_store!",
+                )
 
             result = self.make_request(endpoint_uri, http_verb, **kwargs)
 
@@ -38,7 +60,9 @@ def run(self, endpoint_uri, http_verb, get_detail_route_eligible, fail_non_2xx,
                 key_name = kwargs["save_in_key_store_key_name"]
                 client.keys.update(
                     KeyValuePair(
-                        name=key_name, value=json.dumps(result), ttl=kwargs["save_in_key_store_ttl"]
+                        name=key_name,
+                        value=json.dumps(result),
+                        ttl=kwargs["save_in_key_store_ttl"],
                     )
                 )