Update pytest-cov version requirement and fix other build failures (#6363)

* Update pytest-cov version requirement

While Stackstorm supports python 3.8 (rocky8), pytest-cov needs to be downgraded to 5.0.0

* Update changelog

* Pin DOCKER_API_VERSION

* Pin pynacl, newer versions cause build conflicts

* Undo local compatability changes

* Note in changelog about pinning the DOCKER_API_VERSION

* Regen pants lockfile

Author: skiedude

.circleci/config.yml

@@ -123,6 +123,7 @@ jobs:
       - ST2_CHECKOUT: 0
       - ST2_GITDIR: /tmp/st2
       - BASH_ENV: ~/.buildenv
+      - DOCKER_API_VERSION: "1.43"
     steps:
       - checkout
       - run:

CHANGELOG.rst

@@ -71,7 +71,8 @@ Changed
 
 * Switched tests from `nosetest` to `pytest`. `st2-run-pack-tests` also uses pytest.
   So, all pack tests must be runnable by `pytest`, which may require migration. #6291
-  Contributed by @nzlosh, @FileMagic, @guzzijones, and @cognifloyd.
+  Contributed by @nzlosh, @FileMagic, @guzzijones, and @cognifloyd. Pinned pytest-cov
+  to 5.0.0 for python 3.8 support.
 
 * Migrated github actions from image ubunutu 20.04 with python 3.8.10 to image ubuntu 22.04 with python 3.8.12. #6301
   Contributed by @nzlosh
@@ -126,6 +127,9 @@ Added
 * Cherry-pick changes to runners.sh from st2-packages git repo. #6302
   Cherry-picked by @cognifloyd
 
+* Pinned DOCKER_API_VERSION in the circleci build to make sure the docker-cli api version does not exceed what
+  `cicrleci docker24 <https://circleci.com/docs/guides/execution-managed/building-docker-images/>`_ supports
+
 3.8.1 - December 13, 2023
 -------------------------
 Fixed

fixed-requirements.txt

@@ -89,3 +89,4 @@ python-dateutil==2.9.0.post0
 python-statsd==2.1.0
 orjson==3.10.15
 zipp==3.20.2
+pynacl==1.6.0

lockfiles/st2.lock

@@ -46,6 +46,7 @@ pyOpenSSL<25.2
 pygments==2.19.2
 pyinotify==0.9.6 ; platform_system=="Linux"
 pymongo==4.6.3
+pynacl==1.6.0
 pyparsing==3.1.4
 pyrabbit
 pysocks

requirements.txt

@@ -38,10 +38,11 @@ PACK_TEST_PYTHON_DEPENDENCIES_NAMES=(
     'mock'
     'pytest-cov'
 )
+# While Stackstorm supports Python 3.8, pytest-cov must be run at a lower version
 PACK_TEST_PYTHON_DEPENDENCIES_VERSIONS=(
     '>7'
     '>=4.0.3'
-    '>=6.1.1'
+    '>=5.0.0'
 )
 
 VIRTUALENVS_DIR="/tmp/st2-pack-tests-virtualenvs"

st2common/bin/st2-run-pack-tests

@@ -16,6 +16,8 @@ orquesta@ git+https://github.com/StackStorm/orquesta.git@5ba1467614b2ef8b4709b2c
 st2-rbac-backend@ git+https://github.com/StackStorm/st2-rbac-backend.git@master
 oslo.config
 paramiko
+# pynacl is used by paramiko and version needs to be pinned
+pynacl
 pyyaml
 pymongo
 # used for optional network level compression for mongodb

st2common/in-requirements.txt

@@ -32,6 +32,7 @@ oslo.config==9.6.0
 paramiko==3.5.1
 pyOpenSSL<25.2
 pymongo==4.6.3
+pynacl==1.6.0
 python-dateutil==2.9.0.post0
 python-statsd==2.1.0
 pyyaml==6.0.3