Skip to content

Commit 2df605a

Browse files
authored
Merge pull request #75 from Staffbase/various-improvements
2 parents 0619d50 + ef96d46 commit 2df605a

File tree

7 files changed

+5876
-6320
lines changed

7 files changed

+5876
-6320
lines changed

.github/workflows/integration.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,4 +39,3 @@ jobs:
3939
with:
4040
token: ${{ secrets.DEV_PUSH_TOKEN }}
4141
user: ${{ secrets.DEV_PUSH_USER }}
42-
optimistic: true

README.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ You can find all input options which are available for this action.
4444
| base | This is the base branch. The merge history originates from this branch. | main |
4545
| branch | The branch the action will merge the pull requests to. | dev |
4646
| label | The label where the action will be triggered. | dev |
47-
| optimistic | Whether the action should perform an "optimistic" merge of the given Pull requests. If this is set to false, the dev branch is only built if there are zero merge conflicts between branches. | false |
4847
| comments | The GitHub action creates a new comment inside every pull request. | false |
4948
| success_comment | Comment string that will be shown in the pull request on success. Only necessary if `comments` is enabled. | '' |
5049
| failure_comment | Comment string that will be shown in the pull request on failure. Only necessary if `comments` is enabled. | '' |
@@ -63,7 +62,6 @@ Always create the dev branch.
6362
uses: Staffbase/[email protected]
6463
with:
6564
token: ${{ secrets.PERSONAL_ACCESS_TOKEN }}
66-
optimistic: true
6765
```
6866

6967
Add a status comment if the merge was successful or failed.

__test__/autodev.test.ts

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,7 @@ describe('autodev', () => {
4848
jest
4949
.spyOn(core, 'getInput')
5050
.mockImplementation(
51-
input =>
52-
({optimistic: 'true', token: 'token', base: 'main'}[input] || '')
51+
input => ({token: 'token', base: 'main'}[input] || '')
5352
)
5453

5554
await autoDev()
@@ -66,10 +65,7 @@ The following branches have been merged:
6665
jest
6766
.spyOn(core, 'getInput')
6867
.mockImplementation(
69-
input =>
70-
({optimistic: 'true', token: 'token', base: 'main', comments: 'true'}[
71-
input
72-
] || '')
68+
input => ({token: 'token', base: 'main', comments: 'true'}[input] || '')
7369
)
7470

7571
await autoDev()
@@ -81,10 +77,7 @@ The following branches have been merged:
8177
jest
8278
.spyOn(core, 'getInput')
8379
.mockImplementation(
84-
input =>
85-
({optimistic: 'true', token: 'token', base: 'main', labels: 'true'}[
86-
input
87-
] || '')
80+
input => ({token: 'token', base: 'main', labels: 'true'}[input] || '')
8881
)
8982

9083
await autoDev()

action.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,6 @@ inputs:
2222
required: false
2323
default: 'dev'
2424
description: 'The branch the action will merge the Pull Requests to.'
25-
optimistic:
26-
required: false
27-
default: 'true'
28-
description: 'Ignores conflicts between branches and merges the remaining branches.'
2925
comments:
3026
required: false
3127
default: 'false'

0 commit comments

Comments
 (0)