refactor: fix linter issues

Author: Ninerian

.php-cs-fixer.dist.php

@@ -6,6 +6,7 @@
 
 return (new PhpCsFixer\Config())
     ->setRules([
+        '@PHP8x4Migration' => true,
         '@PER-CS' => true,
         'array_syntax' => ['syntax' => 'short'],
         'declare_strict_types' => true,

src/SSOTokenGenerator.php

@@ -35,7 +35,7 @@ class SSOTokenGenerator
      *
      * @return string Encoded token.
      */
-    public static function createSignedTokenFromData(string $privateKey, array $tokenData, Signer $signer = null): string
+    public static function createSignedTokenFromData(string $privateKey, array $tokenData, ?Signer $signer = null): string
     {
 
         $config = Configuration::forSymmetricSigner($signer ?: new Sha256(), InMemory::plainText($privateKey));

src/SessionHandling/SessionHandlerTrait.php

@@ -116,7 +116,7 @@ public function setSessionVar($key, $val, ?string $parentKey = null): void
      * @param String|null $sessionId
      * @return bool true on success or false on failure.
      */
-    public function destroySession(String $sessionId = null): bool
+    public function destroySession(?String $sessionId = null): bool
     {
         $sessionId = $sessionId ?: $this->sessionId;
 

test/PluginSessionTest.php

@@ -69,7 +69,7 @@ public function tearDown(): void
      * @param string|null $queryParamJwt JWT query param emulation
      * @param boolean $clearSession optionally clear out the $_SESSION array
      */
-    private function setupEnvironment(string $queryParamPid = null, string $queryParamJwt = null, bool $clearSession = true)
+    private function setupEnvironment(?string $queryParamPid = null, ?string $queryParamJwt = null, bool $clearSession = true)
     {
 
         $_REQUEST[PluginSession::QUERY_PARAM_PID] = $queryParamPid;

test/SSOTestData.php

@@ -49,9 +49,9 @@ class SSOTestData
      */
     public static function getTokenData(?string $exp = '10 minutes', ?string $npf = '-1 minutes', ?string $iat = 'now'): array
     {
-        $exp = $exp ?? '10 minutes';
-        $npf = $npf ?? '-1 minutes';
-        $iat = $iat ?? 'now';
+        $exp ??= '10 minutes';
+        $npf ??= '-1 minutes';
+        $iat ??= 'now';
 
         $date = new DateTimeImmutable($iat);