Commit 1bc4f77
committed
[Enhancement] Upgrade Apache Arrow thirdparty to 24.0.0
Bump the C++ thirdparty Arrow from 19.0.1 to 24.0.0. Several dependency
adjustments are required for Arrow 24 to build against StarRocks thirdparty:
- Arrow 24 requires xsimd >= 14.0.0; bump xsimd 13.2.0 -> 14.0.0.
- Arrow links each dependency as shared by default; StarRocks builds
thrift static-only (libthrift.a), so FindThriftAlt could not locate the
library and fell back to bundled thrift (0.22.0), whose pinned checksum
does not match StarRocks thrift 0.23.0. Add -DARROW_THRIFT_USE_SHARED=OFF
(and use the correctly-cased -DThrift_SOURCE=SYSTEM) to use system thrift.
- Arrow 24 pins zstd 1.5.7 to the official release tarball; StarRocks fed
its GitHub archive tarball of the same version (different bytes), failing
Arrow's bundled-zstd checksum. Switch ZSTD_DOWNLOAD to the release tarball.
- Arrow 24 public headers use std::span (C++20). benchgen includes Arrow
headers but hard-set CMAKE_CXX_STANDARD 17; patch it to C++20 and add
-fno-sized-deallocation (required by StarRocks under C++20+).
- Regenerate nix/thirdparty-archives.nix for the arrow/xsimd/zstd bumps.
Verified: arrow 24.0.0 configures + compiles (libarrow.a, libparquet.a) and
benchgen builds against it (thrift 0.23.0, xsimd 14.0.0, bundled zstd 1.5.7).1 parent f7a5783 commit 1bc4f77
3 files changed
Lines changed: 31 additions & 28 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| |||
349 | 349 | | |
350 | 350 | | |
351 | 351 | | |
352 | | - | |
353 | | - | |
354 | | - | |
355 | | - | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
356 | 356 | | |
357 | 357 | | |
358 | 358 | | |
| |||
365 | 365 | | |
366 | 366 | | |
367 | 367 | | |
368 | | - | |
369 | | - | |
370 | | - | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
371 | 371 | | |
372 | 372 | | |
373 | 373 | | |
| |||
486 | 486 | | |
487 | 487 | | |
488 | 488 | | |
489 | | - | |
| 489 | + | |
490 | 490 | | |
491 | 491 | | |
492 | 492 | | |
| |||
521 | 521 | | |
522 | 522 | | |
523 | 523 | | |
524 | | - | |
| 524 | + | |
525 | 525 | | |
526 | 526 | | |
527 | 527 | | |
| |||
557 | 557 | | |
558 | 558 | | |
559 | 559 | | |
560 | | - | |
| 560 | + | |
561 | 561 | | |
562 | 562 | | |
563 | 563 | | |
| |||
590 | 590 | | |
591 | 591 | | |
592 | 592 | | |
593 | | - | |
| 593 | + | |
594 | 594 | | |
595 | 595 | | |
596 | 596 | | |
| |||
626 | 626 | | |
627 | 627 | | |
628 | 628 | | |
629 | | - | |
| 629 | + | |
630 | 630 | | |
631 | 631 | | |
632 | 632 | | |
| |||
659 | 659 | | |
660 | 660 | | |
661 | 661 | | |
662 | | - | |
| 662 | + | |
663 | 663 | | |
664 | 664 | | |
665 | 665 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
964 | 964 | | |
965 | 965 | | |
966 | 966 | | |
967 | | - | |
| 967 | + | |
| 968 | + | |
968 | 969 | | |
969 | 970 | | |
970 | 971 | | |
| |||
1726 | 1727 | | |
1727 | 1728 | | |
1728 | 1729 | | |
| 1730 | + | |
1729 | 1731 | | |
1730 | 1732 | | |
1731 | 1733 | | |
| 1734 | + | |
1732 | 1735 | | |
1733 | 1736 | | |
1734 | 1737 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
229 | 229 | | |
230 | 230 | | |
231 | 231 | | |
232 | | - | |
| 232 | + | |
233 | 233 | | |
234 | 234 | | |
235 | | - | |
| 235 | + | |
236 | 236 | | |
237 | 237 | | |
238 | 238 | | |
| |||
247 | 247 | | |
248 | 248 | | |
249 | 249 | | |
250 | | - | |
251 | | - | |
252 | | - | |
253 | | - | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
254 | 254 | | |
255 | 255 | | |
256 | 256 | | |
| |||
447 | 447 | | |
448 | 448 | | |
449 | 449 | | |
450 | | - | |
451 | | - | |
452 | | - | |
453 | | - | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
454 | 454 | | |
455 | 455 | | |
456 | 456 | | |
| |||
0 commit comments