[BugFix] Fix the bug of json parse in get fe metrics (backport #68164) (#68176)

Signed-off-by: trueeyu <lxhhust350@qq.com>
Co-authored-by: trueeyu <lxhhust350@qq.com>

Author: mergify[bot]

be/src/exec/schema_scanner/schema_fe_metrics_scanner.cpp

@@ -57,17 +57,21 @@ Status SchemaFeMetricsScanner::_get_fe_metrics(RuntimeState* state) {
 
         simdjson::ondemand::parser parser;
         simdjson::padded_string json_metrics(metrics);
-        for (auto json_metric : parser.iterate(json_metrics)) {
-            auto& info = _infos.emplace_back();
-            info.id = frontend.id;
-            info.value = static_cast<int64_t>(double(json_metric["value"]));
-            auto n = std::string_view(json_metric["tags"]["metric"]);
-            info.name = std::string(n.begin(), n.end());
-            std::ostringstream oss;
-            oss << simdjson::to_json_string(json_metric["tags"]);
-            info.labels = oss.str();
-            VLOG(2) << "id: " << info.id << "name: " << info.name << ", labels: " << info.labels
-                    << ", value: " << info.value;
+        try {
+            for (auto json_metric : parser.iterate(json_metrics)) {
+                auto& info = _infos.emplace_back();
+                info.id = frontend.id;
+                info.value = static_cast<int64_t>(double(json_metric["value"]));
+                auto n = std::string_view(json_metric["tags"]["metric"]);
+                info.name = std::string(n.begin(), n.end());
+                std::ostringstream oss;
+                oss << simdjson::to_json_string(json_metric["tags"]);
+                info.labels = oss.str();
+                VLOG(2) << "id: " << info.id << "name: " << info.name << ", labels: " << info.labels
+                        << ", value: " << info.value;
+            }
+        } catch (const simdjson::simdjson_error& e) {
+            return Status::InternalError("Parse the result of fe metrics failed: " + std::string(e.what()));
         }
     }
 

be/test/CMakeLists.txt

@@ -72,6 +72,7 @@ set(EXEC_FILES
         ./exec/query_cache/query_cache_test.cpp
         ./exec/query_cache/transform_operator.cpp
         ./exec/schema_columns_scanner_test.cpp
+        ./exec/schema_scanner/schema_fe_metrics_scanner_test.cpp
         ./exec/sink/connector_sink_operator_test.cpp
         ./exec/sink/sink_io_buffer_test.cpp
         ./exec/stream/mem_state_table_test.cpp

be/test/exec/schema_scanner/schema_fe_metrics_scanner_test.cpp

@@ -0,0 +1,81 @@
+// Copyright 2021-present StarRocks, Inc. All rights reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     https://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "exec/schema_scanner/schema_fe_metrics_scanner.h"
+
+#include <gtest/gtest.h>
+
+#include "http/ev_http_server.h"
+#include "http/http_channel.h"
+#include "http/http_client.h"
+#include "http/http_handler.h"
+#include "http/http_request.h"
+#include "runtime/runtime_state.h"
+#include "testutil/assert.h"
+
+namespace starrocks {
+
+class SchemaFeMetricsScannerGetHandler : public HttpHandler {
+public:
+    SchemaFeMetricsScannerGetHandler() = default;
+    void handle(HttpRequest* req) override {
+        std::string resp = R"([{"tags":{"metric":"jvm_young_gc","type":"count"},"unit":"nounit","value:741}])";
+        HttpChannel::send_reply(req, resp);
+    }
+};
+
+class SchemaFeMetricsScannerTest : public testing::Test {
+public:
+    SchemaFeMetricsScannerTest() {}
+    ~SchemaFeMetricsScannerTest() override = default;
+
+    void SetUp() override {
+        _server = std::make_unique<EvHttpServer>(0);
+        _server->register_handler(GET, "/metrics", &_handler);
+        ASSERT_OK(_server->start());
+        _port = _server->get_real_port();
+        ASSERT_NE(0, _port);
+        _hostname = "http://127.0.0.1:" + std::to_string(_port);
+    }
+
+    void TearDown() override {
+        _server->stop();
+        _server->join();
+    }
+
+protected:
+    SchemaFeMetricsScannerGetHandler _handler;
+    std::unique_ptr<EvHttpServer> _server = nullptr;
+    int _port = 0;
+    std::string _hostname = "";
+    ObjectPool _pool;
+};
+
+TEST_F(SchemaFeMetricsScannerTest, test_partial_json) {
+    RuntimeState state;
+    TFrontend frontend;
+    frontend.__set_ip("127.0.0.1");
+    frontend.__set_id("1");
+    frontend.__set_http_port(_port);
+
+    SchemaScannerParam param;
+    param.frontends.push_back(std::move(frontend));
+
+    SchemaFeMetricsScanner scanner;
+    ASSERT_OK(scanner.init(&param, &_pool));
+    auto st = scanner.start(&state);
+    ASSERT_ERROR(st);
+    ASSERT_TRUE(st.message().find("A string is opened") != std::string::npos);
+}
+} // namespace starrocks

be/test/http/http_client_test.cpp

@@ -26,6 +26,7 @@
 #include "http/http_channel.h"
 #include "http/http_handler.h"
 #include "http/http_request.h"
+#include "testutil/assert.h"
 
 namespace starrocks {
 
@@ -85,7 +86,13 @@ class HttpClientTest : public testing::Test {
         s_server->register_handler(GET, "/simple_get", &s_simple_get_handler);
         s_server->register_handler(HEAD, "/simple_get", &s_simple_get_handler);
         s_server->register_handler(POST, "/simple_post", &s_simple_post_handler);
+<<<<<<< HEAD
         s_server->start();
+=======
+        s_server->register_handler(GET, "/header_test", &s_header_handler);
+        s_server->register_handler(GET, "/multi_header_test", &s_multi_header_handler);
+        ASSERT_OK(s_server->start());
+>>>>>>> d44be25275 ([BugFix] Fix the bug of json parse in get fe metrics (#68164))
         real_port = s_server->get_real_port();
         ASSERT_NE(0, real_port);
         hostname = "http://127.0.0.1:" + std::to_string(real_port);