fix per comment

Signed-off-by: yan zhang <[email protected]>

Author: dirtysalt

be/src/util/variant.cpp

@@ -143,6 +143,7 @@ Status VariantMetadata::_build_lookup_index() const {
             dict_strings.emplace_back(field_key);                                                                  \
             offset = next_offset;                                                                                  \
         }                                                                                                          \
+        _lookup_index.has_built = true;                                                                            \
         if (string_base + offset > _metadata.data() + _metadata.size()) {                                          \
             return Status::VariantError("Variant string out of range");                                            \
         }                                                                                                          \
@@ -155,8 +156,6 @@ Status VariantMetadata::_build_lookup_index() const {
         DECODE_VALUE_OFFSET(3);
         DECODE_VALUE_OFFSET(4);
     }
-
-    _lookup_index.has_built = true;
     return Status::OK();
 }
 

be/src/util/variant_converter.cpp

@@ -41,7 +41,7 @@ Status cast_variant_to_bool(const VariantRowValue& variant, ColumnBuilder<TYPE_B
         if (parsed != StringParser::PARSE_SUCCESS) {
             const bool casted = StringParser::string_to_bool(str_value, len, &parsed);
             if (parsed != StringParser::PARSE_SUCCESS) {
-                return Status::VariantError(fmt::format("Failed to cast string '{}' to BOOLEAN", str_value));
+                return Status::VariantError(fmt::format("Failed to cast string '{}' to BOOLEAN", str));
             }
             result.append(casted);
         } else {