[BugFix] Fix query profile API to return a unified JSON format (#67077)

Signed-off-by: zhaohehuhu <[email protected]>

Author: zhaohehuhu

fe/fe-core/src/main/java/com/starrocks/http/rest/v2/ProfileActionV2.java

@@ -14,12 +14,14 @@
 
 package com.starrocks.http.rest.v2;
 
+import com.google.gson.reflect.TypeToken;
 import com.starrocks.common.util.ProfileManager;
 import com.starrocks.http.ActionController;
 import com.starrocks.http.BaseRequest;
 import com.starrocks.http.BaseResponse;
 import com.starrocks.http.IllegalArgException;
 import com.starrocks.http.rest.RestBaseAction;
+import com.starrocks.persist.gson.GsonUtils;
 import io.netty.handler.codec.http.HttpMethod;
 import io.netty.handler.codec.http.HttpResponseStatus;
 
@@ -66,10 +68,18 @@ protected void executeWithoutPassword(BaseRequest request, BaseResponse response
             // If the query profile is not found in the local fe's ProfileManager,
             // we will query other frontend nodes to get the query profile.
             String queryPath = String.format(QUERY_PLAN_URI, queryId);
-            List<String> profileList = fetchResultFromOtherFrontendNodes(queryPath, authorization, HttpMethod.GET, false);
+            List<String> profileList =
+                    fetchResultFromOtherFrontendNodes(queryPath, authorization, HttpMethod.GET, false);
             for (String profile : profileList) {
                 if (profile != null) {
-                    sendSuccessResponse(response, profile, request);
+                    RestBaseResultV2<String> queryProfileResult = GsonUtils.GSON.fromJson(
+                            profile,
+                            new TypeToken<RestBaseResultV2<String>>() {
+                            }.getType());
+                    if (queryProfileResult == null || queryProfileResult.getResult() == null) {
+                        continue;
+                    }
+                    sendSuccessResponse(response, queryProfileResult.getResult(), request);
                     return;
                 }
             }

fe/fe-core/src/test/java/com/starrocks/http/rest/v2/ProfileActionV2Test.java

@@ -14,11 +14,16 @@
 
 package com.starrocks.http.rest.v2;
 
+import com.google.common.reflect.TypeToken;
+import com.google.gson.JsonElement;
+import com.google.gson.JsonSyntaxException;
 import com.starrocks.common.Pair;
 import com.starrocks.common.util.ProfileManager;
 import com.starrocks.ha.FrontendNodeType;
 import com.starrocks.http.StarRocksHttpTestCase;
+import com.starrocks.http.rest.ActionStatus;
 import com.starrocks.http.rest.RestBaseAction;
+import com.starrocks.persist.gson.GsonUtils;
 import com.starrocks.server.GlobalStateMgr;
 import com.starrocks.system.Frontend;
 import mockit.Expectations;
@@ -164,7 +169,15 @@ public String getProfile(String queryId) {
                 .build();
         Response response = networkClient.newCall(request).execute();
         String respStr = response.body().string();
-        Assertions.assertEquals(response.code(), 200);
-        Assertions.assertTrue(respStr.contains("Query ID: eaff21d2-3734-11ee-909f-8e20563011de"));
+        RestBaseResultV2<String> queryProfileResult = GsonUtils.GSON.fromJson(
+                respStr,
+                new TypeToken<RestBaseResultV2<String>>() {
+                }.getType());
+        Assertions.assertEquals(queryProfileResult.getStatus(), ActionStatus.OK);
+        Assertions.assertTrue(queryProfileResult.getResult().contains("Query ID: eaff21d2-3734-11ee-909f-8e20563011de"));
+        Assertions.assertThrows(
+                JsonSyntaxException.class,
+                () -> GsonUtils.GSON.fromJson(queryProfileResult.getResult(), JsonElement.class),
+                "Query profile should be plain text, not a JSON object");
     }
 }