Commit 6b86626
committed
[Enhancement] Mirror Arrow 24 thirdparty fixes to the Darwin builder
The Linux build-thirdparty.sh Arrow 24 adaptations were not applied to the
macOS builder, but vars.sh (Arrow 24) and be/CMakeLists.txt (which now links
arrow_testing for all platforms) are shared. Without this, macOS installs no
libarrow_testing.a and BE/test fails to link with -larrow_testing not found;
the Arrow build itself would also fail earlier on thrift/C++20.
Mirror the fixes in build-thirdparty-darwin.sh:
- arrow: -DARROW_TESTING=ON (system GTest) so libarrow_testing.a is installed.
- arrow: -DARROW_THRIFT_USE_SHARED=OFF and correctly-cased -DThrift_SOURCE=SYSTEM.
- arrow: -fno-sized-deallocation (Arrow 24 forces C++20).
- benchgen: bump CMAKE_CXX_STANDARD 17 -> 20 and add -fno-sized-deallocation.1 parent 9f8aea5 commit 6b86626
1 file changed
Lines changed: 8 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2019 | 2019 | | |
2020 | 2020 | | |
2021 | 2021 | | |
| 2022 | + | |
| 2023 | + | |
| 2024 | + | |
| 2025 | + | |
2022 | 2026 | | |
2023 | 2027 | | |
2024 | 2028 | | |
| |||
2082 | 2086 | | |
2083 | 2087 | | |
2084 | 2088 | | |
2085 | | - | |
| 2089 | + | |
| 2090 | + | |
2086 | 2091 | | |
2087 | 2092 | | |
2088 | 2093 | | |
| |||
2908 | 2913 | | |
2909 | 2914 | | |
2910 | 2915 | | |
| 2916 | + | |
2911 | 2917 | | |
2912 | 2918 | | |
2913 | 2919 | | |
2914 | 2920 | | |
| 2921 | + | |
2915 | 2922 | | |
2916 | 2923 | | |
2917 | 2924 | | |
| |||
0 commit comments