[BugFix] Surface isolation property in SHOW FUNCTIONS output (backport #75255) (backport #75276) (#75278)

Signed-off-by: wyb <wybb86@gmail.com>
Co-authored-by: wyb <wybb86@gmail.com>

Author: mergify[bot]

fe/fe-core/src/main/java/com/starrocks/catalog/AggregateFunction.java

@@ -470,6 +470,10 @@ public String getProperties() {
         properties.put(CreateFunctionStmt.MD5_CHECKSUM, checksum);
         properties.put(CreateFunctionStmt.SYMBOL_KEY, symbolName == null ? "" : symbolName);
         properties.put(CreateFunctionStmt.TYPE_KEY, getBinaryType().name());
+        // isolationType defaults to true (isolated); surface it so users can tell whether the
+        // function was created with isolation = "shared".
+        properties.put(CreateFunctionStmt.ISOLATION_KEY,
+                isolationType ? CreateFunctionStmt.ISOLATION_ISOLATED : CreateFunctionStmt.ISOLATION_SHARED);
         return new Gson().toJson(properties);
     }
 

fe/fe-core/src/main/java/com/starrocks/catalog/ScalarFunction.java

@@ -298,6 +298,10 @@ public String getProperties() {
         properties.put(CreateFunctionStmt.MD5_CHECKSUM, checksum);
         properties.put(CreateFunctionStmt.SYMBOL_KEY, getSymbolName());
         properties.put(CreateFunctionStmt.TYPE_KEY, getBinaryType().name());
+        // isolationType defaults to true (isolated); surface it so users can tell whether the
+        // function was created with isolation = "shared".
+        properties.put(CreateFunctionStmt.ISOLATION_KEY,
+                isolationType ? CreateFunctionStmt.ISOLATION_ISOLATED : CreateFunctionStmt.ISOLATION_SHARED);
         return new Gson().toJson(properties);
     }
 

fe/fe-core/src/main/java/com/starrocks/sql/analyzer/CreateFunctionAnalyzer.java

@@ -606,7 +606,7 @@ private void analyzePython(CreateFunctionStmt stmt) {
                 objectFile(objectFile).
                 inputType(inputType).
                 symbolName(symbol).
-                isolation(!"shared".equalsIgnoreCase(isolation)).
+                isolation(!CreateFunctionStmt.ISOLATION_SHARED.equalsIgnoreCase(isolation)).
                 content(content);
         ScalarFunction function = scalarFunctionBuilder.build();
         function.setChecksum(checksum);

fe/fe-core/src/main/java/com/starrocks/sql/ast/CreateFunctionStmt.java

@@ -33,6 +33,8 @@ public class CreateFunctionStmt extends DdlStmt {
     public static final String MD5_CHECKSUM = "md5";
     public static final String TYPE_KEY = "type";
     public static final String ISOLATION_KEY = "isolation";
+    public static final String ISOLATION_SHARED = "shared";
+    public static final String ISOLATION_ISOLATED = "isolated";
     public static final String TYPE_STARROCKS_JAR = "StarrocksJar";
     public static final String TYPE_STARROCKS_PYTHON = "Python";
     public static final String EVAL_METHOD_NAME = "evaluate";

fe/fe-core/src/test/java/com/starrocks/analysis/ShowFunctionsIsolationTest.java

@@ -0,0 +1,67 @@
+// Copyright 2021-present StarRocks, Inc. All rights reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     https://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package com.starrocks.analysis;
+
+import com.google.common.collect.Lists;
+import com.starrocks.catalog.AggregateFunction;
+import com.starrocks.catalog.ScalarFunction;
+import com.starrocks.catalog.Type;
+import com.starrocks.thrift.TFunctionBinaryType;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
+
+// Regression coverage for the Properties shown by SHOW [FULL] FUNCTIONS (Function#getProperties)
+// exposing the "isolation" entry so users can tell whether a UDF/UDAF was created with
+// isolation = "shared". isolationType == false means shared; true (default) means isolated.
+public class ShowFunctionsIsolationTest {
+
+    private static ScalarFunction scalarUdf(boolean isolationType) {
+        Type[] args = new Type[] {Type.INT};
+        return ScalarFunction.createUdf(new FunctionName("db", "my_udf"), args, Type.INT,
+                false, TFunctionBinaryType.SRJAR, "objectFile", "symbol", "", "", isolationType);
+    }
+
+    private static AggregateFunction aggregateUdf(boolean isolationType) {
+        AggregateFunction fn = new AggregateFunction(new FunctionName("db", "my_agg"),
+                Lists.newArrayList(Type.INT), Type.INT, Type.INT, false);
+        fn.setBinaryType(TFunctionBinaryType.SRJAR);
+        fn.setIsolationType(isolationType);
+        return fn;
+    }
+
+    @Test
+    public void testSharedScalarFunctionShowsIsolation() {
+        String props = scalarUdf(false).getProperties();
+        Assertions.assertTrue(props.contains("\"isolation\":\"shared\""), props);
+    }
+
+    @Test
+    public void testIsolatedScalarFunctionShowsIsolation() {
+        String props = scalarUdf(true).getProperties();
+        Assertions.assertTrue(props.contains("\"isolation\":\"isolated\""), props);
+    }
+
+    @Test
+    public void testSharedAggregateFunctionShowsIsolation() {
+        String props = aggregateUdf(false).getProperties();
+        Assertions.assertTrue(props.contains("\"isolation\":\"shared\""), props);
+    }
+
+    @Test
+    public void testIsolatedAggregateFunctionShowsIsolation() {
+        String props = aggregateUdf(true).getProperties();
+        Assertions.assertTrue(props.contains("\"isolation\":\"isolated\""), props);
+    }
+}