Skip to content

Commit f345716

Browse files
committed
fix ut
Signed-off-by: yan zhang <[email protected]>
1 parent b65ead0 commit f345716

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

be/test/formats/parquet/parquet_variant_test.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -401,7 +401,7 @@ TEST_F(ParquetVariantTest, ObjectPrimitive) {
401401
EXPECT_EQ(VariantType::STRING, timestamp_field.type());
402402
EXPECT_EQ("2025-04-16T12:34:56.78", *timestamp_field.get_string());
403403

404-
EXPECT_ERROR(variant.get_object_by_key(metadata, "unknow"));
404+
EXPECT_EQ(variant.get_object_by_key(metadata, "unknow")->type(), VariantType::NULL_TYPE);
405405
}
406406

407407
TEST_F(ParquetVariantTest, ObjectEmpty) {
@@ -411,7 +411,8 @@ TEST_F(ParquetVariantTest, ObjectEmpty) {
411411
EXPECT_EQ(VariantType::OBJECT, variant.type());
412412
EXPECT_EQ(0, *variant.num_elements());
413413

414-
EXPECT_ERROR(variant.get_object_by_key(metadata, "key"));
414+
EXPECT_EQ(variant.get_object_by_key(metadata, "key")->type(), VariantType::NULL_TYPE);
415+
EXPECT_ERROR(variant.get_element_at_index(metadata, 0));
415416
}
416417

417418
TEST_F(ParquetVariantTest, ArrayPrimitive) {
@@ -445,7 +446,7 @@ TEST_F(ParquetVariantTest, ArrayEmpty) {
445446
EXPECT_EQ(VariantType::ARRAY, variant.type());
446447
EXPECT_EQ(0, *variant.num_elements());
447448

448-
EXPECT_ERROR(variant.get_element_at_index(metadata, 0));
449+
EXPECT_EQ(variant.get_element_at_index(metadata, 0)->type(), VariantType::NULL_TYPE);
449450
EXPECT_ERROR(variant.get_object_by_key(metadata, "key"));
450451
}
451452

test/sql/test_iceberg/R/test_iceberg_variant_query_0

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ ORDER BY case_id;
150150
-- result:
151151
1 alpha 10 hot Decimal4 Decimal4 1.50000000 3.50000000 1.5 3.5
152152
2 beta 0 cold Decimal4 Decimal4 -0.50000000 0.50000000 -0.5 0.5
153-
3 None None None None None None None None None
153+
3 None None None Null Null None None None None
154154
4 delta 99 warm Decimal4 Decimal4 0E-8 2.00000000 0.0 2.0
155155
-- !result
156156
SELECT 'Query 3: Use variant_query + CAST to coerce nested payloads into primitives.' AS case_description;

0 commit comments

Comments
 (0)