Skip to content

Commit f45caf2

Browse files
Fix Test
Signed-off-by: alvin-phoenix-ai <alvin.zhao@phoenixdata.ai>
1 parent eb0cb7a commit f45caf2

1 file changed

Lines changed: 18 additions & 9 deletions

File tree

be/CMakeLists.txt

Lines changed: 18 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -876,6 +876,17 @@ if (WITH_GCOV)
876876
set(STARROCKS_LINK_LIBS ${STARROCKS_LINK_LIBS} --coverage)
877877
endif()
878878

879+
# Broad test and benchmark executables directly exercise concrete connector implementations.
880+
# Keep these explicit: PRIVATE dependencies of shared BE modules are intentionally not propagated
881+
# when ENABLE_MULTI_DYNAMIC_LIBS is enabled.
882+
set (DIRECT_CONNECTOR_LINK_LIBS
883+
Connector
884+
ConnectorLake
885+
ConnectorFile
886+
ConnectorHive
887+
ConnectorIceberg
888+
)
889+
879890
# Set libraries for test. TestUtil is UT-only and intentionally stays out of
880891
# STARROCKS_LINK_LIBS so normal BE, format-lib, and benchmark builds do not
881892
# compile or link test helper code.
@@ -884,20 +895,18 @@ set (TEST_LINK_LIBS
884895
${STARROCKS_LINK_LIBS}
885896
TestUtil
886897
${WL_START_GROUP}
887-
# Broad test object libraries directly exercise concrete connector implementations.
888-
# Keep these as explicit test dependencies: PRIVATE dependencies of shared BE modules
889-
# are intentionally not propagated when ENABLE_MULTI_DYNAMIC_LIBS is enabled.
890-
Connector
891-
ConnectorLake
892-
ConnectorFile
893-
ConnectorHive
894-
ConnectorIceberg
898+
${DIRECT_CONNECTOR_LINK_LIBS}
895899
gmock
896900
gtest
897901
${WL_END_GROUP}
898902
)
899903

900-
set (BENCH_LINK_LIBS ${STARROCKS_LINK_LIBS})
904+
set (BENCH_LINK_LIBS
905+
${STARROCKS_LINK_LIBS}
906+
${WL_START_GROUP}
907+
${DIRECT_CONNECTOR_LINK_LIBS}
908+
${WL_END_GROUP}
909+
)
901910

902911
# Only build static libs
903912
set(BUILD_SHARED_LIBS OFF)

0 commit comments

Comments
 (0)