[Tool] Build VelocyPack with C++17 on macOS (#76142)

Signed-off-by: alvin-phoenix-ai <alvin.zhao@phoenixdata.ai>

Author: alvin-phoenix-ai

be/src/column/arrow/arrow_to_json_converter.cpp

@@ -19,6 +19,7 @@
 
 #include <memory>
 #include <string>
+#include <string_view>
 
 #include "arrow/array.h"
 #include "arrow/type.h"

be/src/exprs/cast_expr_json.cpp

@@ -14,6 +14,8 @@
 
 #include <velocypack/Exception.h>
 
+#include <string_view>
+
 #include "column/array_column.h"
 #include "column/column_builder.h"
 #include "column/column_visitor_adapter.h"
@@ -103,14 +105,7 @@ class CastColumnItemVisitor final : public ColumnVisitorAdapter<CastColumnItemVi
 
     Status do_visit(const BinaryColumn& col) {
         Slice slice = col.get_slice(_row);
-#ifdef __APPLE__
-        // On macOS, velocypack's template overload resolution may not correctly
-        // match std::string_view constructor, causing "Must give a string or char const*" error.
-        // Use std::string explicitly to avoid type ambiguity.
-        _add_element(std::string(slice.data, slice.size));
-#else
         _add_element(std::string_view(slice.data, slice.size));
-#endif
         return {};
     }
 
@@ -276,4 +271,4 @@ StatusOr<std::string> cast_type_to_json_str(const ColumnPtr& column, int idx, bo
     return result;
 }
 
-} // namespace starrocks
+} // namespace starrocks

thirdparty/build-thirdparty-darwin.sh

@@ -921,6 +921,8 @@ build_vpack() {
         -DCMAKE_BUILD_TYPE=Release \
         -DCMAKE_INSTALL_PREFIX="${TP_INSTALL_DIR}" \
         -DCMAKE_INSTALL_LIBDIR=lib \
+        -DCMAKE_CXX_STANDARD=17 \
+        -DCMAKE_CXX_STANDARD_REQUIRED=ON \
         -DCMAKE_POSITION_INDEPENDENT_CODE=ON \
         -DBUILD_SHARED_LIBS=OFF \
         -DCMAKE_CXX_FLAGS="$(append_flags "${CXXFLAGS}" "-D_LIBCPP_HAS_NO_HASH_MEMORY=1")" \

thirdparty/build-thirdparty.sh

@@ -1290,10 +1290,12 @@ build_aws_cpp_sdk() {
 build_vpack() {
     check_if_source_exist $VPACK_SOURCE
     cd $TP_SOURCE_DIR/$VPACK_SOURCE
+    rm -rf build
     mkdir -p build
     cd build
     $CMAKE_CMD .. \
         -DCMAKE_CXX_STANDARD="17" \
+        -DCMAKE_CXX_STANDARD_REQUIRED=ON \
         -G "${CMAKE_GENERATOR}" \
         -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=${TP_INSTALL_DIR} \
         -DCMAKE_CXX_COMPILER=$STARROCKS_GCC_HOME/bin/g++ -DCMAKE_C_COMPILER=$STARROCKS_GCC_HOME/bin/gcc