[Refactor] Replace TableName with TableRef in AST #66662
+2,594
−1,597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🧪 CI InsightsHere's what we observed from your CI run for 0b360ee. 🟢 All jobs passed!But CI Insights is watching 👀 |
Contributor
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
fe/fe-core/src/main/java/com/starrocks/service/FrontendServiceImpl.java
Outdated
Show resolved
Hide resolved
HangyuanLiu
force-pushed
the
1211-table-name
branch
from
fe10348 to
0b360ee
Compare
Contributor
|
@cursor review |
fe/fe-core/src/main/java/com/starrocks/sql/analyzer/AuthorizerStmtVisitor.java
Show resolved
Hide resolved
HangyuanLiu
force-pushed
the
1211-table-name
branch
3 times, most recently
from
97527f7 to
aa8f1fe
Compare
Contributor
|
@cursor review |
fe/fe-core/src/main/java/com/starrocks/server/LocalMetastore.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/com/starrocks/sql/analyzer/AuthorizerStmtVisitor.java
Show resolved
Hide resolved
HangyuanLiu
force-pushed
the
1211-table-name
branch
from
aa8f1fe to
b1a9b37
Compare
Contributor
|
@cursor review |
fe/fe-core/src/main/java/com/starrocks/connector/iceberg/IcebergMetadata.java
Outdated
Show resolved
Hide resolved
…nStmt and related classes
… related classes # Conflicts: # fe/fe-core/src/test/java/com/starrocks/analysis/ShowCreateTableStmtTest.java
…d related classes
# Conflicts: # fe/fe-core/src/main/java/com/starrocks/sql/DeletePlanner.java # fe/fe-core/src/main/java/com/starrocks/sql/analyzer/DeleteAnalyzer.java
HangyuanLiu
force-pushed
the
1211-table-name
branch
from
b1a9b37 to
0e9b629
Compare
…utor, IcebergMetadata, LocalMetastore, and related classes
HangyuanLiu
force-pushed
the
1211-table-name
branch
from
0e9b629 to
34960e0
Compare
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 1006 / 1205 (83.49%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Contributor
|
@cursor review |
| String tableName = stmt.getTableName().toSql(); | ||
| TableRef tableRef = stmt.getTableRef(); | ||
| TableName tableNameObj = TableName.fromTableRef(tableRef); | ||
| String tableName = tableNameObj.toSql(); |
There was a problem hiding this comment.
Missing null check causes NPE in partition pruning
The partitionPruneForDelete method calls TableName.fromTableRef(tableRef) without checking if tableRef is null first. Since fromTableRef returns null when given null input, the subsequent call to tableNameObj.toSql() will throw a NullPointerException. While the process method has a null check for tableRef, the public method extractPartitionNamesByCondition directly calls partitionPruneForDelete without this protection, allowing callers to trigger the NPE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
This pull request refactors how table names are handled throughout the codebase, moving from direct usage of
TableNameobjects to consistently constructing them fromTableRefinstances. This change standardizes table identification, making the code more robust and easier to maintain, especially when working with parsed SQL statements. Several visitor methods and job classes are updated to use the new utility methodTableName.fromTableRef, and parser logic is adjusted to propagateTableRefinstead ofTableNamewhere appropriate.Core Table Name Handling Refactor:
fromTableRefto theTableNameclass, allowing construction of aTableNamefrom aTableRefobject. This is now the preferred way to obtain aTableNamefrom AST nodes.AlterJobExecutor,ConnectorAlterTableExecutor,ColumnPrivilege) to useTableName.fromTableRefinstead of directly accessing or storingTableNamefrom statements. [1] [2] [3] [4] [5] [6] [7]Parser and Statement Construction Updates:
AstBuilder) to propagateTableRefinstead ofTableNameinInsertStmt,CreateTableStmt, andDropTableStmtconstruction, aligning with the new table name handling approach. [1] [2] [3]Job and Manager Class Adjustments:
DeleteMgr,ExportJob,InsertOverwriteJobRunner,Pipe) to extract database and table names fromTableRefrather thanTableName, ensuring consistency and leveraging the new utility method. [1] [2] [3] [4] [5] [6]Iceberg and Stream Load Integration:
TableRefand constructTableNamevia the new method, improving error reporting and logging. [1] [2]TableNamereferences in stream load and related classes. [1] [2]These changes collectively improve the maintainability and correctness of table name handling across the codebase by ensuring a single, reliable pathway from SQL AST to persistent table identification.
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
Note
Unifies table identification across the stack by switching from direct
TableNameusage toTableRefin AST, analyzers, planners, and executors, with on-demand conversion viaTableName.fromTableRef.TableName.fromTableRefandAnalyzerUtils.normalizedTableRef; updates DML/DDL analyzers, authorizer, planners, and executors to store/useTableRefand constructTableNameonly when neededAstBuilder) now buildsInsertStmt/CreateTableStmt/DropTableStmtwithTableRefDeleteMgr,ExportJob,InsertOverwriteJobRunner,Pipe, Iceberg metadata/rewrite) to pull db/table fromTableRef; improves error messages/loggingShowExecutorhelpers and multiple SHOW paths to accept/useTableRef; replaces calls inShowExecutor/authorizerTableRef(e.g.,CreateTableAnalyzer,CreateTableLikeAnalyzer,CancelAlterTableStmt,AlterJobExecutor,ConnectorAlterTableExecutor)TableRefand adjusts privilege checks accordinglyNo functional changes intended; primarily API/refactor for consistency and maintainability.
Written by Cursor Bugbot for commit 34960e0. This will update automatically on new commits. Configure here.