[BugFix] fixed `ALTER STORAGE VOLUME [IF EXISTS]` #66691

Dan-J-D · 2025-12-12T23:48:30Z

Why I'm doing:

According to this, the syntax is

ALTER STORAGE VOLUME [ IF EXISTS ] <storage_volume_name>
{ COMMENT = '<comment_string>'
| SET ("key" = "value"[,...]) }

But doesn't support IF EXISTS.

What I'm doing:

Fixes syntax to add IF EXISTS.

What type of PR is this:

Does this PR entail a change in behavior?

Yes, this PR will result in a change in behavior.
No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

Interface/UI changes: syntax, type conversion, expression evaluation, display information
Parameter changes: default values, similar parameters but with different default values
Policy changes: use new policy to replace old one, functionality automatically enabled
Feature removed
Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

I have added test cases for my bug fix or my new feature
This pr needs user documentation (for new or modified features or behaviors)
- I have added documentation for my new feature or new function
This is a backport pr

Bugfix cherry-pick branch check:

Note

Implements IF EXISTS for ALTER STORAGE VOLUME and aligns not-found behavior across layers.

Grammar: allow ALTER STORAGE VOLUME (IF EXISTS)? ...; AstBuilder passes the flag; AlterStorageVolumeStmt stores ifExists.
Executor: visitAlterStorageVolumeStatement ignores MetaNotFoundException when IF EXISTS is set.
Manager: StorageVolumeMgr.updateStorageVolume(...) now throws MetaNotFoundException if the volume is missing; signature updated and immutable-property checks preserved.
Tests: updated unit tests to expect MetaNotFoundException; added SQL tests for ALTER STORAGE VOLUME IF EXISTS behavior.

^{Written by Cursor Bugbot for commit 487193f. This will update automatically on new commits. Configure here.}

mergify · 2025-12-12T23:49:25Z

🧪 CI Insights

Here's what we observed from your CI run for 38c975c.

🟢 All jobs passed!

But CI Insights is watching 👀

alvin-celerdata · 2025-12-13T00:42:58Z

@cursor review

fe/fe-core/src/test/java/com/starrocks/server/SharedDataStorageVolumeMgrTest.java

alvin-celerdata · 2025-12-13T03:45:22Z

@cursor review

fe/fe-core/src/main/java/com/starrocks/server/StorageVolumeMgr.java

fe/fe-core/src/main/java/com/starrocks/qe/DDLStmtExecutor.java

alvin-celerdata · 2025-12-13T16:47:08Z

@cursor review

fe/fe-core/src/main/java/com/starrocks/qe/DDLStmtExecutor.java

fe/fe-core/src/test/java/com/starrocks/server/SharedDataStorageVolumeMgrTest.java

alvin-celerdata · 2025-12-14T01:03:54Z

@cursor review

Copilot

Pull request overview

This PR adds support for the IF EXISTS clause to the ALTER STORAGE VOLUME statement, aligning the implementation with the documented SQL syntax. The change propagates the ifExists flag through the AST and updates the storage volume manager to throw MetaNotFoundException instead of using precondition checks when a volume doesn't exist.

Key Changes:

Added IF EXISTS syntax support to the SQL grammar for ALTER STORAGE VOLUME
Threaded ifExists boolean flag through AlterStorageVolumeStmt and related code
Changed StorageVolumeMgr.updateStorageVolume methods to throw MetaNotFoundException instead of failing precondition checks

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
fe/fe-grammar/src/main/antlr/com/starrocks/grammar/StarRocks.g4	Added optional `IF EXISTS` clause to `alterStorageVolumeStatement` grammar rule
fe/fe-parser/src/main/java/com/starrocks/sql/ast/AlterStorageVolumeStmt.java	Added `ifExists` field, updated constructor signature, and added `isSetIfExists()` accessor method
fe/fe-core/src/main/java/com/starrocks/sql/parser/AstBuilder.java	Updated to parse `IF EXISTS` and pass it to `AlterStorageVolumeStmt` constructor
fe/fe-core/src/main/java/com/starrocks/server/StorageVolumeMgr.java	Changed all `updateStorageVolume` overloads to throw `MetaNotFoundException`; replaced precondition check with explicit exception throw
fe/fe-core/src/main/java/com/starrocks/qe/DDLStmtExecutor.java	Reformatted lambda for alter storage volume execution (added braces)
fe/fe-core/src/test/java/com/starrocks/qe/RedirectStatusTest.java	Updated test to use new `AlterStorageVolumeStmt` constructor with `ifExists` parameter
fe/fe-core/src/test/java/com/starrocks/server/SharedDataStorageVolumeMgrTest.java	Added `MetaNotFoundException` to method signature and fixed variable naming consistency

fe/fe-core/src/main/java/com/starrocks/qe/DDLStmtExecutor.java

alvin-celerdata · 2025-12-15T17:30:56Z

@cursor review

Dan-J-D · 2025-12-18T16:11:42Z

Any update?

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

fe/fe-parser/src/main/java/com/starrocks/sql/ast/AlterStorageVolumeStmt.java:60

Missing toSql() method implementation. Similar storage volume statements like DropStorageVolumeStmt implement toSql() to properly represent the IF EXISTS clause in the SQL string. AlterStorageVolumeStmt should also implement toSql() to include "IF EXISTS" when the ifExists flag is true, ensuring consistency across storage volume statements and proper SQL representation for logging and debugging purposes.

    @Override
    public <R, C> R accept(AstVisitor<R, C> visitor, C context) {
        return visitor.visitAlterStorageVolumeStatement(this, context);
    }

kevincai

new test case shall be added to cover this new added IF EXISTS check. either in unit test or in sql-test

fe/fe-core/src/test/java/com/starrocks/server/SharedDataStorageVolumeMgrTest.java

fe/fe-core/src/main/java/com/starrocks/server/StorageVolumeMgr.java

alvin-celerdata · 2025-12-26T22:01:50Z

@mergify rebase

Signed-off-by: Dan-J-D <[email protected]>

Co-authored-by: Kevin Cai <[email protected]> Signed-off-by: Dan-J-D <[email protected]>

Signed-off-by: Dan-J-D <[email protected]>

mergify · 2025-12-26T22:02:21Z

rebase

✅ Branch has been successfully rebased

alvin-celerdata · 2025-12-26T22:03:14Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no bugs!

sonarqubecloud · 2025-12-26T22:11:54Z

Quality Gate passed

Issues
9 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2025-12-26T23:04:28Z

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2025-12-26T23:05:25Z

[FE Incremental Coverage Report]

❌ fail : 5 / 9 (55.56%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	com/starrocks/server/StorageVolumeMgr.java	1	2	50.00%	[186]
🔵	com/starrocks/qe/DDLStmtExecutor.java	4	7	57.14%	[1150, 1151, 1152]

github-actions · 2025-12-26T23:05:38Z

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2025-12-27T18:23:01Z

@Mergifyio backport branch-4.0

mergify · 2025-12-27T18:23:10Z

backport branch-4.0

✅ Backports have been created

Details

#67278 [BugFix] fixed ALTER STORAGE VOLUME [IF EXISTS] (backport #66691) has been created for branch branch-4.0 but encountered conflicts

## Why I'm doing: According to [this](https://docs.starrocks.io/docs/sql-reference/sql-statements/cluster-management/storage_volume/ALTER_STORAGE_VOLUME/), the syntax is ```sql ALTER STORAGE VOLUME [ IF EXISTS ] <storage_volume_name> { COMMENT = '<comment_string>' | SET ("key" = "value"[,...]) } ``` But doesn't support `IF EXISTS`. ## What I'm doing: Fixes syntax to add `IF EXISTS`. Signed-off-by: Dan-J-D <[email protected]> Co-authored-by: Kevin Cai <[email protected]> (cherry picked from commit bf73f06) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/sql/ast/AlterStorageVolumeStmt.java # fe/fe-core/src/test/java/com/starrocks/qe/RedirectStatusTest.java

Dan-J-D requested a review from a team as a code owner December 12, 2025 23:48

github-actions bot added the title needs [type] label Dec 12, 2025

mergify bot assigned Dan-J-D Dec 12, 2025

Dan-J-D changed the title ~~fix: ALTER STORAGE VOLUME [IF EXISTS]~~ [BugFix] fixed ALTER STORAGE VOLUME [IF EXISTS] Dec 12, 2025

github-actions bot added 4.0 and removed title needs [type] labels Dec 12, 2025

Dan-J-D force-pushed the fix-alter-storage-volume branch from 089a517 to c2c97f2 Compare December 12, 2025 23:56

github-actions bot added the behavior_changed label Dec 13, 2025

cursor bot reviewed Dec 13, 2025

View reviewed changes

fe/fe-core/src/test/java/com/starrocks/server/SharedDataStorageVolumeMgrTest.java Outdated Show resolved Hide resolved

Dan-J-D force-pushed the fix-alter-storage-volume branch from ac052e4 to 38c975c Compare December 13, 2025 01:30

cursor bot reviewed Dec 13, 2025

View reviewed changes

fe/fe-core/src/main/java/com/starrocks/server/StorageVolumeMgr.java Show resolved Hide resolved

alvin-celerdata reviewed Dec 13, 2025

View reviewed changes

fe/fe-core/src/main/java/com/starrocks/qe/DDLStmtExecutor.java Outdated Show resolved Hide resolved

Dan-J-D force-pushed the fix-alter-storage-volume branch from e2f2d13 to a5ac114 Compare December 13, 2025 15:04

cursor bot reviewed Dec 13, 2025

View reviewed changes

fe/fe-core/src/main/java/com/starrocks/qe/DDLStmtExecutor.java Show resolved Hide resolved

fe/fe-core/src/test/java/com/starrocks/server/SharedDataStorageVolumeMgrTest.java Outdated Show resolved Hide resolved

kevincai requested review from Copilot and kevincai December 14, 2025 03:00

Copilot started reviewing on behalf of kevincai December 14, 2025 03:01 View session

Copilot AI reviewed Dec 14, 2025

View reviewed changes

fe/fe-core/src/main/java/com/starrocks/qe/DDLStmtExecutor.java Outdated Show resolved Hide resolved

fe/fe-core/src/main/java/com/starrocks/qe/DDLStmtExecutor.java Outdated Show resolved Hide resolved

kevincai requested a review from Copilot December 19, 2025 08:30

Copilot started reviewing on behalf of kevincai December 19, 2025 08:31 View session

Copilot AI reviewed Dec 19, 2025

View reviewed changes

kevincai reviewed Dec 19, 2025

View reviewed changes

fe/fe-core/src/test/java/com/starrocks/server/SharedDataStorageVolumeMgrTest.java Show resolved Hide resolved

fe/fe-core/src/main/java/com/starrocks/server/StorageVolumeMgr.java Show resolved Hide resolved

Dan-J-D force-pushed the fix-alter-storage-volume branch from a4c47a7 to 797c309 Compare December 21, 2025 21:06

Dan-J-D dismissed kevincai’s stale review via 929645e December 26, 2025 19:49

Dan-J-D and others added 10 commits December 26, 2025 22:02

fix: ALTER STORAGE VOLUME [IF EXISTS]

c42d3dd

Signed-off-by: Dan-J-D <[email protected]>

fix: invalid test case

f62090d

Signed-off-by: Dan-J-D <[email protected]>

remove: logging for error

0107d58

Signed-off-by: Dan-J-D <[email protected]>

remove: debug code

42f1bb2

Signed-off-by: Dan-J-D <[email protected]>

fix: added semicolon

c17f154

Signed-off-by: Dan-J-D <[email protected]>

added updateStorageVolume handles MetaNotFoundException

0a34165

Signed-off-by: Dan-J-D <[email protected]>

added sql test case for ALTER TABLE IF EXISTS

bd10990

Signed-off-by: Dan-J-D <[email protected]>

Update alter_storage_volume

ba216f6

Co-authored-by: Kevin Cai <[email protected]> Signed-off-by: Dan-J-D <[email protected]>

Update test/sql/test_storage_volume/T/alter_storage_volume

9f3f929

Co-authored-by: Kevin Cai <[email protected]> Signed-off-by: Dan-J-D <[email protected]>

fixed 2 test cases with expected exceptions

487193f

Signed-off-by: Dan-J-D <[email protected]>

alvin-celerdata force-pushed the fix-alter-storage-volume branch from 929645e to 487193f Compare December 26, 2025 22:02

cursor bot reviewed Dec 26, 2025

View reviewed changes

alvin-celerdata approved these changes Dec 26, 2025

View reviewed changes

kevincai approved these changes Dec 27, 2025

View reviewed changes

kevincai enabled auto-merge (squash) December 27, 2025 10:42

alvin-celerdata disabled auto-merge December 27, 2025 18:22

alvin-celerdata merged commit bf73f06 into StarRocks:main Dec 27, 2025
83 of 85 checks passed

github-actions bot removed the 4.0 label Dec 27, 2025

mergify bot mentioned this pull request Dec 27, 2025

[BugFix] fixed ALTER STORAGE VOLUME [IF EXISTS] (backport #66691) #67278

Closed

23 tasks

[BugFix] fixed ALTER STORAGE VOLUME [IF EXISTS] #66691

[BugFix] fixed ALTER STORAGE VOLUME [IF EXISTS] #66691

Uh oh!

Conversation

Dan-J-D commented Dec 12, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why I'm doing:

What I'm doing:

What type of PR is this:

Checklist:

Bugfix cherry-pick branch check:

Uh oh!

mergify bot commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🧪 CI Insights

🟢 All jobs passed!

Uh oh!

alvin-celerdata commented Dec 13, 2025

Uh oh!

Uh oh!

alvin-celerdata commented Dec 13, 2025

Uh oh!

Uh oh!

Uh oh!

alvin-celerdata commented Dec 13, 2025

Uh oh!

Uh oh!

Uh oh!

alvin-celerdata commented Dec 14, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

alvin-celerdata commented Dec 15, 2025

Uh oh!

Dan-J-D commented Dec 18, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

kevincai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

alvin-celerdata commented Dec 26, 2025

Uh oh!

mergify bot commented Dec 26, 2025

✅ Branch has been successfully rebased

Uh oh!

alvin-celerdata commented Dec 26, 2025

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Dec 26, 2025

Quality Gate passed

Uh oh!

github-actions bot commented Dec 26, 2025

[Java-Extensions Incremental Coverage Report]

Uh oh!

github-actions bot commented Dec 26, 2025

[FE Incremental Coverage Report]

file detail

Uh oh!

github-actions bot commented Dec 26, 2025

[BE Incremental Coverage Report]

Uh oh!

Uh oh!

github-actions bot commented Dec 27, 2025

Uh oh!

mergify bot commented Dec 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

[BugFix] fixed `ALTER STORAGE VOLUME [IF EXISTS]` #66691

[BugFix] fixed `ALTER STORAGE VOLUME [IF EXISTS]` #66691

Dan-J-D commented Dec 12, 2025 •

edited by cursor bot

Loading

mergify bot commented Dec 12, 2025 •

edited

Loading

mergify bot commented Dec 27, 2025 •

edited

Loading